From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1E7201B445 for ; Mon, 7 Jan 2019 16:54:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 07:54:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,451,1539673200"; d="scan'208";a="123945495" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jan 2019 07:54:39 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by IRSMSX109.ger.corp.intel.com ([169.254.13.133]) with mapi id 14.03.0415.000; Mon, 7 Jan 2019 15:54:38 +0000 From: "Dumitrescu, Cristian" To: Eelco Chaudron , Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support Thread-Index: AQHUpDXDK3FHTjbkUU22+Fhz1yuZF6WfgtyAgAPtmgCAAIkgMA== Date: Mon, 7 Jan 2019 15:54:38 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E826E43@IRSMSX108.ger.corp.intel.com> References: <154661036216.75321.4852909033090962683.stgit@dbuild> <154661038141.75321.10886021990395716851.stgit@dbuild> <20190104114235.228a31f9@hermes.lan> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDk5ODc5ODktN2VmYS00ZjFhLTk3N2EtMzljNjZkZjc4MmYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT2EzdlUzMDVQTXUwOTRkYU1oV1d1aTlrQ3M3RXp2YlZQMlQ4RCsyN0MzYzhiQ1g1d0VvcUVNNmZ3R21hZlJ3NCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM meter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 15:54:42 -0000 > -----Original Message----- > From: Eelco Chaudron [mailto:echaudro@redhat.com] > Sent: Monday, January 7, 2019 7:42 AM > To: Stephen Hemminger ; Dumitrescu, > Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTC= M > meter support >=20 >=20 >=20 > On 4 Jan 2019, at 20:42, Stephen Hemminger wrote: >=20 > > On Fri, 4 Jan 2019 13:59:42 +0000 > > Eelco Chaudron wrote: > > > >> This patch adds support for RFC4115 trTCM meters. > >> > >> Signed-off-by: Eelco Chaudron > > > > > > > > Fix comment formatting. >=20 > Hi Stephen, I left these warnings in on purpose, to match the existing > comment style in the file. >=20 > These specific warnings are from a structure copied from one right above > which also has the same style and line lengths. >=20 > As they are warning I though I should leave it as is, Christian what are > your thoughts on this? >=20 I agree with Eelco, we can later on send a patch to adjust the whole file t= o the latest coding standard rather than change just a few lines inconsiste= ntly. > > > > ### [dpdk-dev] [PATCH v4 1/2] lib/librte_meter: add RFC4115 trTCM > > meter support > > > > WARNING:BLOCK_COMMENT_STYLE: Block comments use * on > subsequent lines > > #172: FILE: lib/librte_meter/rte_meter.h:59: > > +/** trTCM parameters per metered traffic flow. The CIR, EIR, CBS and > > EBS > > +parameters only count bytes of IP packets and do not include link > > specific > > > > WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a > > separate line > > #174: FILE: lib/librte_meter/rte_meter.h:61: > > +none-zero respectively.*/ > > > > WARNING:LONG_LINE_COMMENT: line over 80 characters > > #176: FILE: lib/librte_meter/rte_meter.h:63: > > + uint64_t cir; /**< Committed Information Rate (CIR). Measured in > > bytes per second. */ > > > > WARNING:LONG_LINE_COMMENT: line over 80 characters > > #177: FILE: lib/librte_meter/rte_meter.h:64: > > + uint64_t eir; /**< Excess Information Rate (EIR). Measured in bytes > > per second. */ > > > > WARNING:LONG_LINE_COMMENT: line over 80 characters > > #355: FILE: lib/librte_meter/rte_meter.h:406: > > + /**< Number of bytes currently available in the excess(E) token > > bucket */ > > > > total: 0 errors, 5 warnings, 356 lines checked