From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 030ECF11 for ; Wed, 16 Jan 2019 10:33:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 01:33:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,485,1539673200"; d="scan'208";a="136222633" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga004.fm.intel.com with ESMTP; 16 Jan 2019 01:33:41 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by irsmsx105.ger.corp.intel.com ([169.254.7.116]) with mapi id 14.03.0415.000; Wed, 16 Jan 2019 09:33:40 +0000 From: "Dumitrescu, Cristian" To: "Pattan, Reshma" , Stephen Hemminger CC: "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" , "Rao, Nikhil" , "olivier.matz@6wind.com" , "thomas@monjalon.net" , "Singh, Jasvinder" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field Thread-Index: AQHUmF3i4q8kKiOdRkaQOdD0ETTJJ6WxFPKAgACzXYCAAAPFAA== Date: Wed, 16 Jan 2019 09:33:40 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E82AB5F@IRSMSX108.ger.corp.intel.com> References: <20181219154237.836-1-reshma.pattan@intel.com> <20181220121609.16314-1-reshma.pattan@intel.com> <20181220121609.16314-2-reshma.pattan@intel.com> <20190115143705.08764641@shemminger-XPS-13-9360> <3AEA2BF9852C6F48A459DA490692831F2A40107F@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A40107F@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjUxODQzODgtYTQzNC00OWIzLWExZTgtMWY0YThmNGM2MjM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUUpuZHNYWVRHN25GSTZyeFljQWtPaGg3ckRGTTdRa1JKQ3lWT3NvNjN1aUlEM3Bidk9WKzlEZjRqaGgxTnFjYyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 09:33:44 -0000 > -----Original Message----- > From: Pattan, Reshma > Sent: Wednesday, January 16, 2019 9:19 AM > To: Stephen Hemminger > Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Rao, Nikhil > ; olivier.matz@6wind.com; thomas@monjalon.net; > Singh, Jasvinder ; Dumitrescu, Cristian > ; Ananyev, Konstantin > > Subject: RE: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for > sched field >=20 > Hi >=20 > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Tuesday, January 15, 2019 10:37 PM > > To: Pattan, Reshma > > Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Rao, Nikhil > > ; olivier.matz@6wind.com; thomas@monjalon.net; > > Singh, Jasvinder ; Dumitrescu, Cristian > > ; Ananyev, Konstantin > > > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format > for > > sched field > > > > On Thu, 20 Dec 2018 12:16:09 +0000 > > Reshma Pattan wrote: > > > > > This patch implements the changes proposed in the deprecation notes > > > [1][2]. > > > > > > librte_mbuf changes: > > > The mbuf->hash.sched field is updated to support generic definition i= n > > > line with the ethdev traffic manager and meter APIs. > > > The new generic format contains: queue ID, traffic class, color. > > > > > > Added public APIs to set and get these new fields to and from mbuf. > > > > > > librte_sched changes: > > > In addtion, following API functions of the sched library have been > > > modified with an additional parameter of type struct rte_sched_port t= o > > > accommodate the changes made to mbuf sched field. > > > (i)rte_sched_port_pkt_write() > > > (ii) rte_sched_port_pkt_read_tree_path() > > > > > > librte_pipeline, qos_sched UT, qos_sched app are updated to make use > > > of new changes. > > > > > > Also mbuf->hash.txadapter has been added for eventdev txq, > > > rte_event_eth_tx_adapter_txq_set and > > > rte_event_eth_tx_adapter_txq_get() > > > are updated to use mbuf->hash.txadapter.txq. > > > > > > doc: > > > Release notes updated. > > > Removed deprecation notice for mbuf->hash.sched and sched API. > > > > > > [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html > > > [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html > > > > > > Signed-off-by: Jasvinder Singh > > > Signed-off-by: Reshma Pattan > > > Acked-by: Cristian Dumitrescu > > > Acked-by: Konstantin Ananyev > > > > > > This patch breaks build of VPP because it refers to sched.hi and sched.= lo. > > Breaking source compatibility is as bad (if not worse) than ABI breakag= e. > > >=20 > Yes this breaks the build and we have actions to fix VPP Qos Sched when > DPDK 19.02 is formally integrated to VPP. >=20 > Thanks, > Reshma Yes, Jasvinder is the maintainer of the VPP HQoS code, this is on his plate= to fix in VPP for the next VPP release using DPDK release 19.02.