From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Babu Radhakrishnan,
AgalyaX" <agalyax.babu.radhakrishnan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples: modify error message for ip pipeline
Date: Tue, 9 Jul 2019 09:31:09 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E8EBD48@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1560521132-12232-1-git-send-email-agalyax.babu.radhakrishnan@intel.com>
> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Friday, June 14, 2019 3:06 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Babu Radhakrishnan, AgalyaX
> <agalyax.babu.radhakrishnan@intel.com>
> Subject: [PATCH] examples: modify error message for ip pipeline
>
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
>
> Added help command in error message for ip pipeline commands.
>
> Signed-off-by: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan@intel.com>
> ---
> examples/ip_pipeline/cli.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index 309b2936e..8a651bbbc 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -30,12 +30,12 @@
>
> #define MSG_OUT_OF_MEMORY "Not enough memory.\n"
> #define MSG_CMD_UNKNOWN "Unknown command \"%s\".\n"
> -#define MSG_CMD_UNIMPLEM "Command \"%s\" not implemented.\n"
> -#define MSG_ARG_NOT_ENOUGH "Not enough arguments for command
> \"%s\".\n"
> -#define MSG_ARG_TOO_MANY "Too many arguments for command
> \"%s\".\n"
> -#define MSG_ARG_MISMATCH "Wrong number of arguments for
> command \"%s\".\n"
> -#define MSG_ARG_NOT_FOUND "Argument \"%s\" not found.\n"
> -#define MSG_ARG_INVALID "Invalid value for argument \"%s\".\n"
> +#define MSG_CMD_UNIMPLEM "Command \"%s\" not implemented. Try
> help <cmd>\n"
> +#define MSG_ARG_NOT_ENOUGH "Not enough arguments for command
> \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_TOO_MANY "Too many arguments for command
> \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_MISMATCH "Wrong number of arguments for
> command \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_NOT_FOUND "Argument \"%s\" not found. Try help
> <cmd>\n"
> +#define MSG_ARG_INVALID "Invalid value for argument \"%s\". Try help
> <cmd>\n"
> #define MSG_FILE_ERR "Error in file \"%s\" at line %u.\n"
> #define MSG_FILE_NOT_ENOUGH "Not enough rules in file \"%s\".\n"
> #define MSG_CMD_FAIL "Command \"%s\" failed.\n"
> --
> 2.14.1
NAK
I don't see the value to add "try help command" on all the error messages, the user is already aware that there is a help command available, and some people might actually find this repetition annoying.
next prev parent reply other threads:[~2019-07-09 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 14:05 Agalya Babu RadhaKrishnan
2019-07-09 9:31 ` Dumitrescu, Cristian [this message]
2019-07-26 13:41 ` Babu Radhakrishnan, AgalyaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891268E8EBD48@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).