From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EFCAA00E6 for ; Tue, 9 Jul 2019 11:31:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87DEB322C; Tue, 9 Jul 2019 11:31:13 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DA998A3 for ; Tue, 9 Jul 2019 11:31:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 02:31:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,470,1557212400"; d="scan'208";a="364530979" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga006.fm.intel.com with ESMTP; 09 Jul 2019 02:31:10 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.229]) by IRSMSX151.ger.corp.intel.com ([169.254.4.41]) with mapi id 14.03.0439.000; Tue, 9 Jul 2019 10:31:09 +0100 From: "Dumitrescu, Cristian" To: "Babu Radhakrishnan, AgalyaX" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [PATCH] examples: modify error message for ip pipeline Thread-Index: AQHVIrpZbEdWEMnqA0+yFsOOtPhyQ6bCKz9g Date: Tue, 9 Jul 2019 09:31:09 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E8EBD48@IRSMSX108.ger.corp.intel.com> References: <1560521132-12232-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> In-Reply-To: <1560521132-12232-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk2OGExOTUtNjdhNS00OTgzLThkM2UtZDViNWExYjNlOGFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN1FaaGZoNzZ4YmZkaDJPdjZnZ0RLdjRLaVA5OTV6RjFjQVJXNXZJcTVGZDZLN0REMzFoVTFDbFN5cjBHRGtycCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples: modify error message for ip pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Babu Radhakrishnan, AgalyaX > Sent: Friday, June 14, 2019 3:06 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Dumitrescu, Cristian > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH] examples: modify error message for ip pipeline >=20 > From: Agalya Babu RadhaKrishnan >=20 > Added help command in error message for ip pipeline commands. >=20 > Signed-off-by: Agalya Babu RadhaKrishnan > > --- > examples/ip_pipeline/cli.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c > index 309b2936e..8a651bbbc 100644 > --- a/examples/ip_pipeline/cli.c > +++ b/examples/ip_pipeline/cli.c > @@ -30,12 +30,12 @@ >=20 > #define MSG_OUT_OF_MEMORY "Not enough memory.\n" > #define MSG_CMD_UNKNOWN "Unknown command \"%s\".\n" > -#define MSG_CMD_UNIMPLEM "Command \"%s\" not implemented.\n" > -#define MSG_ARG_NOT_ENOUGH "Not enough arguments for command > \"%s\".\n" > -#define MSG_ARG_TOO_MANY "Too many arguments for command > \"%s\".\n" > -#define MSG_ARG_MISMATCH "Wrong number of arguments for > command \"%s\".\n" > -#define MSG_ARG_NOT_FOUND "Argument \"%s\" not found.\n" > -#define MSG_ARG_INVALID "Invalid value for argument \"%s\".\n" > +#define MSG_CMD_UNIMPLEM "Command \"%s\" not implemented. Try > help \n" > +#define MSG_ARG_NOT_ENOUGH "Not enough arguments for command > \"%s\". Try help \n" > +#define MSG_ARG_TOO_MANY "Too many arguments for command > \"%s\". Try help \n" > +#define MSG_ARG_MISMATCH "Wrong number of arguments for > command \"%s\". Try help \n" > +#define MSG_ARG_NOT_FOUND "Argument \"%s\" not found. Try help > \n" > +#define MSG_ARG_INVALID "Invalid value for argument \"%s\". Try help > \n" > #define MSG_FILE_ERR "Error in file \"%s\" at line %u.\n" > #define MSG_FILE_NOT_ENOUGH "Not enough rules in file \"%s\".\n" > #define MSG_CMD_FAIL "Command \"%s\" failed.\n" > -- > 2.14.1 NAK I don't see the value to add "try help command" on all the error messages, = the user is already aware that there is a help command available, and some = people might actually find this repetition annoying.