From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6664A10DA for ; Wed, 31 Jul 2019 14:19:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60B521C0DC; Wed, 31 Jul 2019 14:19:33 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8BEE11BF57 for ; Wed, 31 Jul 2019 14:19:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 05:19:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,330,1559545200"; d="scan'208";a="371498365" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 31 Jul 2019 05:19:25 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.229]) by IRSMSX106.ger.corp.intel.com ([169.254.8.234]) with mapi id 14.03.0439.000; Wed, 31 Jul 2019 13:19:24 +0100 From: "Dumitrescu, Cristian" To: "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli Thread-Index: AQHVR5PI4omxArHdnkK2dJxXmK1zf6bkpOLQ Date: Wed, 31 Jul 2019 12:19:24 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E8F62EE@IRSMSX108.ger.corp.intel.com> References: <20190731113322.135053-1-jasvinder.singh@intel.com> In-Reply-To: <20190731113322.135053-1-jasvinder.singh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzdjNGYxNTItMTFlZi00ZTAzLTk1NTEtNzdkYTIwMDhlMDc3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWd0bkJxbkpqR1l1K1JFMzZBTWxFSGlwSERVWEZYVjFMcW13TkwrZTZ1SXdmdndiYlplc1pRdU1vRXZER2J6MCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Singh, Jasvinder > Sent: Wednesday, July 31, 2019 12:33 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profil= e > cli >=20 > Since sched library always check the non-zero value of subport tc > ov weight. Therefore, it is necessary to set right value of tc ov > weight even if RTE_SCHED_SUBPORT_TC_OV is disabled. >=20 > Signed-off-by: Jasvinder Singh > --- > examples/ip_pipeline/cli.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c > index f4c2be8b8..c6cf4204e 100644 > --- a/examples/ip_pipeline/cli.c > +++ b/examples/ip_pipeline/cli.c > @@ -469,12 +469,10 @@ cmd_tmgr_pipe_profile(char **tokens, > return; > } >=20 > -#ifdef RTE_SCHED_SUBPORT_TC_OV > if (parser_read_uint8(&p.tc_ov_weight, tokens[19]) !=3D 0) { > snprintf(out, out_size, MSG_ARG_INVALID, > "tc_ov_weight"); > return; > } > -#endif >=20 > for (i =3D 0; i < RTE_SCHED_BE_QUEUES_PER_PIPE; i++) > if (parser_read_uint8(&p.wrr_weights[i], tokens[20 + i]) !=3D 0) > { > -- > 2.21.0 Acked-by: Cristian Dumitrescu We should check that this macro does not show up anymore in any of our apps= .