From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 81AF02C18 for ; Fri, 4 Aug 2017 10:22:24 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2017 01:22:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,320,1498546800"; d="scan'208";a="136071393" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga006.fm.intel.com with ESMTP; 04 Aug 2017 01:22:22 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.36]) by IRSMSX108.ger.corp.intel.com ([169.254.11.133]) with mapi id 14.03.0319.002; Fri, 4 Aug 2017 09:22:21 +0100 From: "Hunt, David" To: Thomas Monjalon CC: "dev@dpdk.org" , "shreyansh.jain@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig Thread-Index: AQHS35uxPuKjDBUdrkG/Lp4BtDHj06JzgtcAgACv2gA= Date: Fri, 4 Aug 2017 08:22:20 +0000 Message-ID: <3F5BA2D9419A984DBB40DB5CFACBB36D1F9D8F2F@IRSMSX101.ger.corp.intel.com> References: <1495788764-37652-2-git-send-email-david.hunt@intel.com> <1496846277-280267-1-git-send-email-david.hunt@intel.com> <1496846277-280267-2-git-send-email-david.hunt@intel.com> <2019184.UUXt4e9AVR@xps> In-Reply-To: <2019184.UUXt4e9AVR@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 08:22:25 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 Sent: Thursday, 3 August, 2017 11:40 PM To: Hunt, David Cc: dev@dpdk.org; shreyansh.jain@nxp.com Subject: Re: [dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with= defconfig 07/06/2017 16:37, David Hunt: > Users can now use 'make defconfig' to generate a configuration using=20 > the most appropriate defaults for the current machine. >=20 > > arch taken from uname -m > machine defaults to native > execenv is taken from uname, Linux=3Dlinuxapp, otherwise bsdapp > toolchain is taken from $CC -v to see which compiler to use >=20 > Signed-off-by: David Hunt > Acked-by: Shreyansh Jain Looks to be a good idea if it is really automatic. > + ${CC} -v 2>&1 | \ > + grep " version " | cut -d ' ' -f 1) Unfortunately, it depends on $CC which is not commonly exported. What about defaulting to gcc? > - @echo "Configuration done" > + @echo "Configuration done using "$(shell basename \ > + $(RTE_CONFIG_TEMPLATE) | sed "s/defconfig_//g") RTE_CONFIG_TEMPLATE is not defined in this patch (and I do not see the bene= fit in next patch). Thomas,=20 Does this mean that this patch is not going into this release? It has = been acked for almost a month now, with no further comment. The one hour be= tween your comment and the release of RC4 did not give me a reasonable amou= nt of time to address your concerns. I also feel that the lack of comments = in the last month should mean that the patch should be applied as is. If ch= anges are required, I am happy to address in the next release.=20 Regards, Dave.