DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: "Coyle, David" <david.coyle@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix set VF MAC address
Date: Tue, 23 Jan 2018 14:29:28 +0000	[thread overview]
Message-ID: <3F5BA2D9419A984DBB40DB5CFACBB36D1FA8F1C7@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1516716855-14805-1-git-send-email-david.coyle@intel.com>

Replying to notify <stable@dpdk.org>, which was missing from original mail.

-----Original Message-----
From: Coyle, David 
Sent: Tuesday, 23 January, 2018 2:14 PM
To: dev@dpdk.org
Cc: Hunt, David <david.hunt@intel.com>; stable@intel.com; Coyle, David <david.coyle@intel.com>
Subject: [PATCH] examples/vm_power_manager: fix set VF MAC address

Current code only sets mac address of first VF. Fix code so that it continues through the loop and sets the mac address of each VF.

Fixes: c9a4779135c9 ("examples/vm_power_mgr: set MAC address of VF")

Signed-off-by: David Coyle <david.coyle@intel.com>
---
 examples/vm_power_manager/main.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
index a50984d..a9f5ad1 100644
--- a/examples/vm_power_manager/main.c
+++ b/examples/vm_power_manager/main.c
@@ -290,7 +290,7 @@ main(int argc, char **argv)
 	for (portid = 0; portid < nb_ports; portid++) {
 		struct ether_addr eth;
 		int w, j;
-		int ret = -ENOTSUP;
+		int ret;
 
 		if ((enabled_port_mask & (1 << portid)) == 0)
 			continue;
@@ -308,8 +308,7 @@ main(int argc, char **argv)
 		for (w = 0; w < MAX_VFS; w++) {
 			eth.addr_bytes[5] = w + 0xf0;
 
-			if (ret == -ENOTSUP)
-				ret = rte_pmd_ixgbe_set_vf_mac_addr(portid,
+			ret = rte_pmd_ixgbe_set_vf_mac_addr(portid,
 						w, &eth);
 			if (ret == -ENOTSUP)
 				ret = rte_pmd_i40e_set_vf_mac_addr(portid,
--
2.7.5

  reply	other threads:[~2018-01-23 14:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 14:14 David Coyle
2018-01-23 14:29 ` Hunt, David [this message]
2018-01-23 14:32 ` Hunt, David
2018-02-01  0:18   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F5BA2D9419A984DBB40DB5CFACBB36D1FA8F1C7@IRSMSX101.ger.corp.intel.com \
    --to=david.hunt@intel.com \
    --cc=david.coyle@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).