From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00191d01.pphosted.com (mx0a-00191d01.pphosted.com [67.231.149.140]) by dpdk.org (Postfix) with ESMTP id 5487B1B1B2 for ; Tue, 26 Sep 2017 10:03:03 +0200 (CEST) Received: from pps.filterd (m0048589.ppops.net [127.0.0.1]) by m0048589.ppops.net-00191d01. (8.16.0.21/8.16.0.21) with SMTP id v8Q7soBD022450; Tue, 26 Sep 2017 04:03:02 -0400 Received: from alpi155.enaf.aldc.att.com (sbcsmtp7.sbc.com [144.160.229.24]) by m0048589.ppops.net-00191d01. with ESMTP id 2d7bpcm63q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Sep 2017 04:03:02 -0400 Received: from enaf.aldc.att.com (localhost [127.0.0.1]) by alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id v8Q830FM020190; Tue, 26 Sep 2017 04:03:00 -0400 Received: from mlpi408.sfdc.sbc.com (mlpi408.sfdc.sbc.com [130.9.128.240]) by alpi155.enaf.aldc.att.com (8.14.5/8.14.5) with ESMTP id v8Q82qmC020091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 26 Sep 2017 04:02:55 -0400 Received: from gbcdccas01.intl.att.com (gbcdccas01.intl.att.com [135.76.180.9]) by mlpi408.sfdc.sbc.com (RSA Interceptor); Tue, 26 Sep 2017 08:02:39 GMT Received: from GBCDCMBX03.intl.att.com ([135.76.31.134]) by gbcdccas01.intl.att.com ([135.76.180.9]) with mapi id 14.03.0361.001; Tue, 26 Sep 2017 09:02:37 +0100 From: "Dewar, Alan" To: "'Dumitrescu, Cristian'" , "'alangordondewar@gmail.com'" , "'Kantecki, Tomasz'" CC: "'dev@dpdk.org'" , "'Alan Dewar'" Thread-Topic: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable Thread-Index: AQHTMhIa4//FCgJoZ0m22vq8DAY6XaLFX26AgAF3bPA= Date: Tue, 26 Sep 2017 08:02:37 +0000 Message-ID: <3F9268EEC0E43747A5FFFC6B48EF0321F90BE1@gbcdcmbx03.intl.att.com> References: <1505297744-15240-1-git-send-email-alan.dewar@att.com> <1505913120-5521-1-git-send-email-alan.dewar@att.com> <3EB4FA525960D640B5BDFFD6A3D891267BAC0754@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891267BAC0754@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [135.76.181.254] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-RSA-Inspected: yes X-RSA-Classifications: public X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-09-26_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709260118 X-Mailman-Approved-At: Tue, 26 Sep 2017 17:35:25 +0200 Subject: Re: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 08:03:03 -0000 Hi Cristian, No problem, it doesn't sounds like it will be too difficult.=20 Unfortunately I'm in the middle of another piece of work, so it will probab= ly be a couple of weeks before I get around to it. Regards Alan -----Original Message----- From: Dumitrescu, Cristian [mailto:cristian.dumitrescu@intel.com]=20 Sent: Monday, September 25, 2017 11:37 AM To: alangordondewar@gmail.com; Kantecki, Tomasz Cc: dev@dpdk.org; Alan Dewar Subject: RE: [dpdk-dev] [PATCH v3] sched: make RED scaling configurable ... =20 > diff --git a/config/common_base b/config/common_base index=20 > 5e97a08..2626557 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -666,6 +666,13 @@ CONFIG_RTE_SCHED_COLLECT_STATS=3Dn =20 > CONFIG_RTE_SCHED_SUBPORT_TC_OV=3Dn > CONFIG_RTE_SCHED_PORT_N_GRINDERS=3D8 > CONFIG_RTE_SCHED_VECTOR=3Dn > +# > +# RTE_RED_SCALING - number of fractional bits used for RED's moving > average > +# For every bit that RTE_RED_SCALING is reduced, the max-queue size=20 > +can > doubled > +# RTE_RED_MAX_TH_MAX =3D (max-queue size - 1), max-queue size must be > power of two > +# > +CONFIG_RTE_RED_SCALING=3D10 > +CONFIG_RTE_RED_MAX_TH_MAX=3D1023 >=20 Alan, Tomasz, Thank you for your work! We generally want to avoid build-time configuration in favour of run-time c= onfiguration. Can you please rework this as run-time configuration? I suggest we add a new API function to configure these parameters globally = for all the RED objects (as opposed to per RED object), with the default va= lues as the current values when this function is not called. So NACK for now. Regards, Cristian