From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 63B484C88; Mon, 4 Mar 2019 14:58:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2019 05:58:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,440,1544515200"; d="scan'208";a="138955267" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 04 Mar 2019 05:58:21 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 4 Mar 2019 05:58:21 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.143]) by FMSMSX154.amr.corp.intel.com ([169.254.6.137]) with mapi id 14.03.0415.000; Mon, 4 Mar 2019 05:58:21 -0800 From: "Wiles, Keith" To: David Marchand CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 12/12] net/tap: fix incorrect rxq errors stat Thread-Index: AQHU0nw9W7i2JqSM2kW0RTTmVtuY1aX8BckA Date: Mon, 4 Mar 2019 13:58:20 +0000 Message-ID: <3FAC8250-264B-4750-A848-108F00760D49@intel.com> References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com> <1551698315-2611-13-git-send-email-david.marchand@redhat.com> In-Reply-To: <1551698315-2611-13-git-send-email-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.130.245] Content-Type: text/plain; charset="us-ascii" Content-ID: <9094689BDAA9D042AA3AEE37C31FBB08@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 12/12] net/tap: fix incorrect rxq errors stat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 13:58:24 -0000 > On Mar 4, 2019, at 5:18 AM, David Marchand wr= ote: >=20 > Transmit errors must not be reported in q_errors[] which is for > reception. >=20 > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > Cc: stable@dpdk.org > Cc: Keith Wiles > Signed-off-by: David Marchand > --- > drivers/net/tap/rte_eth_tap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 6f5109f..94c728f 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -968,10 +968,9 @@ struct ipc_queues { >=20 > for (i =3D 0; i < imax; i++) { > tap_stats->q_opackets[i] =3D pmd->txq[i].stats.opackets; > - tap_stats->q_errors[i] =3D pmd->txq[i].stats.errs; > tap_stats->q_obytes[i] =3D pmd->txq[i].stats.obytes; > tx_total +=3D tap_stats->q_opackets[i]; > - tx_err_total +=3D tap_stats->q_errors[i]; > + tx_err_total +=3D pmd->txq[i].stats.errs; > tx_bytes_total +=3D tap_stats->q_obytes[i]; > } >=20 > --=20 > 1.8.3.1 >=20 Acked-by: Keith Wiles Regards, Keith