* [dpdk-dev] [PATCH] net/mlx4: fix default flow rule create
@ 2019-02-24 8:07 Dekel Peled
2019-02-24 9:41 ` [dpdk-dev] [PATCH v2] " Dekel Peled
0 siblings, 1 reply; 4+ messages in thread
From: Dekel Peled @ 2019-02-24 8:07 UTC (permalink / raw)
To: matan, shahafs; +Cc: dev, orika, yskoh, dekelp, stable
Original patch changed logic of function mlx4_flow_merge_eth().
The setting of flow->promisc was wrongly removed.
This patch adds the removed setting of flow->promisc, to restore
the required behavior.
Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
Cc: stable@mellanox.com
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx4/mlx4_flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 3abde30..b7af324 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -250,6 +250,7 @@ struct mlx4_drop {
if (!mask) {
eth->val.dst_mac[0] = 0xff;
flow->ibv_attr->type = IBV_FLOW_ATTR_ALL_DEFAULT;
+ flow->promisc = 1;
return 0;
}
memcpy(eth->val.dst_mac, spec->dst.addr_bytes, ETHER_ADDR_LEN);
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] net/mlx4: fix default flow rule create
2019-02-24 8:07 [dpdk-dev] [PATCH] net/mlx4: fix default flow rule create Dekel Peled
@ 2019-02-24 9:41 ` Dekel Peled
2019-02-27 2:56 ` Yongseok Koh
0 siblings, 1 reply; 4+ messages in thread
From: Dekel Peled @ 2019-02-24 9:41 UTC (permalink / raw)
To: matan, shahafs; +Cc: dev, orika, yskoh, dekelp, stable
Original patch changed logic of function mlx4_flow_merge_eth().
The setting of flow->promisc was wrongly removed.
This patch adds the removed setting of flow->promisc, to restore
the required behavior.
Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
Cc: stable@dpdk.org
---
v2: Correct typo in 'stable' email address.
---
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx4/mlx4_flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 3abde30..b7af324 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -250,6 +250,7 @@ struct mlx4_drop {
if (!mask) {
eth->val.dst_mac[0] = 0xff;
flow->ibv_attr->type = IBV_FLOW_ATTR_ALL_DEFAULT;
+ flow->promisc = 1;
return 0;
}
memcpy(eth->val.dst_mac, spec->dst.addr_bytes, ETHER_ADDR_LEN);
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/mlx4: fix default flow rule create
2019-02-24 9:41 ` [dpdk-dev] [PATCH v2] " Dekel Peled
@ 2019-02-27 2:56 ` Yongseok Koh
2019-03-07 8:35 ` Shahaf Shuler
0 siblings, 1 reply; 4+ messages in thread
From: Yongseok Koh @ 2019-02-27 2:56 UTC (permalink / raw)
To: Dekel Peled; +Cc: Matan Azrad, Shahaf Shuler, dev, Ori Kam, stable
> On Feb 24, 2019, at 1:41 AM, Dekel Peled <dekelp@mellanox.com> wrote:
>
> Original patch changed logic of function mlx4_flow_merge_eth().
> The setting of flow->promisc was wrongly removed.
> This patch adds the removed setting of flow->promisc, to restore
> the required behavior.
>
> Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
> Cc: stable@dpdk.org
>
> ---
> v2: Correct typo in 'stable' email address.
> ---
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
> drivers/net/mlx4/mlx4_flow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
> index 3abde30..b7af324 100644
> --- a/drivers/net/mlx4/mlx4_flow.c
> +++ b/drivers/net/mlx4/mlx4_flow.c
> @@ -250,6 +250,7 @@ struct mlx4_drop {
> if (!mask) {
> eth->val.dst_mac[0] = 0xff;
> flow->ibv_attr->type = IBV_FLOW_ATTR_ALL_DEFAULT;
> + flow->promisc = 1;
> return 0;
> }
> memcpy(eth->val.dst_mac, spec->dst.addr_bytes, ETHER_ADDR_LEN);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/mlx4: fix default flow rule create
2019-02-27 2:56 ` Yongseok Koh
@ 2019-03-07 8:35 ` Shahaf Shuler
0 siblings, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2019-03-07 8:35 UTC (permalink / raw)
To: Yongseok Koh, Dekel Peled; +Cc: Matan Azrad, dev, Ori Kam, stable
Wednesday, February 27, 2019 4:57 AM, Yongseok Koh:
> Subject: Re: [PATCH v2] net/mlx4: fix default flow rule create
>
>
> > On Feb 24, 2019, at 1:41 AM, Dekel Peled <dekelp@mellanox.com> wrote:
> >
> > Original patch changed logic of function mlx4_flow_merge_eth().
> > The setting of flow->promisc was wrongly removed.
> > This patch adds the removed setting of flow->promisc, to restore the
> > required behavior.
> >
> > Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with
> > VLAN")
> > Cc: stable@dpdk.org
> >
> > ---
> > v2: Correct typo in 'stable' email address.
> > ---
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > ---
>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-07 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-24 8:07 [dpdk-dev] [PATCH] net/mlx4: fix default flow rule create Dekel Peled
2019-02-24 9:41 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2019-02-27 2:56 ` Yongseok Koh
2019-03-07 8:35 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).