From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFE56A00C2; Fri, 14 Oct 2022 10:42:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92B83410F2; Fri, 14 Oct 2022 10:42:33 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2081.outbound.protection.outlook.com [40.107.237.81]) by mails.dpdk.org (Postfix) with ESMTP id 9A5C2410F1 for ; Fri, 14 Oct 2022 10:42:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=inFgL1Cz7SI3tJilXB/UD1IVxFFEQzv6TQDv4wvNVM4j8x3gD7cyMZtVd8dXEO2rlKQZHecQ1aIT/qnvpYOFgziFlSwvavUsbvQvoJEihVKmO5fJYJ8m+ZoxoZhZ+neFCs7IAU0It/06pi7zu3cqKIuzaOzLgUjUU1wmp1ZdewmvN+R12ZoxPMZt4I8BbXgdeq3GcDzMy2YreYI6Vr9O5hwe+QfwARY9jVgUgVX9jTa6uBEkLAcr7/yGNWCLOCOuakpAFk4Y0TPC4drLDhIj51GKMN1niHc+Zgc2USdrZckrXC7dJIFOyYdM+hiUCkagXydrmx60f/rrL8zZSGiM3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lSgNdzqglIKjM2e1MexPjZVioIZJ5YnrOC5WIHOizQ=; b=n1MV5F4Nzmod3EPKZ4YLNVxMoIql1VbY7JNMcF5SgUgnmJ87umLbBL2v5fmpieotQjwsharP+nl2++stF6rhQ2Tn+9ZgwX9shwzQH1C/fpN2jNx3E4jxVp6vDChTThqRCSQAvMf014c1+jN08tv2XWihT824ZE1+gsqzwUkwD2WxPKZP5gKIaDaJlI6q3zHTzETjJ/IuAV4zbmggFpzB/s0ZebmfQzPT5aHSqPYI5ycrxVEBxwyrEwZDdHuZjmmYPOAUJGSg+XBbcSj5k84kiz4yBAdqF94b7J9AP/1iAHWW6Oclv0Sr5Y7KZ7Rv1+vHEPgNKp09MfyUc10FDAyWug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7lSgNdzqglIKjM2e1MexPjZVioIZJ5YnrOC5WIHOizQ=; b=a9Vj3YWaAGRgVC566XGmirUfTyDovRHDD9IGmpFVAWqkb3086mFHz5xanm0cWBKB3hXjy4YVZSoMZuvnTLN/yoposdvMXyrwMztzLiFNSeLMcq8CN70tgaO5SkRjDa6hnjazrP+8+6Fp5sQ7fieRh8g2z7NWYgy++5xzhsNiLvQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by BL1PR12MB5288.namprd12.prod.outlook.com (2603:10b6:208:314::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 08:42:30 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%9]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 08:42:29 +0000 Message-ID: <3a189b98-116b-f13c-a055-23e80dad79e1@amd.com> Date: Fri, 14 Oct 2022 09:42:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH] net/nfp: add the feature of RSS based on VXLAN inner layer Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers , Niklas Soderlund References: <1665383329-23583-1-git-send-email-chaoyong.he@corigine.com> <4f13ce91-32ed-02d5-867e-7f4e974518ef@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0277.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::12) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|BL1PR12MB5288:EE_ X-MS-Office365-Filtering-Correlation-Id: 0edd3b48-c211-4c1e-4108-08daadc00781 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z03Jruyz6RiMyNy8xBcUI9afXfKVLaOvDiTIO+zb2C2K+2TpNcJW2TTnz27ZHKb1djx8biGbwlwDnDJEx7fCuhdhXgCyibXvYMYgk84WzhjhIvhfyRck7eRNFVMk2Nme9Fg6L3dokRGSDTb931AP8gjY3NoEV+C5h7gRfltq/9CUTGU6akoQVQuXF8HXMyDeAURzd4FX4Lwh2g6BX+lxEPOCzr2mm59T9VixhA/epO3XRB3ps2XTtRXRoycrxkSyiqkIvN1P139ztMGJ7hSSO9Eo7wqhaC7qrpkaw9MRcfjoZMLxrV4xLSUuIy+H0ROPqaAWSiU26qYsJ/SMuPUxe+vcPn7LGEYuvQrl73rmWx7zUwTAIVeIt3AlPh/FlGEwm9dF9AKMSzGAf0RcJJudF2XfDfkXOz6mZSwVEYZ4ujiCATgcl16OaZzww2SNGgELbF64+vRqeeY+2JjKx1dacBWVilUq2wcD++f4q+0OeIpP8BGThQUy05SB1UZ1397T2FpXJ40vNSIimryO20FbwQnETwzXh7zE4y3FOSEnmkLVvU5veLQDA9SsD2BLzROEVNaScV4ij4jWmqftcXHFoeIhe40Y1YPwzAWm6R7xmkvJiCrt6stlwWAEiDvn2pmJdtZUFyMiqtAWJy0/tlSMdjKIN9UFWmNRZrusoUl3BM2ec8M/xh3Sjl7Pb2J+SpJWv0TbV7KaZtq81REFsEYNLfMMQo97B+U2Kl66ALuqkaM9XdwXjydhWTpalXQBrGLRtooXKE7/vl063rM39sQyu/Qwfxasq2fSfVlZmlj0sP0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(451199015)(316002)(478600001)(110136005)(54906003)(6666004)(31686004)(66946007)(66476007)(6486002)(4326008)(8676002)(66556008)(6512007)(8936002)(26005)(41300700001)(186003)(44832011)(5660300002)(6506007)(2616005)(2906002)(83380400001)(36756003)(31696002)(38100700002)(53546011)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1dFMXhEZ1BCS2t4Z09GZ2JXdlJVZm9WVkRwbFJ1WmhpUEo1TlVUdlZyMWdQ?= =?utf-8?B?cGIzMlVrQzNTMGFmSnl2RFhxOUdEb3MvbkJNWERpTUdsT2NyaFpDcHdia21X?= =?utf-8?B?T3FWYk1qd0dyMk1UTU9velhnOXhxOG42SGJsVTZ1TnlMREhpbG9iOGpzVnN6?= =?utf-8?B?N1orYTdaQmlWSHFIUlpQcWhDK3pCT3BBNTJWWElTZFg0amY4RnRBZWprWUNx?= =?utf-8?B?VkRtLzJrcHh2NmxaQmtwSFpzR2NWVFh0SGhvQ1BZblpub2Q3RytlRGVoazNY?= =?utf-8?B?dUpSdTBDUFcrd0lFMzBOSmorMkpacDRHdFdDTHpZTzQxTm1jR3pXcjZLejhO?= =?utf-8?B?YkVjbFlUelV0UGk1TFRWL2x6bTlVdXdPY2d5WStMajlSd3UyMktxbmhyQnRF?= =?utf-8?B?YnFvZlg0bEZkMTRVZVdRZHlQU2F2eGI3YlVTUzNhTFpnbFcrRyttQi9PNmt4?= =?utf-8?B?NkMwS3l6MXc3OEE5R005THI5WjRWOXNBQ3lvUUMxZ2RaRTZreGdVc2RKazJQ?= =?utf-8?B?c3M3SlU4S1NoUEVWOERqSDJ2TUFRUXVwVzNteEpDbFlickFJVDVkWjVvK0Q5?= =?utf-8?B?MzQ3V0pRTWZWem4wWmpCeUpZR0YrTnE3RlFBYUsrSnBQR295VXZZNm9LZTZB?= =?utf-8?B?S0RZL0FvOE9ReTFCZXB5MnVDUWdYbUZERUM5bmJ2RVJ5QmMvUnQ2eEtTQmpt?= =?utf-8?B?MVVwOVVjb1dUTXR6OXAwR2w1b25vZmFCeXJXSEdIVVZJVGFPb0JFMEJoNyt2?= =?utf-8?B?ZWVqelVkdkZ6NktFeGlNcGZ4OGpsM01pazZtKzRkd2tyYjdZYWNiaVQzcGdC?= =?utf-8?B?V3MvQ1JIQmRUL1lEMkpOQWRrR2pnTFlFbWVuWEZJRGltMHRVZVY4amlyNWZk?= =?utf-8?B?c2ZHNHdQWHE1R0dqdE40alJwL3ZxN1MxQytxdm53S2ZNVEE1ZUNod3BEZWpV?= =?utf-8?B?dWhBS0oxNTBnY29rSVFpR1llL2c4ZkQ0VkRsYy8rVUdGSEZEK1ZSaXRyTldQ?= =?utf-8?B?dUJwK3UwNW0za1dRWlJmaWl4aFRBSjlsWFQxaUtZWE1LdW5OeWtxRnV2eW5L?= =?utf-8?B?YytjRWNBWmprNmk0UFhQdGVQSVNzVHY5QkJONndwTW4rUDlWQ28vanVEVURn?= =?utf-8?B?VFl1M2NIbWZQQjYzTmh4bjBFT2NTYUM0a3NWOUc5VjRtYWdPS1JJcStQcEdY?= =?utf-8?B?TjFnbmZqcEV3MjRtcUF3MEVZdExtY0FxN2FTdnk0RjRrSHdqMEk5WGk3Ymhu?= =?utf-8?B?R3RsZ1NIY2F3M2psazZtdjhmMk1ZOEJ4UTIwMWpQeTk2QmQ1cWNYWllDZ2lT?= =?utf-8?B?VWRIZDVQb01ydkpCbnNoRXJKMGc0bERpT1VQSUJLWEMxS09DYXMwWXdxaytm?= =?utf-8?B?M1djYVBFaE5aUi9Sd3dCSWZveEU2R1lkeUpTZ3h4OThwVnpHcTYvNjlmQnoz?= =?utf-8?B?T2g3QXJXTjh3bHJmeGhYS0JUVWZrMWhCYm1BWVBMamdLenNhY0VvQXRQQW9K?= =?utf-8?B?VS91a0FQQ0RTQWYyZU1nRng5SG5GZnBxS0VMaUc5Y0tGVkw5SXZnNXBHR2w3?= =?utf-8?B?YUc1Wk1nU3Q1MVpiZGRDazBYYjdQSGZWdk50dTlTbFp6SGVEeFVzVEVSM1dl?= =?utf-8?B?djZPdTNhZS95eGpobXpIREd2NGQ3blpOTkpieCtZL3NJWXpXLzM3MzFtNnRy?= =?utf-8?B?TnBiUUVvYk4vSVNBSm0wTkhRaEpLcnYrU3JFSHNzM1B2eDV5SFk0c0x4a0dK?= =?utf-8?B?ZEN1MnBxYmY4czZOOG1xUWdyMkdyeTdVRDl3c0FaS0dSTElHNEZwa1JSWUpq?= =?utf-8?B?aE9ubWtYdzVWTlRrdHI1dG5CYTZMaEoxVU1RWnZkZzNITG5kR2RqbVpTeVNx?= =?utf-8?B?S2tIb1hSemlwdkk5V1FvVWVYcXZDSWpPUWUybnBwcXpFekt0OUNJazBkQ0ZG?= =?utf-8?B?MXB2ZzBQQU12NWxVR29uUzN3cW52c3VnTnlwWkFQMVdmK1QyeXM2d1FZbTlH?= =?utf-8?B?YzJEMGhPZDZzYTdORXZLeE5VcCthaWJHQzFFdFNsTVRldGE3TTJqdEtkT1dL?= =?utf-8?B?UEVLb1lYWFJCT1dwUEZZelFPc1ZBV0pSWm5MaU5ITXRKVkpEamNCb1JDY05o?= =?utf-8?Q?zwTFiLdgNLLUHEmWoJr7nT2v8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0edd3b48-c211-4c1e-4108-08daadc00781 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:42:29.9614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IGZzs1jje1CFcUF/mj8N0S0IQ004k/o+IFpIYKJb17+uSyEOURV63zmBl6XOMwdb X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5288 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/14/2022 2:15 AM, Chaoyong He wrote: >> On 10/10/2022 7:28 AM, Chaoyong He wrote: >>> Add the logics to support the feature of RSS packets based on the >>> inner layer of VXLAN tunnel. >>> >>> Signed-off-by: Chaoyong He >>> Reviewed-by: Niklas Söderlund >>> >>> Depends-on: series-24819 ("preparation for the rte_flow offload of nfp >>> PMD") >>> >>> --- >>> drivers/net/nfp/flower/nfp_flower.c | 2 +- >>> drivers/net/nfp/flower/nfp_flower_cmsg.c | 1 + >>> drivers/net/nfp/flower/nfp_flower_ctrl.c | 2 +- >>> drivers/net/nfp/flower/nfp_flower_representor.c | 2 +- >>> drivers/net/nfp/nfp_common.c | 33 +++++++ >>> drivers/net/nfp/nfp_common.h | 4 + >>> drivers/net/nfp/nfp_cpp_bridge.h | 2 - >>> drivers/net/nfp/nfp_ethdev.c | 111 >> ++++++++++++++++++++++++ >>> drivers/net/nfp/nfp_ethdev_vf.c | 1 + >>> drivers/net/nfp/nfp_rxtx.c | 1 + >>> 10 files changed, 154 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/net/nfp/flower/nfp_flower.c >>> b/drivers/net/nfp/flower/nfp_flower.c >>> index 3e97f5c..da96d2f 100644 >>> --- a/drivers/net/nfp/flower/nfp_flower.c >>> +++ b/drivers/net/nfp/flower/nfp_flower.c >>> @@ -10,9 +10,9 @@ >>> #include >>> #include >>> >>> +#include "../nfp_ctrl.h" >>> #include "../nfp_common.h" >>> #include "../nfp_logs.h" >>> -#include "../nfp_ctrl.h" >>> #include "../nfp_cpp_bridge.h" >>> #include "../nfp_rxtx.h" >>> #include "../nfpcore/nfp_mip.h" >>> diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c >>> b/drivers/net/nfp/flower/nfp_flower_cmsg.c >>> index 750a629..b719eb2 100644 >>> --- a/drivers/net/nfp/flower/nfp_flower_cmsg.c >>> +++ b/drivers/net/nfp/flower/nfp_flower_cmsg.c >>> @@ -5,6 +5,7 @@ >>> >>> #include "../nfpcore/nfp_nsp.h" >>> #include "../nfp_logs.h" >>> +#include "../nfp_ctrl.h" >>> #include "../nfp_common.h" >>> #include "nfp_flower.h" >>> #include "nfp_flower_cmsg.h" >>> diff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c >>> b/drivers/net/nfp/flower/nfp_flower_ctrl.c >>> index df908ef..961ca34 100644 >>> --- a/drivers/net/nfp/flower/nfp_flower_ctrl.c >>> +++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c >>> @@ -6,9 +6,9 @@ >>> #include >>> #include >>> >>> +#include "../nfp_ctrl.h" >>> #include "../nfp_common.h" >>> #include "../nfp_logs.h" >>> -#include "../nfp_ctrl.h" >>> #include "../nfp_rxtx.h" >>> #include "nfp_flower.h" >>> #include "nfp_flower_ctrl.h" >>> diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c >>> b/drivers/net/nfp/flower/nfp_flower_representor.c >>> index 0e60f50..8db73e0 100644 >>> --- a/drivers/net/nfp/flower/nfp_flower_representor.c >>> +++ b/drivers/net/nfp/flower/nfp_flower_representor.c >>> @@ -6,9 +6,9 @@ >>> #include >>> #include >>> >>> +#include "../nfp_ctrl.h" >>> #include "../nfp_common.h" >>> #include "../nfp_logs.h" >>> -#include "../nfp_ctrl.h" >>> #include "../nfp_rxtx.h" >>> #include "../nfpcore/nfp_mip.h" >>> #include "../nfpcore/nfp_rtsym.h" >>> diff --git a/drivers/net/nfp/nfp_common.c >>> b/drivers/net/nfp/nfp_common.c index 07781a1..ec6a669 100644 >>> --- a/drivers/net/nfp/nfp_common.c >>> +++ b/drivers/net/nfp/nfp_common.c >>> @@ -37,6 +37,7 @@ >>> #include "nfpcore/nfp_rtsym.h" >>> #include "nfpcore/nfp_nsp.h" >>> >>> +#include "nfp_ctrl.h" >>> #include "nfp_common.h" >>> #include "nfp_ctrl.h" >>> #include "nfp_rxtx.h" >> >> Are above header inclusion changes related to this patch? > > Yes, it does relate. > In this patch, we use a macro in `nfp_common.h`, and this macro is defined in `nfp_ctrl.h`, > so import the dependency relations of this two header files. > If we don't modify the related files which use these two header files, the compile process will fail. > OK, it is for 'NFP_NET_N_VXLAN_PORTS' which is defined in `nfp_ctrl.h`, and used in `nfp_common.h` in this patch. And you are including `nfp_ctrl.h` in all c files that uses `nfp_common.h`, instead why don't you include `nfp_ctrl.h` in `nfp_common.h`? Because you are creating this dependency anyway, whoever includes `nfp_common.h` will need `nfp_ctrl.h`. Or other option can be moving 'NFP_NET_N_VXLAN_PORTS' define (and its dependencies) to `nfp_common.h`, if it is logically makes sense.