From: Jeff Guo <jia.guo@intel.com>
To: Ori Kam <orika@mellanox.com>,
"xiaolong.ye@intel.com" <xiaolong.ye@intel.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"yahui.cao@intel.com" <yahui.cao@intel.com>,
"simei.su@intel.com" <simei.su@intel.com>
Subject: Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type
Date: Tue, 7 Apr 2020 13:37:08 +0800 [thread overview]
Message-ID: <3a28be2d-36eb-3ed0-3bc7-f49dd4a0261d@intel.com> (raw)
In-Reply-To: <AM6PR05MB517698AD8EA3CF7B7FEE8F8DDBC50@AM6PR05MB5176.eurprd05.prod.outlook.com>
hi, Ori
On 4/5/2020 11:56 PM, Ori Kam wrote:
> Hi Jeff,
>
>> -----Original Message-----
>> From: Jeff Guo <jia.guo@intel.com>
>> Sent: Tuesday, March 31, 2020 11:50 AM
>> To: Ori Kam <orika@mellanox.com>; xiaolong.ye@intel.com;
>> qi.z.zhang@intel.com
>> Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com;
>> simei.su@intel.com
>> Subject: Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type
>>
>> yes, Ori, please check the comment below.
>>
>>
>> On 3/30/2020 6:18 PM, Ori Kam wrote:
>>> Hi Jeff,
>>>
>>> My name is Ori 😊
>>>
>>> I'm not an expert in GTP so this is just my thinking and maybe I'm
>>> missing something, this is why a good explanation helps 😊
>>>
>>>> -----Original Message-----
>>>> From: Jeff Guo <jia.guo@intel.com>
>>>> Sent: Monday, March 30, 2020 11:30 AM
>>>> To: Ori Kam <orika@mellanox.com>; xiaolong.ye@intel.com;
>>>> qi.z.zhang@intel.com
>>>> Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com;
>>>> simei.su@intel.com
>>>> Subject: Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU
>> type
>>>> hi, orika
>>>>
>>>>
>>>> On 3/29/2020 4:44 PM, Ori Kam wrote:
>>>>> Hi Jeff,
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Jeff Guo
>>>>>> Sent: Thursday, March 26, 2020 6:41 PM
>>>>>> To: xiaolong.ye@intel.com; qi.z.zhang@intel.com
>>>>>> Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com;
>>>>>> simei.su@intel.com; jia.guo@intel.com
>>>>>> Subject: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type
>>>>>>
>>>>>> Add gtp pdu type configure in the cmdline.
>>>>> Why not use ITEM_GTP_PSC_PDU?
>>>> I guess you mean ITEM_GTP_PSC_PDU_T, rihgt? We know we have got
>>>> ITEM_GTP_PSC_QFI/ITEM_GTP_PSC_PDU_T but not define the
>>>>
>>>> spec for them, so what i use is add the spec into the ITEM_GTP_PSC_PDU_T
>>>> to let the pdu type to be configured.
>>>>
>>> Yes you are correct, from rte_flow we have the
>> RTE_FLOW_ITEM_TYPE_GTP_PSC
>>> Item that include pdu_type. This is the field you need right?
>>>
>>> In testpmd we have the ITEM_GTP_PSC_PDU_T which should support adding
>>> the pdu type.
>>> Basically you just need to type the following cmd line:
>>> flow create 0 ingress pattern gtp_psc pdu_t is xxx
>>> if this command is not working we need to understand why.
>>>
>>>
>> please check the part before this patch as below:
>>
>> [ITEM_GTP_PSC_PDU_T] = {
>> .name = "pdu_t",
>> .help = "PDU type",
>> .next = NEXT(item_gtp_psc, NEXT_ENTRY(UNSIGNED),
>> item_param),
>>
>> sure, we got the ITEM_GTP_PSC_PDU_T at prior but the NEXT_ENTRY is
>> UNSIGNED, that means we still not implement
>>
> Sorry I don't understand your comment, what do you mean it is not implemented?
> Yes it means that the parameter is should be unsigned value.
I mean that if it is a unsigned value, user could not set the pdu_t to
be a 0 or 1, or any other we
define for that.
>> the spec to let the pdu type to be configurable, so what the patch do is
>> to fix this issue.
> What do you mean configurable?
>
> Lets start at the beginning, maybe I'm just missing some key point.
> What is the PDU type? What values can he hold?
> How do you want the command to look like?
the command should be like as below
flow create 0 ingress pattern eth / ipv4 / udp / gtpu / gtp_psc pdu_t is
0/ ipv4 / end actions rss types ipv4-udp l3-dst-only endkey_len 0queues
end / end
It is eventually the same as you described about the command before.
User could set pdu_t to be 0 or 1, so what is need is modify
NEXT_ENTRY(UNSIGNED) to be "SIGNED" and defined.
>>
>>>>>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>>>>>> ---
>>>>>> v1:
>>>>>> no change
>>>>>> ---
>>>>>> app/test-pmd/cmdline_flow.c | 11 ++++++++++-
>>>>>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>>>>>> index a78154502..c1bd02919 100644
>>>>>> --- a/app/test-pmd/cmdline_flow.c
>>>>>> +++ b/app/test-pmd/cmdline_flow.c
>>>>>> @@ -49,6 +49,7 @@ enum index {
>>>>>> PORT_ID,
>>>>>> GROUP_ID,
>>>>>> PRIORITY_LEVEL,
>>>>>> + GTP_PSC_PDU_T,
>>>>>>
>>>>>> /* Top-level command. */
>>>>>> SET,
>>>>>> @@ -1626,6 +1627,13 @@ static const struct token token_list[] = {
>>>>>> .call = parse_int,
>>>>>> .comp = comp_none,
>>>>>> },
>>>>>> + [GTP_PSC_PDU_T] = {
>>>>>> + .name = "{GTPU pdu type}",
>>>>>> + .type = "INTEGER",
>>>>>> + .help = "gtpu pdu uplink/downlink identifier",
>>>>>> + .call = parse_int,
>>>>>> + .comp = comp_none,
>>>>>> + },
>>>>> Why is this created at this level?
>>>>> This looks like is should be written totally differently.
>>>> As i said above, the item we got but spec or say next token still need
>>>> to be added, do you mean it should not in the group of Common tokens? If
>>>> so, let me think about that, and please explicit your proposal if you
>>>> already have one.
>>>>
>>> Please see above response.
>>>
>>>>>> /* Top-level command. */
>>>>>> [FLOW] = {
>>>>>> .name = "flow",
>>>>>> @@ -2615,7 +2623,8 @@ static const struct token token_list[] = {
>>>>>> [ITEM_GTP_PSC_PDU_T] = {
>>>>>> .name = "pdu_t",
>>>>>> .help = "PDU type",
>>>>>> - .next = NEXT(item_gtp_psc, NEXT_ENTRY(UNSIGNED),
>>>>>> item_param),
>>>>>> + .next = NEXT(item_gtp_psc, NEXT_ENTRY(GTP_PSC_PDU_T),
>>>>>> + item_param),
>>>>>> .args = ARGS(ARGS_ENTRY_HTON(struct
>>>>>> rte_flow_item_gtp_psc,
>>>>>> pdu_type)),
>>>>>> },
>>>>>> --
>>>>>> 2.20.1
next prev parent reply other threads:[~2020-04-07 5:37 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 17:03 [dpdk-dev] [dpdk-dev 0/4] add RSS configuration for iavf Jeff Guo
2020-03-18 17:03 ` [dpdk-dev] [dpdk-dev 1/4] ethdev: add new RSS offload types Jeff Guo
2020-03-18 17:03 ` [dpdk-dev] [dpdk-dev 2/4] net/iavf: add RSS configuration for VFs Jeff Guo
2020-03-18 17:04 ` [dpdk-dev] [dpdk-dev 3/4] app/testpmd: support GTP PDU type Jeff Guo
2020-03-18 17:04 ` [dpdk-dev] [dpdk-dev 4/4] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 0/4] add RSS configuration for iavf Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types Jeff Guo
2020-04-07 17:02 ` Iremonger, Bernard
2020-04-08 0:15 ` Zhang, Qi Z
2020-04-09 2:04 ` Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 2/4] net/iavf: add RSS configuration for VFs Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type Jeff Guo
2020-03-29 8:44 ` Ori Kam
2020-03-30 8:29 ` Jeff Guo
2020-03-30 10:18 ` Ori Kam
2020-03-31 8:50 ` Jeff Guo
2020-04-05 15:56 ` Ori Kam
2020-04-07 5:37 ` Jeff Guo [this message]
2020-04-12 9:58 ` Ori Kam
2020-04-14 3:05 ` Jeff Guo
2020-04-14 5:57 ` Ori Kam
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 4/4] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 0/4] add RSS configuration for iavf Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 1/4] ethdev: add new RSS offload types Jeff Guo
2020-04-13 0:13 ` Zhang, Qi Z
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 2/4] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-13 2:02 ` Zhang, Qi Z
2020-04-14 3:42 ` Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 3/4] app/testpmd: support GTP PDU type Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 4/4] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 0/3] add RSS configuration for iavf Jeff Guo
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-14 9:42 ` Ori Kam
2020-04-15 2:31 ` Zhang, Qi Z
2020-04-15 3:11 ` Jeff Guo
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-15 2:29 ` Zhang, Qi Z
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-14 9:48 ` Ori Kam
2020-04-15 8:08 ` Jeff Guo
2020-04-15 16:31 ` Stephen Hemminger
2020-04-16 8:55 ` Jeff Guo
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 0/3] add RSS configuration for iavf Jeff Guo
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-15 15:38 ` Iremonger, Bernard
2020-04-15 22:13 ` Ferruh Yigit
2020-04-16 3:22 ` Jeff Guo
2020-04-16 6:57 ` Ori Kam
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-15 15:01 ` Iremonger, Bernard
2020-04-16 7:51 ` Jeff Guo
2020-04-16 9:14 ` Iremonger, Bernard
2020-04-16 10:22 ` Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 0/3] add RSS configuration for iavf Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-16 10:40 ` Ori Kam
2020-04-16 15:16 ` Jeff Guo
2020-04-16 11:16 ` Iremonger, Bernard
2020-04-16 15:15 ` Jeff Guo
2020-04-16 15:52 ` Ferruh Yigit
2020-04-17 1:50 ` Jeff Guo
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 0/3] add RSS configuration for iavf Jeff Guo
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-21 10:14 ` Iremonger, Bernard
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-19 6:53 ` Ori Kam
2020-04-21 9:44 ` Iremonger, Bernard
2020-04-21 12:37 ` Jeff Guo
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 0/3] add RSS configuration for iavf Jeff Guo
2020-04-21 17:15 ` Ferruh Yigit
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-21 17:15 ` Ferruh Yigit
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-21 14:29 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a28be2d-36eb-3ed0-3bc7-f49dd4a0261d@intel.com \
--to=jia.guo@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=yahui.cao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).