From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E09E11C00 for ; Mon, 4 Dec 2017 20:57:57 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2017 11:57:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,361,1508828400"; d="scan'208";a="8988579" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.178]) ([10.241.225.178]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2017 11:57:56 -0800 To: Jingjing Wu , dev@dpdk.org Cc: wenzhuo.lu@intel.com References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com> <1511505206-97333-1-git-send-email-jingjing.wu@intel.com> <1511505206-97333-5-git-send-email-jingjing.wu@intel.com> From: Ferruh Yigit Message-ID: <3a34b3ab-558e-c581-67b9-71712aa694f5@intel.com> Date: Mon, 4 Dec 2017 11:57:56 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1511505206-97333-5-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 04/14] net/avf: enable basic Rx Tx func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 19:57:58 -0000 On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Wenzhuo Lu <...> > @@ -31,8 +31,8 @@ > * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > -#ifndef _AVF_LOGS_H_ > -#define _AVF_LOGS_H_ > +#ifndef _AVF_LOG_H_ > +#define _AVF_LOG_H_ Can you please squash this one with patch 1/14 ? <...> > @@ -185,17 +227,13 @@ void avf_dump_tx_descriptor(const struct avf_tx_queue *txq, > tx_desc->cmd_type_offset_bsz); > } > > -#ifdef RTE_LIBRTE_AVF_RX_DUMP > +#ifdef DEBUG_DUMP_DESC > #define AVF_DUMP_RX_DESC(rxq, desc, rx_id) \ > avf_dump_rx_descriptor(rxq, desc, rx_id); > -#else > -#define AVF_DUMP_RX_DESC(rxq, desc, rx_id) do { } while (0) > -#endif > - > -#ifdef RTE_LIBRTE_AVF_TX_DUMP > #define AVF_DUMP_TX_DESC(txq, desc, tx_id) \ > avf_dump_tx_descriptor(txq, desc, tx_id); > #else > +#define AVF_DUMP_RX_DESC(rxq, desc, rx_id) do { } while (0) > #define AVF_DUMP_TX_DESC(txq, desc, tx_id) do { } while (0) > #endif Although we are trying to add as less as compile time config, this has been defined in Makefile with compiled out also seems not good option, what do you think converting this into another config option? <...>