From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 27B991B2FE for ; Thu, 12 Oct 2017 20:04:21 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2017 11:03:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,367,1503385200"; d="scan'208";a="909365414" Received: from unknown (HELO [10.241.225.21]) ([10.241.225.21]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2017 11:03:31 -0700 To: Zhiyong Yang , dev@dpdk.org References: <20171012093252.53100-1-zhiyong.yang@intel.com> From: Ferruh Yigit Message-ID: <3a39bb25-ded4-4d7c-1408-6fc20820ce70@intel.com> Date: Thu, 12 Oct 2017 19:03:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171012093252.53100-1-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/6] fix port id type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 18:04:22 -0000 On 10/12/2017 10:32 AM, Zhiyong Yang wrote: > Now ethdev port_id has been increased to uint16_t from uint8_t in the below patch > http://www.dpdk.org/dev/patchwork/patch/29418/ > > but > 1. Some features which are applied were still developed based on older version > uint8_t port_id. > 2. Some places using port id such as testpmd are omitted in previous patch. > The patchset fixes some port id type issues. > > Zhiyong Yang (6): > lib/librte_ether: fix port id type > net/bnxt: fix port id type > net/liquidio: fix port id type > app/pdump: fix port id type > app/proc_info: fix port id type > app/testpmd: fix port id type Series applied to dpdk-next-net/master, thanks. Thanks for the patches! But I can see there are still more uint8_t usage [1], some looks valid. I aware this looks like never it will never end but would you mind doing one more go? It would be nice to get all fixed before rc1. And I hope we won't need to change port_id storage type again... [1] $ git grep -c "uint8_t port_id" app/test-eventdev/test_order_common.h:2 app/test-eventdev/test_perf_common.h:2 doc/guides/prog_guide/eventdev.rst:1 doc/guides/prog_guide/poll_mode_drv.rst:1 doc/guides/prog_guide/rte_flow.rst:6 doc/guides/sample_app_ug/kernel_nic_interface.rst:4 doc/guides/sample_app_ug/link_status_intr.rst:1 drivers/event/dpaa2/dpaa2_eventdev.c:2 drivers/event/octeontx/ssovf_evdev.c:2 drivers/event/skeleton/skeleton_eventdev.c:2 drivers/event/skeleton/skeleton_eventdev.h:1 drivers/event/sw/sw_evdev.c:2 drivers/event/sw/sw_evdev_xstats.c:1 drivers/net/bonding/rte_eth_bond_pmd.c:1 drivers/net/i40e/i40e_ethdev.c:1 examples/ethtool/lib/rte_ethtool.c:21 examples/ethtool/lib/rte_ethtool.h:21 examples/eventdev_pipeline_sw_pmd/main.c:6 examples/ipsec-secgw/ipsec-secgw.c:2 examples/l2fwd-jobstats/main.c:1 examples/quota_watermark/qw/init.c:2 examples/quota_watermark/qw/init.h:2 examples/quota_watermark/qw/main.c:1 examples/server_node_efd/node/node.c:2 examples/tep_termination/vxlan_setup.c:1 examples/tep_termination/vxlan_setup.h:2 lib/librte_eventdev/rte_event_eth_rx_adapter.c:1 lib/librte_eventdev/rte_eventdev.c:7 lib/librte_eventdev/rte_eventdev.h:11 lib/librte_eventdev/rte_eventdev_pmd.h:2 test/test/test_link_bonding.c:1 test/test/test_link_bonding_mode4.c:2 test/test/test_link_bonding_rssconf.c:3