Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 04/06/2018 02:43 PM, Fan Zhang wrote:
> Fixes: 7834b5c82bf3 ("lib/librte_vhost: update makefile")
> 
> This patch fixes some meson build bugs.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/meson.build | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build
> index f01ef67fc..dee154e40 100644
> --- a/lib/librte_vhost/meson.build
> +++ b/lib/librte_vhost/meson.build
> @@ -10,6 +10,6 @@ endif
>   version = 4
>   allow_experimental_apis = true
>   sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
> -		'virtio_net.c', 'virtio_crypto.c')
> +		'virtio_net.c', 'vhost_crypto.c')
>   headers = files('rte_vhost.h', 'rte_vhost_crypto.h')
> -deps += ['ethdev', 'cryptodev', 'pci']
> +deps += ['ethdev', 'cryptodev', 'pci', 'hash']
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I will squash the change in patch 7834b5c82bf3 if not applied yet.

As discussed on IRC, we should ideally have such dependencies only if
vhost-crypto build is enabled.

Thanks!
Maxime