DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build
@ 2018-04-06 12:43 Fan Zhang
  2018-04-06 13:07 ` Maxime Coquelin
  2018-04-09 15:51 ` Maxime Coquelin
  0 siblings, 2 replies; 3+ messages in thread
From: Fan Zhang @ 2018-04-06 12:43 UTC (permalink / raw)
  To: dev
  Cc: jianjay.zhou, roy.fan.zhang, maxime.coquelin, jianfeng.tan,
	pawelx.wodkowski

Fixes: 7834b5c82bf3 ("lib/librte_vhost: update makefile")

This patch fixes some meson build bugs.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 lib/librte_vhost/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build
index f01ef67fc..dee154e40 100644
--- a/lib/librte_vhost/meson.build
+++ b/lib/librte_vhost/meson.build
@@ -10,6 +10,6 @@ endif
 version = 4
 allow_experimental_apis = true
 sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
-		'virtio_net.c', 'virtio_crypto.c')
+		'virtio_net.c', 'vhost_crypto.c')
 headers = files('rte_vhost.h', 'rte_vhost_crypto.h')
-deps += ['ethdev', 'cryptodev', 'pci']
+deps += ['ethdev', 'cryptodev', 'pci', 'hash']
-- 
2.13.6

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build
  2018-04-06 12:43 [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build Fan Zhang
@ 2018-04-06 13:07 ` Maxime Coquelin
  2018-04-09 15:51 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2018-04-06 13:07 UTC (permalink / raw)
  To: Fan Zhang, dev; +Cc: jianjay.zhou, jianfeng.tan, pawelx.wodkowski



On 04/06/2018 02:43 PM, Fan Zhang wrote:
> Fixes: 7834b5c82bf3 ("lib/librte_vhost: update makefile")
> 
> This patch fixes some meson build bugs.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/meson.build | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build
> index f01ef67fc..dee154e40 100644
> --- a/lib/librte_vhost/meson.build
> +++ b/lib/librte_vhost/meson.build
> @@ -10,6 +10,6 @@ endif
>   version = 4
>   allow_experimental_apis = true
>   sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
> -		'virtio_net.c', 'virtio_crypto.c')
> +		'virtio_net.c', 'vhost_crypto.c')
>   headers = files('rte_vhost.h', 'rte_vhost_crypto.h')
> -deps += ['ethdev', 'cryptodev', 'pci']
> +deps += ['ethdev', 'cryptodev', 'pci', 'hash']
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I will squash the change in patch 7834b5c82bf3 if not applied yet.

As discussed on IRC, we should ideally have such dependencies only if
vhost-crypto build is enabled.

Thanks!
Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build
  2018-04-06 12:43 [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build Fan Zhang
  2018-04-06 13:07 ` Maxime Coquelin
@ 2018-04-09 15:51 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2018-04-09 15:51 UTC (permalink / raw)
  To: Fan Zhang, dev; +Cc: jianjay.zhou, jianfeng.tan, pawelx.wodkowski



On 04/06/2018 02:43 PM, Fan Zhang wrote:
> Fixes: 7834b5c82bf3 ("lib/librte_vhost: update makefile")
> 
> This patch fixes some meson build bugs.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/meson.build | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build
> index f01ef67fc..dee154e40 100644
> --- a/lib/librte_vhost/meson.build
> +++ b/lib/librte_vhost/meson.build
> @@ -10,6 +10,6 @@ endif
>   version = 4
>   allow_experimental_apis = true
>   sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
> -		'virtio_net.c', 'virtio_crypto.c')
> +		'virtio_net.c', 'vhost_crypto.c')
>   headers = files('rte_vhost.h', 'rte_vhost_crypto.h')
> -deps += ['ethdev', 'cryptodev', 'pci']
> +deps += ['ethdev', 'cryptodev', 'pci', 'hash']
> 

Squashed into offending commit!

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-09 15:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-06 12:43 [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build Fan Zhang
2018-04-06 13:07 ` Maxime Coquelin
2018-04-09 15:51 ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).