From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id C92291D013 for ; Fri, 6 Apr 2018 15:07:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 614725BCBE; Fri, 6 Apr 2018 13:07:43 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4A78215CDAF; Fri, 6 Apr 2018 13:07:41 +0000 (UTC) To: Fan Zhang , dev@dpdk.org Cc: jianjay.zhou@huawei.com, jianfeng.tan@intel.com, pawelx.wodkowski@intel.com References: <20180406124308.56987-1-roy.fan.zhang@intel.com> From: Maxime Coquelin Message-ID: <3a589d1b-436b-c027-bc53-2d60c4cefb7d@redhat.com> Date: Fri, 6 Apr 2018 15:07:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180406124308.56987-1-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 06 Apr 2018 13:07:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 06 Apr 2018 13:07:43 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 13:07:44 -0000 On 04/06/2018 02:43 PM, Fan Zhang wrote: > Fixes: 7834b5c82bf3 ("lib/librte_vhost: update makefile") > > This patch fixes some meson build bugs. > > Signed-off-by: Fan Zhang > --- > lib/librte_vhost/meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build > index f01ef67fc..dee154e40 100644 > --- a/lib/librte_vhost/meson.build > +++ b/lib/librte_vhost/meson.build > @@ -10,6 +10,6 @@ endif > version = 4 > allow_experimental_apis = true > sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c', > - 'virtio_net.c', 'virtio_crypto.c') > + 'virtio_net.c', 'vhost_crypto.c') > headers = files('rte_vhost.h', 'rte_vhost_crypto.h') > -deps += ['ethdev', 'cryptodev', 'pci'] > +deps += ['ethdev', 'cryptodev', 'pci', 'hash'] > Acked-by: Maxime Coquelin I will squash the change in patch 7834b5c82bf3 if not applied yet. As discussed on IRC, we should ideally have such dependencies only if vhost-crypto build is enabled. Thanks! Maxime