Re: [Patch v4 15/17] net/mana: add function to send packets

[Ferruh Yigit <ferruh.yigit@xilinx.com>]

On 7/9/2022 12:49 AM, longli@linuxonhyperv.com wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
> 
> 
> From: Long Li <longli@microsoft.com>
> 
> With all the TX queues created, MANA can send packets over those queues.
> 
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> Change log:
> v2:
> Rename all camel cases.
> 

<...>

> +
> +               DRV_LOG(DEBUG, "pkt[%d]: buf_addr 0x%p, nb_segs %d, pkt_len %d",
> +                       pkt_idx, m_pkt->buf_addr, m_pkt->nb_segs,
> +                       m_pkt->pkt_len);
> +
> +               /* Create SGL for packet data buffers */
> +               for (uint16_t seg_idx = 0; seg_idx < m_pkt->nb_segs; seg_idx++) {


This is C99 feature and we tend to not use it BUT,

Thomas, David,

In the past there were c89/c90/ansi code in DPDK, but as far as I can 
see no more left.

Is there anything that prevents us using C99 features, like variable in 
the for loop, I think it is usefull that it reduces the scope and makes 
code more readable, etc...