From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10052.outbound.protection.outlook.com [40.107.1.52]) by dpdk.org (Postfix) with ESMTP id A1F9E2BF7; Tue, 18 Sep 2018 18:22:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNBcJXbS3bTEbpvhXJrQDmArjSz7EbkjdUGeamQlzUk=; b=X2S3cqwzqmZTfKHnjKAdBEDlWrWNfm/btEScQp3GEXSb7z2Hn72GEllN772ZOMXYT5j3Rn1kpVr7TV80Xdc90zHNocfKtvegcFWF98XcwQMFLoVulmOdmA+S7RcxQ44tlAYVxL8AxHwAqvsqlj6WkNlbT1Y2Mo7Uz0E6HsXPIf8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from [192.168.1.6] (122.176.9.14) by AM5PR0401MB2531.eurprd04.prod.outlook.com (2603:10a6:203:36::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Tue, 18 Sep 2018 16:22:19 +0000 To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org References: <1535539660-20228-2-git-send-email-hemant.agrawal@nxp.com> <1537277516-8876-1-git-send-email-hemant.agrawal@nxp.com> <1537277516-8876-3-git-send-email-hemant.agrawal@nxp.com> <4111188.BaBaHoflxE@xps> From: Hemant Organization: NXP Message-ID: <3a653f4d-794e-a8cc-1943-5b9592c9f4b0@nxp.com> Date: Tue, 18 Sep 2018 21:52:06 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4111188.BaBaHoflxE@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [122.176.9.14] X-ClientProxiedBy: BM1PR0101CA0004.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::14) To AM5PR0401MB2531.eurprd04.prod.outlook.com (2603:10a6:203:36::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae5b92e9-be07-460d-412d-08d61d82e8b7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0401MB2531; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0401MB2531; 3:AXchfBF2cL5uo5aJa6OZMohLIEqCY7vX3lDTIUAqXv86KAI2PIvJmNQGAgUCl4hyxiXMtzFGP78OOQOyWuMK4N4CS/durv7wqpB5oNfV/UvvqfE+LzsLSY0cp+CmE2x7drXrUUsg8DepDabH7x1dEaDgHVOrSGSdp5FOqB+xbZAWqZ8JiOZ/2X1MGKNas1AbIdGYMyqBShFFF+rJIYHc3h8rdJEpItfQDlYzVARrmeJsZ3r0xa4jRbuO8zXW4W4H; 25:3jMCzwJY7rHbhcuZ6uYNTYKei7vMTFeq6pRcNXTS5+7c1SzI3KpuY3gcGjTtKBmCix/t3lR0E3DdJgLhXMo5VwshivLyPs3DHiLZH9ZiewANhAzb7bJkoxdWaUNeNeau9Q3x8ObqLPRGY2KNIDj6n+q9zT3Et/V2ku9se3FsYsJoWHOcqbq7EF20ETYEgrsdMilJZ71kyKQqJimIj8/TQDk23c1xkBTDkSkCZiDHWv4uy9S+ksO1PcSzCjgDsZvkutmCWI/LYy8wKrhohWArLimNvFgrfkFg4C8vjto2HBIISI2TaJV/DBvJ6oOyLSZS4L4ptLCypedP07bg5mpGaQ==; 31:VYGT7kT2mX+sfU2K7BHP5eJzoHDigjvl+mO9FRfsww7WMSfKkgRYQlGrSgx3f5ndbuVmnyNMyiLxkW+FDTqBlASCPULSdhEF6sG24y8FNIETnOb2dogHflcXL5rzDdMYboNzM0siKxNaUQrC9IosakiJzCqBZdJ8thI+D+Qn2xADbruV5QBRL5WeUG6ZAxVyXGFPoOVwnI8iff/Ewn0DD2rDLZ3s4mWoqI6FX+4F2mg= X-MS-TrafficTypeDiagnostic: AM5PR0401MB2531: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0401MB2531; 20:TaJpdATkJJPi9GxoQJYxQq7hV1UfCKCBbLXRDdHhHnE9HnQI+SsQGW74kuhLoHHCrn4fKlfcU9RA+r5jR0JqRXLoUOajTq0aT02O8d00PTaS4+ubyMHuf15H2wv21T2Tf8wVddlVN40yCNXJH0ZTHu5ZEVZQeGt4r7m5w7C1STz+fBsjL4pYy6zuedFrhst4gK0FVZl57wk58d+qiicicmBnD2r+tp1xiZ1U5/6Hm9FaFcpDP4NWMXhccZ878TRdh5BDPqGssUdg4r1LpmjMbQ43tkJl9OEGopuzfU/p96QDKWVVJGhomresZ3+2TdeznDr2ZRn0SWbRwmkYSt1TkADYNgexMOXIAG94jT2zcKkUjS/yrAh2uNBX1IjyeFrLDL35bNvVJYKBsKTltz+Yr3Y6KTblR+6cRtsqEu0SrYoZMB64OVC/Ng9IyEHA5fpTFsyNzJo1adihELJfMyp7t4DyiqnNFSqjYa+zNSO0UdiP0IRO4xTytljt+Lu/K8Zi; 4:gpUttwSU7fdOnYWnT7SzPpzPkolbSz0dxJRAtoAYYVysvhLCCW7FH4Rl8KyC70Hk7P1IRzSGudlNKPdR+AKId56bDKYLI8ZIe7/28hc6DYnrcwPgHVQLggm/S1+h+SUrf2wHkmeegpHmBDT5BeCfew4HLZswjYHpecaxBEqpQAGBiagxJd1Iios6dzr6ON7nuO3qnuOvJrXuhMmUD9nR7S0/WCz1PACY0K5inFlvuME+hi0wNJPx1vKKQqeJ7dmVm0IbNNe/A+5oSHf7WbYkYpMjKBf8u6NTTYK+GYg7lrXw0zLr3u7yLJPe5dLZ6raV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(201708071742011)(7699050); SRVR:AM5PR0401MB2531; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0401MB2531; X-Forefront-PRVS: 0799B1B2D7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(106356001)(2906002)(81166006)(31696002)(36756003)(8936002)(446003)(305945005)(956004)(2616005)(58126008)(476003)(76176011)(7736002)(6486002)(3450700001)(11346002)(81156014)(486006)(50466002)(2870700001)(86362001)(16576012)(52116002)(64126003)(386003)(67846002)(53546011)(43066004)(26005)(2486003)(117156002)(66066001)(8676002)(65956001)(5660300001)(316002)(478600001)(6916009)(31686004)(36916002)(65806001)(3260700006)(25786009)(23676004)(52146003)(105586002)(6246003)(53936002)(65826007)(47776003)(6666003)(3846002)(77096007)(97736004)(4326008)(186003)(93886005)(16526019)(229853002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0401MB2531; H:[192.168.1.6]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTVQUjA0MDFNQjI1MzE7MjM6emh0U1dsMVNYTTN1bHVhcWpJdEFncENO?= =?utf-8?B?UFkwNnFoczJ4MllaUmFiL0ZsczEzNytUcEpWbThxRWRhVjVLNVZvNjU4UU9Y?= =?utf-8?B?elZJU2I5cEppcmMwVERxdVpHNk45U2hsK2RhZkFzUlExYWw4eEhhU3ZwdDNX?= =?utf-8?B?WmhFZVFrZG82emRVcks0c0xFaFlFTUhPQUF1K21SU2RzUjFoa2ZNRW1MVGhx?= =?utf-8?B?aEE4bnRGaUpMUzh4NHllZ3BvSHN3dkFNYzEzUERRdUxUditiV3pwd2NDbXRM?= =?utf-8?B?V2p3ZFZzMWN3YkZ6SEdDRmZGUXJZWGlTdXpGNVcwUUYwSVdsS1IzbVJZSXJ4?= =?utf-8?B?dnNVK21vcGpSQjZiYUtuZEp3ZlZBdUtTOUNoSnE2N1lJeEFNM0FJS3FXY3Y0?= =?utf-8?B?ZmM2UTk5VzZpTklDNDVNYUNyems2b3AvVnFOYldMbDBRSktuc1AvSHVPS1Z1?= =?utf-8?B?ZUNEbExCSnZxc1dNLzhmMDloeGVISnFjUVlicVRQbHVYbitOQnowSENLZ0lv?= =?utf-8?B?aU53Wlo5VjZUdTc1bUZvYmR5Vy8vN0kzMy9FL29BNmV3UVkwdVhSSlRyNFFW?= =?utf-8?B?Nm9QZmRzYnJIakRuYytVbEUvRS9sa0hEMjFUZUlrcG92UUpBME40NGhCRExq?= =?utf-8?B?WnRQam16bGNIOEsxNVdWUFhTZ2I5ZTVnVnJBZ2lqUENvbUZRaVJpaUIrRSs2?= =?utf-8?B?VUptMnNUbGVvRVBEUDJ2b0REQnNBSWtoaTVhdDM4SGg3aVdTZUJCTkg5M2ZU?= =?utf-8?B?MDRHbkVVOUE0d3VZczBnTDlTcE5QTTdIMjluMzJZZUFwSjlzam93dzc1TnVh?= =?utf-8?B?ZjFBaVpwMnZkSUZkN2RiU2JyZ2hUOVMzb05ESFE5VUVSM01yZHlNeUlSUWw2?= =?utf-8?B?Znh1Qm1HWVZna2llTEhGNmQ2MmVUN2o0Z3F0by8xU1F4VWJJc0krRTlqZlVD?= =?utf-8?B?R2RDdGpneGVqZDlrOEg1ajJlRXIydEJuMFpBQmwvaXYra3dENXdrYlZkUUpi?= =?utf-8?B?Y2U2MzRMdDNIR2R6RFByV2daa21EZkNPQXJiYUxYczN2L3NNUVlJcDBXUXF0?= =?utf-8?B?RHJxcW1INlF2MUhNUndvOFdhS2dUM2xYN2ZLWEhHRUtidmVFd2RxMWxtTFMz?= =?utf-8?B?U1VhakYvYTVyMy9oMzBJb0t0bmk2QVVxNzNRWGZSYlg1b1dDRGc3TWpKeU9H?= =?utf-8?B?TVQrOTc5RGEyTFBVRy9lMXJ2NHZjTk4xVzVUVDB6NlhGZDdHUUFoN1JtR2Q5?= =?utf-8?B?b3ZMa1FLTHY4OENnaU5rZ1RZbmlBMUJkeWVKN1pRTHlnSmU2NGx2TWlzVkZC?= =?utf-8?B?cWRvbFRaenRoOXFybFNkZURGUUFYU3BULzZJbHBlZHNSZVM4MjhFVis5QWln?= =?utf-8?B?akZaT2NJQ1pkZFI1VSs4YXlnYXlRVUo1K2VFODYwYjBpZko4Q1RXbWxZaHFE?= =?utf-8?B?am51NUg5RlFqYWhPUC8zVTFOS20yU2VxZlFHemFzL3Iza0pnc0l2aVMxV2hk?= =?utf-8?B?Y0ZwTk50ejRaS0I3Q0gyZk9GUnluaVpIT05JY29CWTY0UFNuRzE5a013bWNj?= =?utf-8?B?YWk3YVd6OFBBRmZNMWtFNGZVYWhSQzV4Tnh6RVNlRzdzUU54MnBiaTV5cUda?= =?utf-8?B?ZWVpNFN0WEhYWTBUSjlaRkFwV1ZOek5jOWYwSVRiZ1pkaHc4dVlBNDV6Wmdy?= =?utf-8?B?ZWsyall0K2ZOYXV5QXRjZTVKSnQ2L1ljL2FtMzhJbXBuWC9EUSt0TlZuUklG?= =?utf-8?B?VHIzWmZ5Q1p2c3BVeUQwZkM0VExmVlVkTHFhekx5bXZFZ1k4TnBKeHowR2F2?= =?utf-8?B?QkRZMEpMYzdCQkJPVmJBQ0dJZjd6M1lFeVpPWnhBMkN1ZVVwTVRxa2wwTnVz?= =?utf-8?B?Nm5veWhuSE1pRWdXMC93SThOMi80WkZHaW1oT1E2azYzdWZDaElib1R6eHFK?= =?utf-8?B?WWZnVEZGTlZsOHcydURIcHc3K1Z3bGgyUndza01lVi93bjdpZ3E3S3dYcWNV?= =?utf-8?B?ODYwT0RnOWpUVmFZZjJkc1BZMjBhRlV5cmlQamNTWW9BRk9iS1N5M05HTzJN?= =?utf-8?B?WkJZeXhTYmtsS1MrSXdYYXU5bXl5Y2ZGNndNbDJ3NklKd0RVcld3Mkx3R2JZ?= =?utf-8?B?WW1hUT09?= X-Microsoft-Antispam-Message-Info: 5dfiOFv61sJYCLLKJFwd1BJLfEmU6SGwPL4ITW9s04mAfgFNAJ0Quk2jQMZ+4cbrml8bqpGau87YhUYXVoC00hOrhQFbrJSi+rVnstxNgqvRllaAqgP4Xog/4l7rDkimB1BRaVAeJ4V60Oms/GhUw9gZ/wj7kKHNMuXQtTUS0Elwa6vy4zx3Wn/6SCPInAKlVlQqNMn5LDyYyhDHr3eR2EcpuKMXyjDiPvGJcGaN1L8uaKYoC/xFZpWqDwvp2FLqk5u+op6NGlIlul6mhg0rn7izDt54NXWuG7fPsaLL1UNBRuLP7DWxeDvgxDhtIvtVeqTCMVD5x2GrE3rgATlwqJb2Rqu0RIkwyRmeqQSVGxk= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0401MB2531; 6:9Fvn2Dke9w6OnrrvDUwTk2LX0YNepDHHPwtHNcmR1QqSo8mtX+j/r33XommWUViycRGb88yJP9q2OMLcPLI38tkSzT5xomcO0wReZGUp4k+QXKL+/TU5ccS14cfOB/Nu65bhUV1mlaoP098Zka5i4msnGhDpAo32JxrONJLvPk1GqjPe1M8R49E5pxuFo68Pvo+dLVFYK5PHrDJt+7VYr2eZkuLakJH6211VciZkIUd0cXsIcHHpqePq1SwFilFfi7SYULkEWM5krtrOHRI57HXyzaYuTeHzneIYMYMZUc4wq3w+vd7Yqw6oRw5XfgLw24z2yUQHddfv7zZIbH1Ow8NJ3Zj8I/UUiZ5j0zgBwwVYlG6hzMX0mHBSFlNLzIDNbsKF/u5OhdNjJYlNcD17rzN3D2fA56WU4y8cTiIP6Z0iDUki8o67nKBlzE40XOU0er/V5eKwOU3Eqx2I0qfjRQ==; 5:W5NzPJDIoGSBQbQgjJrJRVnwp2T6ZcNSth3RfiYRSCxcq2TUtph9K3tiegeRP80gktgb5OYomyjvlThpqoMAXgvVmdA2ViIfd8UbibwqwAKG2hiqpjmXHi+/Fyk8NW7mO4i2sfXdGs5EqasDDd6mmU9jqKJb7TS3GhBgC0Iz510=; 7:qaP11JJDRmF9Edw9YTBPv9PSkNXMhNJK+twA9q/DzmUavMEdtzh991p0EYqJPc2g2tTZ8BSQQsFmIsirUfN0kunbkYHTNvrbgTbsmnxdqdRd2EnO9tk1R9EVrnUn5rcuWR6szUCqHKlzJASvVPxgRQZ0F83YmzbOqcJgKPnb/k8MGKc+tJBC/DtsYRq1JluVUvihz0vyHDNSXWMOGlDJXmOht8ThLtATu7KJxulC7byX1S4wlE1fbHHXNN3H0nhX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2018 16:22:19.7273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae5b92e9-be07-460d-412d-08d61d82e8b7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2531 Subject: Re: [dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: hemant.agrawal@nxp.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 16:22:22 -0000 On 9/18/2018 7:33 PM, Thomas Monjalon wrote: > 18/09/2018 15:31, Hemant Agrawal: >> Avoid return after the jumbo buffer config in dev config API >> >> Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") >> Cc: stable@dpdk.org >> >> Signed-off-by: Hemant Agrawal > Thanks for adding some comments in this series. > > About this fix, would it be easier to understand if explaining > what is the bug first? > > yes. I can be more specific here. 1. the dev->data->mtu was not getting updated earlier for the jumbo buffer config. 2. we don't expect to return error, if this config fails. A debug err log is ok.  DPAA1 - supports jumbo by default, enable/disable may give errors.