From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 93B191B13A for ; Tue, 2 Apr 2019 23:21:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 14:21:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,302,1549958400"; d="scan'208";a="139593286" Received: from unknown (HELO [10.241.225.169]) ([10.241.225.169]) by fmsmga007.fm.intel.com with ESMTP; 02 Apr 2019 14:21:54 -0700 To: Thomas Monjalon , Anand Rawat Cc: dev@dpdk.org, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-9-anand.rawat@intel.com> <3868443.jK6Cv4ngdr@xps> From: Pallavi Kadam Message-ID: <3ac129fb-709d-833a-234a-286793e2a322@intel.com> Date: Tue, 2 Apr 2019 14:21:53 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3868443.jK6Cv4ngdr@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 21:21:56 -0000 On 4/2/2019 1:06 PM, Thomas Monjalon wrote: > 02/04/2019 05:54, Anand Rawat: >> Add windows specific logic for eal.c, eal_lcore.c, >> eal_debug.c and eal_thread.c. Updated header files to >> contain suitable function declaractions. >> >> Signed-off-by: Anand Rawat >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Jeff Shaw >> Reviewed-by: Ranjit Menon >> --- > [...] >> + /* >> + * create communication pipes between master thread >> + * and children >> + */ >> + if (_pipe(lcore_config[i].pipe_master2slave, >> + sizeof(char), _O_BINARY) < 0) >> + rte_panic("Cannot create pipe\n"); > rte_panic should be used only in applications, not in libraries. > The application can do something in case of DPDK failure. > Please remove all calls to rte_panic() during next weeks, thanks. Ok, will try to incorporate in v9. Just curious, is this the major issue? Calls to rte_panic() can be seen in linux/eal and freebsd/eal. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 876BDA0679 for ; Tue, 2 Apr 2019 23:21:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AD231B160; Tue, 2 Apr 2019 23:21:56 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 93B191B13A for ; Tue, 2 Apr 2019 23:21:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 14:21:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,302,1549958400"; d="scan'208";a="139593286" Received: from unknown (HELO [10.241.225.169]) ([10.241.225.169]) by fmsmga007.fm.intel.com with ESMTP; 02 Apr 2019 14:21:54 -0700 To: Thomas Monjalon , Anand Rawat Cc: dev@dpdk.org, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-9-anand.rawat@intel.com> <3868443.jK6Cv4ngdr@xps> From: Pallavi Kadam Message-ID: <3ac129fb-709d-833a-234a-286793e2a322@intel.com> Date: Tue, 2 Apr 2019 14:21:53 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3868443.jK6Cv4ngdr@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402212153.GJ7HAgqHSEM0qxkKyFxrsX3cMmDY3eetND06HH9zuoo@z> On 4/2/2019 1:06 PM, Thomas Monjalon wrote: > 02/04/2019 05:54, Anand Rawat: >> Add windows specific logic for eal.c, eal_lcore.c, >> eal_debug.c and eal_thread.c. Updated header files to >> contain suitable function declaractions. >> >> Signed-off-by: Anand Rawat >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Jeff Shaw >> Reviewed-by: Ranjit Menon >> --- > [...] >> + /* >> + * create communication pipes between master thread >> + * and children >> + */ >> + if (_pipe(lcore_config[i].pipe_master2slave, >> + sizeof(char), _O_BINARY) < 0) >> + rte_panic("Cannot create pipe\n"); > rte_panic should be used only in applications, not in libraries. > The application can do something in case of DPDK failure. > Please remove all calls to rte_panic() during next weeks, thanks. Ok, will try to incorporate in v9. Just curious, is this the major issue? Calls to rte_panic() can be seen in linux/eal and freebsd/eal. > >