* [PATCH] app/testpmd: fix build without drivers
@ 2022-02-25 15:26 Thomas Monjalon
2022-02-25 15:50 ` Bruce Richardson
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2022-02-25 15:26 UTC (permalink / raw)
To: dev; +Cc: stable, Xiaoyun Li, Aman Singh, Yuying Zhang, Ajit Khaparde
When ixgbe and bnxt are disabled, compilation was failing:
app/test-pmd/cmdline.c:9396:11: error:
variable 'vf_rxmode' set but not used
Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
app/test-pmd/cmdline.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b4ba8da2b0..7ab0575e64 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
}
RTE_SET_USED(is_on);
+ RTE_SET_USED(vf_rxmode);
#ifdef RTE_NET_IXGBE
if (ret == -ENOTSUP)
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] app/testpmd: fix build without drivers
2022-02-25 15:26 [PATCH] app/testpmd: fix build without drivers Thomas Monjalon
@ 2022-02-25 15:50 ` Bruce Richardson
2022-02-25 16:44 ` Thomas Monjalon
2022-02-25 16:53 ` Ajit Khaparde
0 siblings, 2 replies; 5+ messages in thread
From: Bruce Richardson @ 2022-02-25 15:50 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, stable, Xiaoyun Li, Aman Singh, Yuying Zhang, Ajit Khaparde
On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote:
> When ixgbe and bnxt are disabled, compilation was failing:
>
> app/test-pmd/cmdline.c:9396:11: error:
> variable 'vf_rxmode' set but not used
>
> Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-pmd/cmdline.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b4ba8da2b0..7ab0575e64 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
> }
>
> RTE_SET_USED(is_on);
> + RTE_SET_USED(vf_rxmode);
>
Checking the code, I see the issue and the fix looks correct. However,
doing some basic builds disabling the relevant drivers, and all drivers, in
fact, I fail to reproduce the actual error message. Does this error only
occur at lower optimization levels, or only using clang or similar?
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] app/testpmd: fix build without drivers
2022-02-25 15:50 ` Bruce Richardson
@ 2022-02-25 16:44 ` Thomas Monjalon
2022-02-25 16:53 ` Ajit Khaparde
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2022-02-25 16:44 UTC (permalink / raw)
To: Bruce Richardson
Cc: dev, stable, Xiaoyun Li, Aman Singh, Yuying Zhang, Ajit Khaparde
25/02/2022 16:50, Bruce Richardson:
> On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote:
> > When ixgbe and bnxt are disabled, compilation was failing:
> >
> > app/test-pmd/cmdline.c:9396:11: error:
> > variable 'vf_rxmode' set but not used
> >
> > Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > app/test-pmd/cmdline.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> > index b4ba8da2b0..7ab0575e64 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
> > }
> >
> > RTE_SET_USED(is_on);
> > + RTE_SET_USED(vf_rxmode);
> >
> Checking the code, I see the issue and the fix looks correct. However,
> doing some basic builds disabling the relevant drivers, and all drivers, in
> fact, I fail to reproduce the actual error message. Does this error only
> occur at lower optimization levels, or only using clang or similar?
I don't remember, probably clang only.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] app/testpmd: fix build without drivers
2022-02-25 15:50 ` Bruce Richardson
2022-02-25 16:44 ` Thomas Monjalon
@ 2022-02-25 16:53 ` Ajit Khaparde
2022-02-25 17:33 ` Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: Ajit Khaparde @ 2022-02-25 16:53 UTC (permalink / raw)
To: Bruce Richardson
Cc: Thomas Monjalon, dpdk-dev, dpdk stable, Xiaoyun Li, Aman Singh,
Yuying Zhang
[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]
On Fri, Feb 25, 2022 at 7:50 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote:
> > When ixgbe and bnxt are disabled, compilation was failing:
> >
> > app/test-pmd/cmdline.c:9396:11: error:
> > variable 'vf_rxmode' set but not used
> >
> > Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > app/test-pmd/cmdline.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> > index b4ba8da2b0..7ab0575e64 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
> > }
> >
> > RTE_SET_USED(is_on);
> > + RTE_SET_USED(vf_rxmode);
> >
> Checking the code, I see the issue and the fix looks correct. However,
> doing some basic builds disabling the relevant drivers, and all drivers, in
> fact, I fail to reproduce the actual error message. Does this error only
> occur at lower optimization levels, or only using clang or similar?
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] app/testpmd: fix build without drivers
2022-02-25 16:53 ` Ajit Khaparde
@ 2022-02-25 17:33 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2022-02-25 17:33 UTC (permalink / raw)
To: Ajit Khaparde, Bruce Richardson
Cc: Thomas Monjalon, dpdk-dev, dpdk stable, Xiaoyun Li, Aman Singh,
Yuying Zhang
On 2/25/2022 4:53 PM, Ajit Khaparde wrote:
> On Fri, Feb 25, 2022 at 7:50 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
>>
>> On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote:
>>> When ixgbe and bnxt are disabled, compilation was failing:
>>>
>>> app/test-pmd/cmdline.c:9396:11: error:
>>> variable 'vf_rxmode' set but not used
>>>
>>> Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>> app/test-pmd/cmdline.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>>> index b4ba8da2b0..7ab0575e64 100644
>>> --- a/app/test-pmd/cmdline.c
>>> +++ b/app/test-pmd/cmdline.c
>>> @@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
>>> }
>>>
>>> RTE_SET_USED(is_on);
>>> + RTE_SET_USED(vf_rxmode);
>>>
>> Checking the code, I see the issue and the fix looks correct. However,
>> doing some basic builds disabling the relevant drivers, and all drivers, in
>> fact, I fail to reproduce the actual error message. Does this error only
>> occur at lower optimization levels, or only using clang or similar?
>>
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Thanks
>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Able to reproduce with clang.
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-25 17:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25 15:26 [PATCH] app/testpmd: fix build without drivers Thomas Monjalon
2022-02-25 15:50 ` Bruce Richardson
2022-02-25 16:44 ` Thomas Monjalon
2022-02-25 16:53 ` Ajit Khaparde
2022-02-25 17:33 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).