From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65489A034C; Fri, 25 Feb 2022 18:33:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03F214113D; Fri, 25 Feb 2022 18:33:15 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id A5039410FD; Fri, 25 Feb 2022 18:33:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645810393; x=1677346393; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=ZviBhIQrVAdHw3VtYc6tBLd/idETUbnMqIRIJVKxewc=; b=kJ+QaE7YE8l6ySBAv+r+sitXpV29PsSHevyaxfpqOS4Ye9FUMw8hw34V DF8RSwXvOa6UyDhaWcxr5C1WBZ7W+B/IDP0TQYaNe+Isn3GLE3TMfDMo/ xar6qFe8DzyfxEAbeWjgBRUaYnwTM39wLJuexTs/rMDrDs80XQIeCZfiv BuiU9oEwgfdxRlXGP06igoNr3ekFLYnMu7sbScP7S05Wp+O89SNf84xNH o+iU/mKKkbpKj8w0c9FKzsJ3s3ptOvPi8oEGAEtG6M9CtYgNnxkSQBObo 2yofi7/eyzNkjIALeChwtI7cdN7bbLXS07BKB+qbZofqYmLBREOSHW7Od A==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="232515465" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="232515465" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 09:33:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="506760595" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 25 Feb 2022 09:33:11 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 25 Feb 2022 09:33:10 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 25 Feb 2022 09:33:10 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 25 Feb 2022 09:33:10 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 25 Feb 2022 09:33:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LRcxi3omuKQzXQA/e4eqptqAuCgqzUcRZAQFLV9LdEM3c0zA/A9X3zPWayg9ft9cX92a2tVaU/0wHrXkLeIPTbdh7pemTmIQfKDL8BZ9H3c5HzYoo1okXcq3/9AhhcYFuEWqu/h3CKiLDAw7RxuvoWvp3G49ak4KUcPUDmHysc84ouFXCGap1zKX2bTf9qU3Ki4RCbyHwnlo8PzLxunbzyZKvho4x7cHiyL5hJqkyIONbuw5Ar1EzT1N4VfFisd72E82TwnXdYv9rDhf9NDtS2SOegTn6pzxhh9hvnMnB1TaJbYqcpTz+B+8f8CtRD6Tm5G1j881ATi/j5EylfxVvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gYMHKLescFua7Ol3xUgfqpx2Gc330f5x4XGnmsa7RZg=; b=ODZEpohnoVHN2/5fup/NJP475KKKDV2csAmxtk1CxP0jDvj0ZG5sBSumoKwC+FDlhe8x9UXquiyYz7+YjRVIrNxg5RWYEFlE4/AkiMk05S48CJQJ9wj1kMv+oshgP4Dz46/wNK2eWwFHOQruIno9BQtE3ca+y5BscWA/7UazbQ002tyhDHa/9GCrv9lB3iRArvccxgbWtpXNHL73nTGmdO0VR/8/A6BOTIAFSMW7FXNhjVY3HJZ/DDRB+QG5SCfza4nTqLIRRuDMFoKxN+relfwLwDBwSPAByk9CWgiCqZFKyqVSIKjiZ7HKuRx7n0qRy8sf7UtH2OYNMKgoguHVng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB0033.namprd11.prod.outlook.com (2603:10b6:405:63::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Fri, 25 Feb 2022 17:33:06 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%5]) with mapi id 15.20.5017.024; Fri, 25 Feb 2022 17:33:06 +0000 Message-ID: <3af5b557-42f1-3a02-f404-7a4ccbbbf590@intel.com> Date: Fri, 25 Feb 2022 17:33:00 +0000 Content-Language: en-US To: Ajit Khaparde , Bruce Richardson CC: Thomas Monjalon , dpdk-dev , "dpdk stable" , Xiaoyun Li , Aman Singh , Yuying Zhang References: <20220225152653.72437-1-thomas@monjalon.net> From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: fix build without drivers X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0376.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aebe3209-7a7b-4b26-27df-08d9f884e216 X-MS-TrafficTypeDiagnostic: BN6PR11MB0033:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: klESirMYz+CE9K2cGpfqUhLL85r95yzwTBZs5AF4u0K3Lr24HzLky5cwqtDtsUGQ8P5Fw4Kd5rlqz/zURChSU/pq4SBix5LaFH1w1yGoMrK+XBqFtExw/0tIPjIbxGAU0BkvQhcu7v46MxRGu0Ujbbiax/6xfawvM3wC4lCJiXjrIj1uwzm9Y3y230ZAkXQneZdhMlWgJhA2oJyzZ7SoUbrIt0a4iW7SMIiugerEKbTDU+OGwdfNxEH/f5S6KWsVQH67YGGcYQdM6TI5ixprTjkDqR9H/njmkMWZNETzdVruvv5/dZCaYda/IfSjsulS6Bg6+mL7ofc9bmWaPKgtTXWucc2H7gHgP2AiL/MhQLvsBZ51E4jyr7fo6fsclZUeZ6mLfkRCIC+FZC0HjTlmxsKJ4fNvbVQsyEygMsYvTf8gao89sD/F5esp4Sxd7y8GORzbwMktuTm+qem/YwOManPGS/CkTWcVaFKbFL41R8udtDlygeTb7Ob9siicGHwnuvlO27ZxhhgpBwXROOrSDZYseenBLbiFa3fxVT/Ag0/v726tslxbZOS6rfnjZzKplMSc5j+POxmDG8WmAnHQ0yQdjS+92Q39q2DJHXcQsCyUWD+VNvoYMtYOj8+xXcIiqrM6C4FOI41l6y3Ff09si42gUs9ORQ/RhqYNwk7GXTbopLiaVSGcjVmSt/Y8lEUJ6kYnKm8o8gtHmIa3HTY+6A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(54906003)(44832011)(53546011)(6506007)(6636002)(2906002)(36756003)(83380400001)(31686004)(5660300002)(8936002)(110136005)(66556008)(2616005)(6486002)(6666004)(8676002)(4326008)(31696002)(66476007)(107886003)(316002)(38100700002)(186003)(6512007)(82960400001)(26005)(86362001)(508600001)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHI2VG1NOWx2b3pWVTFCRG1ZUjM3SUFGUndyQyttOFZZbXMwQUx2WlhmY0Uv?= =?utf-8?B?SGk4dUJ3MUNTdUhRSWdCRk12K1BzZkJWalpTOHRqd1VPR0VzOXk2ZkE4NmFG?= =?utf-8?B?RCt5OWQ2NXFCL25JM3h5TlZIbUZXbjBZZFpTNkNhSnN1K1g3TVcvM2lOUURx?= =?utf-8?B?UmlLeE03c1BjeElGMndyWDBkeEN6NHJCUUhDNmh5QngzYkQvKyt3b1YvanBC?= =?utf-8?B?ZDNodURZTlRib2hRbUFuNE9xc3FaRjZ2YmFsbjlrQkhFTVFCU0NiYVdJZSsz?= =?utf-8?B?cWw1YUEwbHA2NU9ZdnQ4WkVHMTk1VTVMNnpDVWdtcVUwVEdDMVJ3ejk3Vkl0?= =?utf-8?B?K3pJSmpjT01XTFpnZGRIbVRKbi9BUFZLSHBQNFRtR3U1VVNLSHhKb0l2eUNS?= =?utf-8?B?NDkvaTZSUjlsdklWSHdGbXdMaU53clJycTd5aE1iNE5RZkJnZkhSa1lLUURl?= =?utf-8?B?STgzQkNhOUtOdWcvZ1JFM3IybCs3aXJZakt6aU94a29Ib1VXYnRLRTRRTmM3?= =?utf-8?B?S0d1bHBsQyt4eFN5Z2ZJWE5VdCtRQVZKNURYK3NIcjFDZWh0NjhIb1lMZDV5?= =?utf-8?B?cUtkU2VBMGhDZDQ0QUd0Tk5hNC9IY0RWNnNhQkpMbUtTOTFjVHUrRzFPS2dx?= =?utf-8?B?dDhlOUVlYkFzM0RtV1ZjRGljSnI4TjdWbThibnhhVHAwMHE4QlRUUGg0ZUs5?= =?utf-8?B?OCs1cHZIYUhVZGREMUhSVDdZVXZ4bGkxTWZ4bHZJSWgxa2RDMHhUbDhWWHh4?= =?utf-8?B?WjFZZHgwRTBMT2NDYUJaR1orYlZLd1hObnBNQVRBbFBIYmZIMDAvejVFb3ZF?= =?utf-8?B?R0p2R2JIcXdHakdNbm9yN244VTRJbXRoQkRvRlpaTnFyR2pWQ3dTRWlRZkdn?= =?utf-8?B?cVNIMkdGR09JV3hyTzAvakhQT2RhMVlVaXpDTTlPNWwzOVNBWnZBdUNVTVRx?= =?utf-8?B?Sm1pWEtmT0twVVZpL3pVNDgrYVRqN1lwT2I3b2dIOGRyb1FzQzdvdThFRkMy?= =?utf-8?B?RmdZdVoxbFpoYUdaTDFiTnNKSE55ZzRlcEx2Z0FWMHl0NTNpQXJhcy9tTEFN?= =?utf-8?B?U0ZZY2RVNEI0T2VkbnEwRlFUK0ZrSFExcDg3c3FoNndCbjd6dzFHT3BaUjgr?= =?utf-8?B?TWhLQXd1UGZGdUkydk4vQk9maWxSYThHNnVOdEVMM05TUWtZelhja2JFQ0tX?= =?utf-8?B?cE80MkhNUHB2QXc3OXF0ZU1mbmtXbkVBV1NIejVuV2I0QW5acXdBakwyNnpt?= =?utf-8?B?UWNyU3d1U05MOXQ5SjlMMEtGYUVDZ1FudU9OajdjVk5lcE1jNzl3b2d5NjRv?= =?utf-8?B?NW53WGU4SVA0eXZzeFVHbzVMUENVeXNGZ0VXK3ROSFhuRndCdEVYcVhxMEI0?= =?utf-8?B?UDdteEY4LzN3RFUwRnJFdXdsajE0MHZXZmFHNmMvTVhlVXBaVGRxdERqb0tZ?= =?utf-8?B?dHRjYzF1R09WRGxXS01ucWdxYUtUbVlHOWRZVFpmZ1N5VEJvYklTT0d3amFp?= =?utf-8?B?RmlxRnllbGIydHRlOENpQzhDRTdoOXpYSjdYaHkrQnJtVi9IbTNNTmxqSHdo?= =?utf-8?B?MnJSYUNuZTVwMU4zNHVlTW11VjFGMzhwRE10VlFWTHRuRWt4aWs2b1EvakNz?= =?utf-8?B?Z3dOZUpYQTdRTm5jUjNJS2FNbUJkRVBnSnVyRERGUyt0Ynh3ZUVWMzVzbERa?= =?utf-8?B?WXRXZ0N6Umxrb2swOWo3RGwrT1lNQzBXenFza1pUSlI2blhybnFVR0FYNEJN?= =?utf-8?B?STF4TzAya3h5d0RjdlVKVDR6YTk3OHBqYVMveGFHUW1ySHRwQVIycFBHYmNP?= =?utf-8?B?TGhkT1YxSUNWYU9DU1RibFVNcjhqZU5McHpMMm9rSFJmUnpwOHpVVHJxd096?= =?utf-8?B?QTR0aUdieFhDUzdjWjZyYmk0SWpVcFRiS0ZDN1krQmZnWTZBTWhnOEdZV0hs?= =?utf-8?B?OE4zWGpYRHV2c0hYYy9CNWxvTTBoR0RlWUd4TXU2NW9tYmZPWVVvYmtlaW5I?= =?utf-8?B?TmZ6cDZ3bkxIQUhCR2lCQnZSSVpVNWZaNjQ1UVBTWGlMenlTWVEyeUFWSlVr?= =?utf-8?B?SDdOeEw3Sm1VbkNLc2pOLzk4YWV6N2lDVXU2Sk1Ta2kxZ280NyswTlozZXRR?= =?utf-8?B?NTFRTnpKWnVFSDM5SW4zTnBRL1VQTnE3QStJRGhOVHB6RUh2ZUtNVFVKaXFY?= =?utf-8?Q?mNlSW1Xx3nzll4qp2WF71mA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: aebe3209-7a7b-4b26-27df-08d9f884e216 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 17:33:06.5078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rcfbm8/QDO0t9/HrpbD+jSFLXGSTbKAB1YbJDNuBFZVEgwH0iz4kP701VIvHN9ffkpSDCrjit2o2tL40P+lDfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0033 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/25/2022 4:53 PM, Ajit Khaparde wrote: > On Fri, Feb 25, 2022 at 7:50 AM Bruce Richardson > wrote: >> >> On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote: >>> When ixgbe and bnxt are disabled, compilation was failing: >>> >>> app/test-pmd/cmdline.c:9396:11: error: >>> variable 'vf_rxmode' set but not used >>> >>> Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> app/test-pmd/cmdline.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>> index b4ba8da2b0..7ab0575e64 100644 >>> --- a/app/test-pmd/cmdline.c >>> +++ b/app/test-pmd/cmdline.c >>> @@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result, >>> } >>> >>> RTE_SET_USED(is_on); >>> + RTE_SET_USED(vf_rxmode); >>> >> Checking the code, I see the issue and the fix looks correct. However, >> doing some basic builds disabling the relevant drivers, and all drivers, in >> fact, I fail to reproduce the actual error message. Does this error only >> occur at lower optimization levels, or only using clang or similar? >> >> Acked-by: Bruce Richardson > Thanks > > Acked-by: Ajit Khaparde Able to reproduce with clang. Applied to dpdk-next-net/main, thanks.