From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C484623C for ; Mon, 16 Jul 2018 07:55:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2018 22:55:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,360,1526367600"; d="scan'208";a="67274782" Received: from nikhilr-mobl1.amr.corp.intel.com (HELO [10.252.72.203]) ([10.252.72.203]) by fmsmga002.fm.intel.com with ESMTP; 15 Jul 2018 22:55:47 -0700 To: Pavan Nikhilesh , jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com Cc: dev@dpdk.org References: <1530859329-160189-1-git-send-email-nikhil.rao@intel.com> <1530859329-160189-2-git-send-email-nikhil.rao@intel.com> <20180710105644.GA6792@ltp-pvn> From: "Rao, Nikhil" Message-ID: <3afb2709-b081-92ef-41ff-a450de482923@intel.com> Date: Mon, 16 Jul 2018 11:25:45 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180710105644.GA6792@ltp-pvn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 05:55:51 -0000 On 7/10/2018 4:26 PM, Pavan Nikhilesh wrote: > +int __rte_experimental > +rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint32_t *caps) > +{ > The caps get API needs to be similar to rx adapter caps get i.e. it needs to > have the eth_port_id as a parameter so that the underlying event dev driver can > expose INTERNAL PORT capability as not all ethdev drivers have the capability > to interact with the eventdevs internal port. > > rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id, > uint32_t *caps); Hi Pavan, Is querying the INTERNAL PORT on a per ethdev basis useful to the application ? For e.g., the txa_init() function in the adapter implementation can only decide to use the internal port if it is supported for all ethdevs, hence I left that upto the eventdev PMD to decide - i.e., it could iterate across txa->dev_count eth devices to make that determination. For caps in general, I agree it makes sense to pass in the ethdev, but the INTERNAL PORT didn't seem useful on a per ethdev basis. We could also replace caps_get with something like a rte_event_eth_tx_adapter_internal_port_check(dev_id) and add a per ethdev caps if needed later. Thanks, Nikhil