From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F74AA0A02; Tue, 27 Apr 2021 16:25:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E037411DC; Tue, 27 Apr 2021 16:25:57 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EC2F6411D5 for ; Tue, 27 Apr 2021 16:25:54 +0200 (CEST) IronPort-SDR: ekKC/DJyMD7By1nLudWC/03DzS2XkSluOWhUdLFIsSMF3xB+TD89UrY7gohcPXPm/2VYyEw9mo 7UHMmA89C5AA== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="196072085" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="196072085" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 07:25:53 -0700 IronPort-SDR: 4hC40bN/4NY8EBCyEYJXI/RQFpYOHl6zASuqWpxRnfjh+kYMR5vH7QP6nD39uCGfecYj380skn 0byU8neZYUHw== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457664038" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.231]) ([10.213.221.231]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 07:25:53 -0700 To: Fengchengwen , "humin (Q)" , dev References: <1619408092-54050-1-git-send-email-humin29@huawei.com> <1619408092-54050-6-git-send-email-humin29@huawei.com> <7bd1346a-99ef-b3a3-49d6-8f914a103c3b@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <3b127e39-e060-959c-6907-ceb316b845d0@intel.com> Date: Tue, 27 Apr 2021 15:25:49 +0100 MIME-Version: 1.0 In-Reply-To: <7bd1346a-99ef-b3a3-49d6-8f914a103c3b@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/2021 3:15 PM, Fengchengwen wrote: > > > > > > *From:*Ferruh Yigit > *To:*humin (Q) ;dev > *Date:*2021-04-27 21:39:45 > *Subject:*Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration > > On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng < fengchengwen@huawei.com > >> >> The rte flow interface does not support the API of the capability >> set. Therefore, fdir configuration logs are added to facilitate >> debugging. >> >> Signed-off-by: Chengwen Feng < fengchengwen@huawei.com > >> Signed-off-by: Min Hu (Connor) < humin29@huawei.com > >> --- >> drivers/net/hns3/hns3_fdir.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c >> index 87c1aef..8b14219 100644 >> --- a/drivers/net/hns3/hns3_fdir.c >> +++ b/drivers/net/hns3/hns3_fdir.c >> @@ -336,6 +336,8 @@ int hns3_init_fd_config(struct hns3_adapter *hns) >>            BIT(INNER_IP_PROTO) | BIT(INNER_IP_TOS) | >>            BIT(INNER_SRC_IP) | BIT(INNER_DST_IP) | >>            BIT(INNER_SRC_PORT) | BIT(INNER_DST_PORT); >> +     hns3_info(hw, "fdir tuple: inner> +               "ip_proto ip_tos l4_src_port l4_dst_port>"); > > > If the messages are for debugging, what do you think about add them as > 'hns3_dbg'? Isn't info level too verbose for debugging? > > yes, it was used for debugging and log analyzing, we use hns3_info because the > default level may not debug in product scenario. > we use verbose readable log because it's useful for reading. > It is possible to dynamically change the log level and get debug logs when needed, I think this is better than enable it by default. > thanks > > BTW: sorry for this reply format because using phone. >