From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 400F841C96; Tue, 14 Feb 2023 17:04:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AAA042DB8; Tue, 14 Feb 2023 17:04:54 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D3413410D1; Tue, 14 Feb 2023 17:04:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676390692; x=1707926692; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=p6VqLl+d1lXuXA7CkzkSWCsKUXOEvaqtRf61hWFRYJ0=; b=aP/mc1McvO8Fh2gb5tzyvYylTjg8IiSl9aoTOTo5L5pRo5chygtK0L+L MthIkg73zND98ty5tsGxwyFz8EPqrUEVwzU8HuVv8tJqo+lyHK6hffEMe JJhCE2x8OwBuZP3EWYYtIW/EOgqV+dRKKqHe8BSInmUGeT0KnqcMZJOVt K3UiOwl2CYe1EhvgoFXbXC8xTmU8lMjYP8MSXlCpF+9F/nTcfktMegvjI 8PfM1+SgFk5SlBUPbwZSp3zzwkjRqjsW8yveZnTt5lyT/Qj9sLYvlTr5F wjht9xI4I2xH7CVxJF4fUBcS5GPfQkYdJJYUMCA+ZMuxgS5eYOMz5VOfE A==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="332504338" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="332504338" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2023 08:04:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="619109043" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="619109043" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 14 Feb 2023 08:04:38 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:38 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:37 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 14 Feb 2023 08:04:37 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BapQvGiOyM2lYhyahe2lPpZZo1FLItC2oeepG2M29TwCSZHfS9XnMAGr4BgfuiHo+STGXt+wbtxT6P1jSbfaj/TNARcGj0vcQMnwNAchC043niEFq//orV2Ht6NrK7bilSBbUeaUa/Pjvyx6XmV/emqgsstI2LpY1bHB+8Q/f0fkXC3TgXfBCLW9Xgz47dgshDdpIAyuv7KRPAkmr8YtEII6YdZmsDNkBDzxfK3OjMTs5ya8EINcDo7Bs0wxPJ+/UKIp6+09wa/wL7wSe0KjflNoz9ARZyJG6gm7lobdUw0i7Dq9AEQeXQ58Z5UE/IyDtWalNLwddYmw10YaLdwDAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SIFOR7QbMvocZyxf+g3FPQNIzJISBqFxPiLVYMnec2Y=; b=mJ1V28yowDuF1GYQzSXj6qUNgdYdini18KDg1xMyMgFuouExp4vb6qe2aIFD5u3SHzn00woypbl57jaXukkxPCbUGESti1sKcCodyCaZsuth8cFEPrmzpYHuwJFShaAWtxLNmKuoBZtKue/4EdxPuiKQQM21CqwBxeTtPR1e3qEqGGV1JH4wnkPQS9wi6vEptqfG75AKDYh9udylu+bpQJrTf8Cxbn8vsA6U4zqtziwCC+uc4yqe5uiwZYZyQky9BY3YVGV7TNrP4l2H62BqsyPaQIzizujHWdABhasGRYKj+XvbhAFQUn7AozF57VIVsMM6BVZSQFYJ1yTYAqnKfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH3PR11MB7894.namprd11.prod.outlook.com (2603:10b6:610:12c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:04:35 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d%9]) with mapi id 15.20.6086.023; Tue, 14 Feb 2023 16:04:35 +0000 Message-ID: <3b2d6779-86fc-9dd1-492a-ea6cff019782@intel.com> Date: Tue, 14 Feb 2023 16:04:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/6] dma/ioat: fix incorrect error reporting on restart Content-Language: en-US To: Bruce Richardson , CC: , References: <20230116153714.554470-1-bruce.richardson@intel.com> <20230116173738.562322-1-bruce.richardson@intel.com> <20230116173738.562322-4-bruce.richardson@intel.com> From: Kevin Laatz In-Reply-To: <20230116173738.562322-4-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::23) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|CH3PR11MB7894:EE_ X-MS-Office365-Filtering-Correlation-Id: 0690b73f-63d5-46df-6079-08db0ea52ad0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EGTswGWYMQC52bS/57XyL/wGlebpqqBCTzN225vzwQLzUMAW3Clz5yFHALoyd4awPU0yAj6hs21lb8va7ls9Z66RmdFb7T+4dz0Ydj90kNYHclY/WNCD6DHEYzvGiYyZ8wDhVRlltoExHJMmmN7NuUtR0QMPWX1HsU9GCD0fXI1zNG+3zTTWD7h2DCJ4MyEh3wmC7xO48fKPr6E7PKU3NxB8ldfsmdDlRCSeUH0vl57+QIboBWA1wVAO7VrfAicnNFEmbudVN91z1WR0esBe2h2gdLedLcQlCDt1kJAyh798PRl4pwo8NbkWEjOVVnEbxql0zCjqidlVls8oHAwA37oAxHHOwlouBctjUkQBiXZd7C8Nqdq8X1mOpsRYWvupJBp6cOz3kY+LiKCX0ColLfrjMqbEW7UoTqJt8sEl4t5xUALeZUlhv+ZRd92GiTj1FmFXkHEohLvgRcfCWTdPClS1u2upvKdZuHbZG9TOJSdvreFtP6Fmr/Nr94ZQiauhpekDN/Oi4GTbxXzJPfsYpwOt6XPNWxgNYoExhfLlqaez+Fv6ZbKMfbMEx3wOmzMQtDM33ItnSHTZV8Mq82UEgllvDwi6uYTge6iNXTiEtUfZVFm8eQ+iYMjAV5ofBKHeNaVQ4wOvr0Qqjxok8Z0YgzGFTIrl4YbVujldN/dOFv9LIg7wQqi2Jd9r8f8ywh6D7dfrdzVZsmbwVWUaweBTk1XVrTil1XIJm9AkGRvWJOw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199018)(38100700002)(53546011)(44832011)(8936002)(5660300002)(31686004)(82960400001)(4744005)(41300700001)(186003)(26005)(6506007)(6512007)(6666004)(66946007)(66556008)(8676002)(66476007)(450100002)(478600001)(31696002)(83380400001)(4326008)(86362001)(2906002)(2616005)(316002)(6486002)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHFrNUM5K3Z0ejJHaklnL0RsdlQyR2ZpUkFmUkJIWFNtemc2ZHdPdHB5R3ps?= =?utf-8?B?NUFpYkVEbncxRUFKdHhWRHVWT0g0QjE0MTJsYjRzejR0MEtzWWxBMk5IemQv?= =?utf-8?B?MThidG1uVkxDVXloT1N6dmJiZHg5UVdacE9WT05ZampTekpyS2RZQVNDYXBX?= =?utf-8?B?Y283eHdDbDRSaFNJOVp1SzIrbWVGVU9HVjZJaVNHUFc3R0NjajBwdWtLZ1FC?= =?utf-8?B?anBYbC9WaWRva3BYSE9BMEdDN3RyNWRqdFQrTzJveEt6bm9OVXdkNjkrbkQ2?= =?utf-8?B?Zk9SV2R6YXJYTzM3RlNVZXZyYzhSQ2wvSjVTYWI4clEvOTMyTmRCSTBYaUZt?= =?utf-8?B?c1N6TjM2MHFxbUtMcDRNUXVFUG9ZenVmMDNKcDl6YU9QVGlQQ1FDejh5dnBF?= =?utf-8?B?OEZjSm5kbHowV1hZY0kxT0JoSnhBa0o2dzVRblpvakRTTFd1aW5IQVlQSWZE?= =?utf-8?B?bFVOWVllTk9zVkJXblVkVFI4QVBMelJPTmEzMWVNV29UMTlQRnljSGNXK2My?= =?utf-8?B?c1VOVlZkY1dBTDUrdExCejVnZy9jSHZBVmU4WElkMDQ0RkNCNXJlRmV4SVRi?= =?utf-8?B?cFZ2eEphN1F4UnZCZVlOeGt1dEFxbXQ4NmFYMmtsY3Y1OWVHNUdvU0YxMDRT?= =?utf-8?B?Q2NLT1p3OHZqREo0Q1FxVktMRlhwU3hjTm8rQ3FYUG5OY25uWDJDa2QvV1R6?= =?utf-8?B?UjNwQzJpV0RNTHpFZzdPcWxKNkJuZWh6eWJiMVdDSmVxWXJXcVNDVjRpU1Yr?= =?utf-8?B?cGl3dEZraXI5RnVOcDQ4MlhHbjgzaG9WdVBlZUgrWmltK2NQNkh3UEpmRzRn?= =?utf-8?B?dkpSdGVEdjdYSkxGaVdVWEVCWDl2WERZaWJ0TGl4YzNvTk04RDczdWVRMndy?= =?utf-8?B?NWx6NlhUQmxadm4yd0Jja20xU3hJY3RPL0hxdmxoRnpPcEgvUGZQUVRrZ2Zv?= =?utf-8?B?a09zMmppZER4WkFRZXZROFlxTzhteCtWcWdIR0ozbno3WkY0WmpveTJocjFw?= =?utf-8?B?VncwbndSS1BZWGlQRnB3NXR2cjM0Y2oyanN3aEJsV040cjljZEFOMzZCNXdK?= =?utf-8?B?MmZZZGV5WXBZd2xTYUg2TWFYZ0RBWEJhaDdyZ0JEcmhlNHN1RmxCZWtJTWNW?= =?utf-8?B?NS85N3VnSmE0ZVhoc1FzZldEODV4eFc0Kzkza1E5SUtWNWFyc0RzTWdlYkRw?= =?utf-8?B?QXpQMUN4aHVyLzdKVjJ6bzYzMmt1eENNeTg3YVNHcitIcmJ6VHQzNEFnMFBB?= =?utf-8?B?eVNVeFRNQmtBY1YxUDRDVjQvRHlNTUpIUytLb3RNU2d0TE5IVDV0clU3VWU4?= =?utf-8?B?alIyZWZxL2FKRDZldjIzZ2Z2L1h0YWdhNzNia0MxQ0ZvNWZsTU9qZ2oxbmp2?= =?utf-8?B?SW5rbjlDSEFvQVF5aXY1dWoxdGVwb2Y0Zm13OTdNUkhQM3dEN0pxN3l3SUFp?= =?utf-8?B?MUROL2pNbWRraUNXeC9EQnY0bDBYVG02WE9zTEZYVE9rdjZoZ1NxV29ZYXMz?= =?utf-8?B?bUZvWGQ4eWg3L21aV05wUWlEUGlUTGthQ3FKUXBvYk8yYk9rdE50Y0h4WDV6?= =?utf-8?B?VHBkdDF4V3lya3lUcnlkNEpBMGZuTk4rNDJtcG44c29HQUtjWVd5eHdWd1pF?= =?utf-8?B?eTFMaFVEQlJaK3ZqWVpGeGhLNlFqVzRwcmhtbkU1aVpRSE1qcUhhdjllSWh5?= =?utf-8?B?TTVnbjVTc3RoTmJ1ZkVOeTJaQUVBajFCcTRMcTlKTGlXVlZLakNMd3FlVllD?= =?utf-8?B?THZQRlVSR2hFVm1vQ0J6azZtcGFHdXRXZDJpWDMyTWY0ZkdVMG5JRVVjR1o1?= =?utf-8?B?bGNlU2dZTzR0ZC9JRDdjRFUzemZJUERoVTUxSW15VnZGamVZcmE0UmgxbmY5?= =?utf-8?B?c0NUMVY3eUpwc0RiQVhXbEc0VUhWZjkzRVpZa0xZMWZ3REltTGdCMm10ckR3?= =?utf-8?B?RVpKNVhucjdRVmdoSVVOVDlURk96Vm14bVBaY1VNSFY1c2xBeEV3NTlFL25E?= =?utf-8?B?U24rUGtXdXBpMmNhUjhOZHVDcWswU1d2RmxIZkowZmtFdVF6Z0F4N0RUUUcw?= =?utf-8?B?Vk9tQXRmM3pmYjBOMEJXdkV5MnozK3oxYUJzaXAzczNITG5hK0tLZmw2V3JC?= =?utf-8?B?bGVIQlh6cGNTN0IwanVpK0oxS3FramphZXdzRTZEUGYvYTExTWdPN2V2Sk00?= =?utf-8?B?cHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0690b73f-63d5-46df-6079-08db0ea52ad0 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:04:35.7029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VFtAU8KHTu70rWtP4Pjq7RRVfxP5s75iyx5YxnHO57smsZ4ZZjuCka3Eg+9YVM7ap5YUI+dFufwG/OZl6V5AbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7894 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 16/01/2023 17:37, Bruce Richardson wrote: > When the DMA device was stopped and restarted by the driver, the control > register specifying the behaviour on error was not getting correctly > reset. This caused unit tests to fail as explicitly introduced errors > were got getting reported back. > > Fix by moving the setting of the register to the start function from the > probe function. > > Fixes: 583f046dd404 ("dma/ioat: add start and stop") > Cc: conor.walsh@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- > drivers/dma/ioat/ioat_dmadev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Acked-by: Kevin Laatz