DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Tiwei Bie <tiwei.bie@intel.com>,
	dev@dpdk.org, zhihong.wang@intel.com,
	David Marchand <david.marchand@redhat.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback
Date: Thu, 21 Nov 2019 13:04:10 +0000	[thread overview]
Message-ID: <3b3507c5-76bd-8db4-e199-920322b6ef79@intel.com> (raw)
In-Reply-To: <2beaa964-0f55-ad6f-1bd7-64c16f310192@intel.com>

On 11/21/2019 12:09 PM, Burakov, Anatoly wrote:
> On 21-Nov-19 8:58 AM, Ferruh Yigit wrote:
>> On 11/21/2019 12:55 AM, Maxime Coquelin wrote:
>>>
>>>
>>> On 11/19/19 8:12 AM, Tiwei Bie wrote:
>>>> The "addr" param has been used since the event callbacks are enabled
>>>> for external memory. So the "__rte_unused" should be dropped.
>>>>
>>>> Besides, slightly refine the coding style by consistently assuming
>>>> tabs are 8 characters.
>>>>
>>>> Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>>>> ---
>>>>   drivers/net/virtio/virtio_user/virtio_user_dev.c | 6 +++---
>>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>>>> index a4400e772..ea016e85d 100644
>>>> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>>>> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>>>> @@ -315,9 +315,9 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev)
>>>>   
>>>>   static void
>>>>   virtio_user_mem_event_cb(enum rte_mem_event type __rte_unused,
>>>> -						 const void *addr __rte_unused,
>>>> -						 size_t len __rte_unused,
>>>> -						 void *arg)
>>>> +			 const void *addr,
>>>> +			 size_t len __rte_unused,
>>>> +			 void *arg)
>>>>   {
>>>>   	struct virtio_user_dev *dev = arg;
>>>>   	struct rte_memseg_list *msl;
>>>>
>>>
>>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>
>>> David or Ferruh, could you pick it directly?
>>> I don't plan to prepare a branch as I have this single patch for next
>>> -rc.
>>
>> I can get it, but can you please confirm that it is safe to go to rc4, since
>> already missed rc3?
>> Also can you please give your review/ack if you already reviewed.
>>
> 
> I don't think there's anything unsafe about removing __rte_unused 
> parameter :) The code itself hasn't changed.
> 

I haven't checked the patch when I write it, agree it looks pretty safe to proceed.

  reply	other threads:[~2019-11-21 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19  7:12 Tiwei Bie
2019-11-21  0:55 ` Maxime Coquelin
2019-11-21  8:58   ` Ferruh Yigit
2019-11-21 12:09     ` Burakov, Anatoly
2019-11-21 13:04       ` Ferruh Yigit [this message]
2019-11-21 14:29   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b3507c5-76bd-8db4-e199-920322b6ef79@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).