From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2783D43249; Sun, 5 Nov 2023 06:56:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15F084029E; Sun, 5 Nov 2023 06:56:47 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 560E240278 for ; Sun, 5 Nov 2023 06:56:45 +0100 (CET) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SNNyp6p01zVj79; Sun, 5 Nov 2023 13:56:34 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sun, 5 Nov 2023 13:56:42 +0800 Subject: Re: [PATCH v3 2/5] net/af_packet: use new API to parse kvargs To: Ferruh Yigit , , "John W. Linville" CC: , References: <20230314124813.39521-1-fengchengwen@huawei.com> <20231103073811.13196-1-fengchengwen@huawei.com> <20231103073811.13196-3-fengchengwen@huawei.com> From: fengchengwen Message-ID: <3b5d68b4-57d0-e779-a9e3-2be0dc14df2e@huawei.com> Date: Sun, 5 Nov 2023 13:56:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, On 2023/11/3 21:11, Ferruh Yigit wrote: > On 11/3/2023 7:38 AM, Chengwen Feng wrote: >> This driver don't care about the 'iface' value, it should use >> rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. >> >> Signed-off-by: Chengwen Feng >> --- >> drivers/net/af_packet/rte_eth_af_packet.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c >> index 397a32db58..54a9f5f746 100644 >> --- a/drivers/net/af_packet/rte_eth_af_packet.c >> +++ b/drivers/net/af_packet/rte_eth_af_packet.c >> @@ -1096,8 +1096,8 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev) >> */ >> if (rte_kvargs_count(kvlist, ETH_AF_PACKET_IFACE_ARG) == 1) { >> >> - ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG, >> - &open_packet_iface, &sockfd); >> + ret = rte_kvargs_process_opt(kvlist, ETH_AF_PACKET_IFACE_ARG, >> + &open_packet_iface, &sockfd); >> if (ret < 0) >> goto exit; >> } > > lets not update this driver, I think it is using kvargs > unconventionally, 'iface' requires argument but driver parses it > directly from kvargs. > > We can fix kvargs usage more properly instead of this change, I am > taking a mental note for this. got, it was droped from v4. Thanks Chengwen > . >