From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement
Date: Thu, 8 Nov 2018 09:25:38 +0300 [thread overview]
Message-ID: <3b646bb3-0fd6-efda-6508-93f39d6af5f6@solarflare.com> (raw)
In-Reply-To: <1541642954-37497-2-git-send-email-wenzhuo.lu@intel.com>
On 11/8/18 5:09 AM, Wenzhuo Lu wrote:
> The new configuration is stored during the process.
> But the process may fail. We better rolling the
> configuration back as the new one doesn't take effect.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
I would say that the order is wrong. We should fix this bug first and
the changeset should have appropriate Fixes tags.
I think this bug is older and should be fixed first.
Then the second bug should be fixed without this one present.
next prev parent reply other threads:[~2018-11-08 6:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 5:27 [dpdk-dev] [PATCH] ethdev: fix device info getting Wenzhuo Lu
2018-07-12 8:06 ` Andrew Rybchenko
2018-07-13 1:56 ` Lu, Wenzhuo
2018-07-13 2:42 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2018-07-13 8:02 ` Andrew Rybchenko
2018-07-16 1:08 ` Lu, Wenzhuo
2018-07-16 1:58 ` Lu, Wenzhuo
2018-08-01 15:36 ` Thomas Monjalon
2018-08-13 2:50 ` Lu, Wenzhuo
2018-08-13 8:38 ` Andrew Rybchenko
2018-08-14 0:57 ` Lu, Wenzhuo
2018-08-22 16:55 ` Ferruh Yigit
2018-08-23 8:58 ` Andrew Rybchenko
2018-10-22 12:01 ` Ferruh Yigit
2018-10-22 12:13 ` Thomas Monjalon
2018-10-23 1:25 ` Lu, Wenzhuo
2018-10-23 7:28 ` Thomas Monjalon
2018-11-06 0:56 ` Lu, Wenzhuo
2018-11-06 7:40 ` Andrew Rybchenko
2018-11-08 2:09 ` [dpdk-dev] [PATCH v3 1/2] " Wenzhuo Lu
2018-11-08 2:09 ` [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement Wenzhuo Lu
2018-11-08 6:25 ` Andrew Rybchenko [this message]
2018-11-09 21:10 ` Ferruh Yigit
2018-11-13 0:46 ` Lu, Wenzhuo
2018-11-13 9:40 ` Ferruh Yigit
2018-11-14 1:28 ` Lu, Wenzhuo
2018-11-13 11:12 ` [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure Ferruh Yigit
2018-11-13 11:12 ` [dpdk-dev] [PATCH v4 2/3] ethdev: fix device info getting Ferruh Yigit
2018-11-13 11:19 ` Andrew Rybchenko
2018-11-13 11:12 ` [dpdk-dev] [PATCH v4 3/3] ethdev: eliminate interim variable Ferruh Yigit
2018-11-13 11:22 ` Andrew Rybchenko
2018-11-13 11:51 ` Ferruh Yigit
2018-11-13 11:56 ` Andrew Rybchenko
2018-11-13 11:19 ` [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure Andrew Rybchenko
2018-11-13 17:49 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b646bb3-0fd6-efda-6508-93f39d6af5f6@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).