DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: <olivier.matz@6wind.com>
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>,
	<hemant.agrawal@nxp.com>, <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] mempool: fix segfault when shared mempool handler not linked
Date: Fri, 31 Mar 2017 11:11:19 +0530	[thread overview]
Message-ID: <3b7b65f5-aa8b-fa4a-de8e-8458ec78ce87@nxp.com> (raw)
In-Reply-To: <1490938537-1177-1-git-send-email-shreyansh.jain@nxp.com>

On Friday 31 March 2017 11:05 AM, Shreyansh Jain wrote:
> Fixes: 449c49b93a6b ("mempool: support handler operations")
>
> In case the stack or ring mempool handler are compiled as shared
> library and not linked in with test binary, segfault is reported.
> This is because return value of rte_mempool_set_ops_byname is not
> being checked in rte_mempool_ops_alloc.
>
> This patch handles error returned from rte_mempool_set_ops_byname
> when a mempool is not found.
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---

$ devtools/check-git-log.sh <this patch>
Is it candidate for Cc: stable@dpdk.org backport?
         mempool: fix segfault when shared mempool handler not linked

I am not sure this needs to be in stable. Previous versions never had
an external mempool handler and ring/stack are statically linked in
always.
Though, if a new handler is added (out of tree) over 16.11, and somehow
and application requests for it without linking the library, this
segfault would occur.

Any suggestions?

And just to add to this patch, this segfault is in 'test' binary. It may 
not necessarily be the case for other application if they are
handling the error well.

  parent reply	other threads:[~2017-03-31  5:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11490938158-936-1-git-send-email-shreyansh.jain@nxp.com>
2017-03-31  5:35 ` Shreyansh Jain
2017-03-31  5:35   ` [dpdk-dev] [PATCH v3 2/3] mempool: introduce ring mempool driver Shreyansh Jain
2017-03-31 13:49     ` Olivier Matz
2017-03-31  5:35   ` [dpdk-dev] [PATCH v3 3/3] mempool: introduce stack " Shreyansh Jain
2017-03-31 13:50     ` Olivier Matz
2017-03-31  5:41   ` Shreyansh Jain [this message]
2017-03-31 13:44     ` [dpdk-dev] [PATCH v3 1/3] mempool: fix segfault when shared mempool handler not linked Olivier Matz
2017-03-31 13:49   ` Olivier Matz
2017-04-03 16:58     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b7b65f5-aa8b-fa4a-de8e-8458ec78ce87@nxp.com \
    --to=shreyansh.jain@nxp.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).