From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AEDFA00C3; Fri, 7 Oct 2022 18:33:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AEE040A80; Fri, 7 Oct 2022 18:33:26 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id A094040687 for ; Fri, 7 Oct 2022 18:33:24 +0200 (CEST) Received: from [192.168.1.126] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 11C277B; Fri, 7 Oct 2022 19:33:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 11C277B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1665160404; bh=JDDVaGkssOUOS4w+zZQUSIMXjSRX3aIu3RLal/w1LtM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=b0S1qOriSLieSm1mjHeSPh5Hauq/o6ZLYmjaUXwyArNDYqTSE608SR+WkGyAj9iAX akdGtdeHjgjRzhLj2Ihra+I25mHVsnsoaZh+NvdkiqC5HQOU1Cn0FXLb804gYWpXGN lrTQzWKdJcIa7ZEg5jUP+y7sjaNgYTBBd4GdUnVw= Message-ID: <3b876353-594d-18af-76d7-22f893050e23@oktetlabs.ru> Date: Fri, 7 Oct 2022 19:33:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v7 2/4] ethdev: support mulitiple mbuf pools per Rx queue To: Stephen Hemminger , Thomas Monjalon Cc: Hanumanth Pothula , Ferruh Yigit , dev@dpdk.org References: <20221006170126.1322852-1-hpothula@marvell.com> <20221007143723.3204575-1-andrew.rybchenko@oktetlabs.ru> <20221007143723.3204575-3-andrew.rybchenko@oktetlabs.ru> <13112956.dW097sEU6C@thomas> <20221007091814.764ada2a@hermes.local> <20221007092006.68e5d7fc@hermes.local> Content-Language: en-US From: Andrew Rybchenko In-Reply-To: <20221007092006.68e5d7fc@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/7/22 19:20, Stephen Hemminger wrote: > On Fri, 7 Oct 2022 09:18:14 -0700 > Stephen Hemminger wrote: > >> On Fri, 07 Oct 2022 18:08:57 +0200 >> Thomas Monjalon wrote: >> >>>> + /* Ensure that we have one and only one source of Rx buffers */ >>>> + if ((mp != NULL) + >>> >>> + operator? >>> Are we sure a boolean is always translated as 1? >> >> Yes, it is likely part of C standard. > > > Found it: https://en.cppreference.com/w/c/language/operator_comparison > The type of any equality operator expression is int, and its value (which is not an lvalue) is 1 > when the specified relationship holds true and ​0​ when the specified relationship does not hold. Many thanks, Stephen.