DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Xiaohua Zhang <xiaohua.zhang@windriver.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: add support for wind river avp device
Date: Mon, 12 Feb 2018 10:13:01 +0000	[thread overview]
Message-ID: <3bc80bbb-155a-c9f7-1b9d-b6e26ca42e37@intel.com> (raw)
In-Reply-To: <1518342737-9244-1-git-send-email-xiaohua.zhang@windriver.com>

On 11-Feb-18 9:52 AM, Xiaohua Zhang wrote:
> Signed-off-by: Xiaohua Zhang <xiaohua.zhang@windriver.com>
> ---
>   usertools/dpdk-devbind.py | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 18d9386..f488318 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -22,11 +22,14 @@
>                 'SVendor': None, 'SDevice': None}
>   cavium_pkx = {'Class': '08', 'Vendor': '177d', 'Device': 'a0dd,a049',
>                 'SVendor': None, 'SDevice': None}
> +avp_vnic = {'Class': '05', 'Vendor': '1af4', 'Device': '1110',
> +              'SVendor': None, 'SDevice': None}
>   
>   network_devices = [network_class, cavium_pkx]
>   crypto_devices = [encryption_class, intel_processor_class]
>   eventdev_devices = [cavium_sso]
>   mempool_devices = [cavium_fpa]
> +avp_devices = [avp_vnic]
>   
>   # global dict ethernet devices present. Dictionary indexed by PCI address.
>   # Each device within this is itself a dictionary of device properties
> @@ -565,6 +568,9 @@ def show_status():
>       if status_dev == "mempool" or status_dev == "all":
>           show_device_status(mempool_devices, "Mempool")
>   
> +    if status_dev == "avp" or status_dev == "all":
> +        show_device_status(avp_devices, "AVP")
> +
>   def parse_args():
>       '''Parses the command-line arguments given by the user and takes the
>       appropriate action for each'''
> @@ -638,6 +644,7 @@ def do_arg_actions():
>               get_device_details(crypto_devices)
>               get_device_details(eventdev_devices)
>               get_device_details(mempool_devices)
> +            get_device_details(avp_devices)
>           show_status()
>   
>   
> @@ -650,6 +657,7 @@ def main():
>       get_device_details(crypto_devices)
>       get_device_details(eventdev_devices)
>       get_device_details(mempool_devices)
> +    get_device_details(avp_devices)
>       do_arg_actions()
>   
>   if __name__ == "__main__":
> 

Is there any particular reason why this device appears in its own 
category, rather than being added to one of the existing device classes? 
I'm not familiar with AVP but it looks like it's a NIC, so shouldn't it 
be in network_devices category?

-- 
Thanks,
Anatoly

  reply	other threads:[~2018-02-12 10:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11  9:52 Xiaohua Zhang
2018-02-12 10:13 ` Burakov, Anatoly [this message]
2018-02-13  1:43   ` Zhang, Xiaohua
2018-02-13 10:06     ` Burakov, Anatoly
2018-02-13 11:06       ` Ferruh Yigit
2018-02-14  0:48         ` Zhang, Xiaohua
2018-02-14  9:57           ` Burakov, Anatoly
2018-02-14 10:32             ` Bruce Richardson
2018-02-14 23:17               ` Zhang, Xiaohua
2018-02-15  9:28                 ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bc80bbb-155a-c9f7-1b9d-b6e26ca42e37@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=xiaohua.zhang@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).