From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34524A052A; Thu, 26 Nov 2020 13:38:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78960C940; Thu, 26 Nov 2020 13:38:12 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7AE14C93E for <dev@dpdk.org>; Thu, 26 Nov 2020 13:38:10 +0100 (CET) IronPort-SDR: jUiFfNCxoX9L1SNNGFa1idR+4sXmLjt9il4YHE9G696R8vO+JHvUeuUUJhoXJk+tAXEgC0azqR RQSKpbTIG6TA== X-IronPort-AV: E=McAfee;i="6000,8403,9816"; a="169720037" X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="169720037" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 04:38:08 -0800 IronPort-SDR: bdHphXtT7k8lWpafJRxUz2DeiDFLCBXES0ZN8m3ghVZlt5XSZwyQNcZwzdIkA/9+Pb+ZqqfFHX HGOfqr4CGe2w== X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="333364822" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.229.67]) ([10.213.229.67]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 04:38:05 -0800 To: Slava Ovsiienko <viacheslavo@nvidia.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "Wei Hu (Xavier)" <huwei013@chinasoftinc.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "xavier.huwei@huawei.com" <xavier.huwei@huawei.com> References: <20200818120254.72792-1-huwei013@chinasoftinc.com> <20200925124719.26001-4-huwei013@chinasoftinc.com> <MWHPR12MB150124EB62A2654D2D22C5CDDFFC0@MWHPR12MB1501.namprd12.prod.outlook.com> <3600731.79S79Y1HSu@thomas> <d67e199f-85d2-4a9e-67de-49187accfdff@intel.com> <7b31a7ca-a29a-cc7a-7ed7-d22497eb6244@intel.com> <MWHPR12MB150193E5002C65C087D2B50EDFF90@MWHPR12MB1501.namprd12.prod.outlook.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <3bdc98c4-4b31-8bdf-4d06-7da699d0d4a8@intel.com> Date: Thu, 26 Nov 2020 12:38:04 +0000 MIME-Version: 1.0 In-Reply-To: <MWHPR12MB150193E5002C65C087D2B50EDFF90@MWHPR12MB1501.namprd12.prod.outlook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 11/26/2020 7:24 AM, Slava Ovsiienko wrote: > The bug: https://bugs.dpdk.org/show_bug.cgi?id=584 > > Can we pass the nb_segs = 1 always? > One descriptor is minimal basic capability to send, it should be always supported. > Hi Slava, I didn't get your comment, can you please elaborate? > With best regards, Slava > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> Sent: Wednesday, November 25, 2020 16:07 >> To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Wei Hu (Xavier) >> <huwei013@chinasoftinc.com> >> Cc: dev@dpdk.org; xavier.huwei@huawei.com; Slava Ovsiienko >> <viacheslavo@nvidia.com> >> Subject: Re: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on >> txpkts set >> >> On 11/24/2020 12:23 PM, Ferruh Yigit wrote: >>> On 11/24/2020 10:27 AM, Thomas Monjalon wrote: >>>> Is it OK to keep this regression? >>>> >>>> Ferruh, what do you suggest? >>>> >>> >>> I confirm the '--txpkts' parameter is broken now, I suggest submitting >>> a defect for it and continue with the regression. >>> >> >> Hi Slava, >> >> Can you please submit the Bugzilla defect? >> >> Thanks, >> ferruh >> >> >>> We have alternative for the parameter, "set txpkts <len0[,len1]*>" command. >>> The parameter was only working when hardcoded '--txd=N' parameter is >>> provided, the command is more dynamic and works however queue size is >> configured. >>> >>> We can fix the '--txpkts' in next release. >>> >>>> >>>> 23/11/2020 12:50, Slava Ovsiienko: >>>>> Hi, Wei >>>>> >>>>> It was found this patch rejects the --txpkts command line settings. >>>>> set_tx_pkt_segments() is called before device started and we have >>>>> failure chain: >>>>> >>>>> set_tx_pkt_segments() >>>>> nb_segs_is_invalid() >>>>> get_tx_ring_size () >>>>> rte_eth_tx_queue_info_get() >>>>> >>>>> It causes --txpkts testpmd command line option is ignored. >>>>> >>>>> With best regards, Slava >>>>> >>>>>> -----Original Message----- >>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Wei Hu (Xavier) >>>>>> Sent: Friday, September 25, 2020 15:47 >>>>>> To: dev@dpdk.org >>>>>> Cc: xavier.huwei@huawei.com >>>>>> Subject: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction >>>>>> on txpkts set >>>>>> >>>>>> From: Chengchang Tang <tangchengchang@huawei.com> >>>>>> >>>>>> Currently, if nb_txd is not set, the txpkts is not allowed to be >>>>>> set because the nb_txd is used to avoid the numer of segments >>>>>> exceed the Tx ring size and the default value of nb_txd is 0. And >>>>>> there is a bug that nb_txd is the global configuration for Tx ring >>>>>> size and the ring size could be changed by some command per queue. >>>>>> So these valid check is unreliable and introduced unnecessary >>>>>> constraints. >>>>>> >>>>>> This patch adds a valid check function to use the real Tx ring size >>>>>> to check the validity of txpkts. >>>>>> >>>>>> Fixes: af75078fece3 ("first public release") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> >>>>>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> >>>>>> --- >>>>>> v3 -> v4: >>>>>> add check 'rte_eth_rx_queue_info_get()' return value and >>>>>> if it is '-ENOSTUP' calculate the 'ring_size'. >>>>>> v3: initial version. >>>>>> --- >>>>>> app/test-pmd/config.c | 64 >>>>>> +++++++++++++++++++++++++++++++++++++++++++++++---- >>>>>> 1 file changed, 60 insertions(+), 4 deletions(-) >>>>>> >>>>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >>>>>> 6496d2f..8ebb927 100644 >>>>>> --- a/app/test-pmd/config.c >>>>>> +++ b/app/test-pmd/config.c >>>>>> @@ -1893,6 +1893,38 @@ tx_queue_id_is_invalid(queueid_t txq_id) } >>>>>> >>>>>> static int >>>>>> +get_tx_ring_size(portid_t port_id, queueid_t txq_id, uint16_t >>>>>> +*ring_size) { >>>>>> + struct rte_port *port = &ports[port_id]; >>>>>> + struct rte_eth_txq_info tx_qinfo; >>>>>> + int ret; >>>>>> + >>>>>> + ret = rte_eth_tx_queue_info_get(port_id, txq_id, &tx_qinfo); >>>>>> + if (ret == 0) { >>>>>> + *ring_size = tx_qinfo.nb_desc; >>>>>> + return ret; >>>>>> + } >>>>>> + >>>>>> + if (ret != -ENOTSUP) >>>>>> + return ret; >>>>>> + /* >>>>>> + * If the rte_eth_tx_queue_info_get is not support for this >>>>>> +PMD, >>>>>> + * ring_size stored in testpmd will be used for validity verification. >>>>>> + * When configure the txq by rte_eth_tx_queue_setup with >>>>>> nb_tx_desc >>>>>> + * being 0, it will use a default value provided by PMDs to >>>>>> +setup this >>>>>> + * txq. If the default value is 0, it will use the >>>>>> + * RTE_ETH_DEV_FALLBACK_TX_RINGSIZE to setup this txq. >>>>>> + */ >>>>>> + if (port->nb_tx_desc[txq_id]) >>>>>> + *ring_size = port->nb_tx_desc[txq_id]; >>>>>> + else if (port->dev_info.default_txportconf.ring_size) >>>>>> + *ring_size = port->dev_info.default_txportconf.ring_size; >>>>>> + else >>>>>> + *ring_size = RTE_ETH_DEV_FALLBACK_TX_RINGSIZE; >>>>>> + return 0; >>>>>> +} >>>>>> + >>>>>> +static int >>>>>> rx_desc_id_is_invalid(uint16_t rxdesc_id) { >>>>>> if (rxdesc_id < nb_rxd) >>>>>> @@ -2986,17 +3018,41 @@ show_tx_pkt_segments(void) >>>>>> printf("Split packet: %s\n", split); >>>>>> } >>>>>> >>>>>> +static bool >>>>>> +nb_segs_is_invalid(unsigned int nb_segs) { >>>>>> + uint16_t ring_size; >>>>>> + uint16_t queue_id; >>>>>> + uint16_t port_id; >>>>>> + int ret; >>>>>> + >>>>>> + RTE_ETH_FOREACH_DEV(port_id) { >>>>>> + for (queue_id = 0; queue_id < nb_txq; queue_id++) { >>>>>> + ret = get_tx_ring_size(port_id, queue_id, &ring_size); >>>>>> + >>>>>> + if (ret) >>>>>> + return true; >>>>>> + >>>>>> + if (ring_size < nb_segs) { >>>>>> + printf("nb segments per TX packets=%u >= " >>>>>> + "TX queue(%u) ring_size=%u - ignored\n", >>>>>> + nb_segs, queue_id, ring_size); >>>>>> + return true; >>>>>> + } >>>>>> + } >>>>>> + } >>>>>> + >>>>>> + return false; >>>>>> +} >>>>>> + >>>>>> void >>>>>> set_tx_pkt_segments(unsigned *seg_lengths, unsigned nb_segs) { >>>>>> uint16_t tx_pkt_len; >>>>>> unsigned i; >>>>>> >>>>>> - if (nb_segs >= (unsigned) nb_txd) { >>>>>> - printf("nb segments per TX packets=%u >= nb_txd=%u - >>>>>> ignored\n", >>>>>> - nb_segs, (unsigned int) nb_txd); >>>>>> + if (nb_segs_is_invalid(nb_segs)) >>>>>> return; >>>>>> - } >>>>>> >>>>>> /* >>>>>> * Check that each segment length is greater or equal than >>>>>> -- >>>>>> 2.9.5 >>>>> >>>>> >>>> >>>> >>>> >>>> >>>> >>> >