From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F0ABA034D; Fri, 4 Feb 2022 11:43:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E66A940143; Fri, 4 Feb 2022 11:43:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4BA6340140 for ; Fri, 4 Feb 2022 11:43:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643971411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3LqQfZ4fdbjsh9NV13fD2hRNyyBqshPc7kOPAJ//tmI=; b=QYUuDSaTxggMcw1NjT4FmatMcjpbMwRbSl4sANyyBDLxQAltNpXcUccpewIs0am9X8CVOR 3uJaL9NWdATh1g2NtC6e78Lqos93j4WgDZuzDyktUwHbt2uS+k94WIsKx+oyoJKXD58p/g mv1DwlnJMiSNmp2qC3baUq+3uSYzozU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-428-ojOJsp7oNk-pC7I-Kon4TQ-1; Fri, 04 Feb 2022 05:43:27 -0500 X-MC-Unique: ojOJsp7oNk-pC7I-Kon4TQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A23521091DAB; Fri, 4 Feb 2022 10:43:26 +0000 (UTC) Received: from [10.39.208.15] (unknown [10.39.208.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EEB5106C0E0; Fri, 4 Feb 2022 10:43:21 +0000 (UTC) Message-ID: <3be61db5-b63a-7daa-098c-dd409203a37a@redhat.com> Date: Fri, 4 Feb 2022 11:43:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 0/2] vhost: fix async address mapping To: Kevin Traynor , xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, yuanx.wang@intel.com References: <20220119151016.9970-1-xuan.ding@intel.com> <2d2831bd-0a8c-2684-118d-37e45fd87994@redhat.com> <2c4069f6-ea11-aebc-dc17-5c49ce6cf19c@redhat.com> From: Maxime Coquelin In-Reply-To: <2c4069f6-ea11-aebc-dc17-5c49ce6cf19c@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/1/22 12:29, Kevin Traynor wrote: > On 01/02/2022 08:28, Maxime Coquelin wrote: >> >> >> On 1/19/22 16:10, xuan.ding@intel.com wrote: >>> From: Xuan Ding >>> >>> This patchset fixes the issue of incorrect DMA mapping in PA mode. >>> Due to the ambiguity of host_phys_addr naming in the guest page >>> struct, rename it to host_iova. >>> >>> v2: >>> * Change the order of patch. >> >> I'm not sure why you changed the order of the patches. >> Now, the second one is the fix, so it will make the backport more >> difficult. Either both are considered to be fixes. I think it can make >> sense as the renaming does not introduce risk of regression and will >> make backporting patches easier in the future. >> >> Other solution is to reverse the order again, but I think tagging the >> renaming as a fix is OK for me here. >> >> What do you think? >> > > Either way sounds ok to me, but can you also add stable tag(s). There > isn't a stable tag on either patch at present. Thanks. OK, will do. Thanks Kevin, Maxime >> Regards, >> Maxime >> >>> >>> Xuan Ding (2): >>>     vhost: rename field in guest page struct >>>     vhost: fix physical address mapping >>> >>>    lib/vhost/vhost.h      |  11 ++-- >>>    lib/vhost/vhost_user.c | 130 >>> ++++++++++++++++++++--------------------- >>>    lib/vhost/virtio_net.c |  11 ++-- >>>    3 files changed, 75 insertions(+), 77 deletions(-) >>> >> >