Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures

["Min Hu (Connor)" <humin29@huawei.com>]

Hi, Ferruh and all,
	I have already sent V3 for this set of patches. Do you have any other 
advice?


在 2021/3/12 18:51, Min Hu (Connor) 写道:
> 
> 
> 在 2021/3/12 18:02, Ferruh Yigit 写道:
>> On 3/12/2021 1:51 AM, Min Hu (Connor) wrote:
>>>
>>>
>>> 在 2021/3/12 2:25, Ferruh Yigit 写道:
>>>> On 3/10/2021 6:16 AM, Min Hu (Connor) wrote:
>>>>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>>>>
>>>>> Adjust the format of hns3 RAS related structures to resolve
>>>>> the static check warnings of reviewbot_c.This patch has no
>>>>> impact on function.
>>>>>
>>>>> The correspond warnings of reviewbot_c:
>>>>> When struct and union members are initialized, each member
>>>>> is initialized on a separate line.
>>>>>
>>>>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>>>
>>>> <...>
>>>>
>>>>>   static const struct hns3_hw_error ppu_mpf_abnormal_int_st1[] = {
>>>>> -    { .int_msk = 0xFFFFFFFF,
>>>>> -      .msg = "rpu_rx_pkt_ecc_mbit_err",
>>>>> -      .reset_level = HNS3_GLOBAL_RESET },
>>>>> -    { .int_msk = 0,
>>>>> -      .msg = NULL,
>>>>> -      .reset_level = HNS3_NONE_RESET}
>>>>> +    {
>>>>> +        .int_msk = 0xFFFFFFFF,
>>>>> +        .msg = "rpu_rx_pkt_ecc_mbit_err",
>>>>> +        .reset_level = HNS3_GLOBAL_RESET
>>>>> +    }, {
>>>>> +        .int_msk = 0,
>>>>> +        .msg = NULL,
>>>>> +        .reset_level = HNS3_NONE_RESET
>>>>> +    }
>>>>>   };
>>>>
>>>> Hi Connor,
>>>>
>>>> This looks like just a syntax change, I wonder what is mentioned
>>>> 'reviewbot_c' that generates a warning?
>>> Hi, Ferruh, the description of 'reviewbot_c' may be misleading,
>>> actually, it means "Huawei General Coding Specification". code from
>>> Our company should follow that, thanks
>>
>> Got it, you can remove the reference it if it is not publicly 
>> accessible, otherwise it doesn't add any values and it may be confusing.
> 
> OK , I will fix it in V3, thanks.
>> .
> .