From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 695BBA054F;
	Tue, 16 Mar 2021 12:32:31 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0C369242807;
	Tue, 16 Mar 2021 12:32:30 +0100 (CET)
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
 by mails.dpdk.org (Postfix) with ESMTP id BE86D2427FE
 for <dev@dpdk.org>; Tue, 16 Mar 2021 12:32:27 +0100 (CET)
Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58])
 by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F0B0V131XzNncN
 for <dev@dpdk.org>; Tue, 16 Mar 2021 19:30:02 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id
 14.3.498.0; Tue, 16 Mar 2021 19:32:22 +0800
To: <dev@dpdk.org>
References: <1615356985-24722-1-git-send-email-humin29@huawei.com>
 <1615356985-24722-5-git-send-email-humin29@huawei.com>
 <773749fe-6420-0729-6cf0-e8aea4c5095c@intel.com>
 <9b2df798-6f9b-018e-30bd-0bed86d336cd@huawei.com>
 <b7afde9c-ae07-2566-b7b8-a1d6d049e319@intel.com>
 <bf8e3b52-b275-1da7-0ab0-f6a9f544123c@huawei.com>
From: "Min Hu (Connor)" <humin29@huawei.com>
Message-ID: <3be83106-61f6-286e-03a1-b0dc1fdae03d@huawei.com>
Date: Tue, 16 Mar 2021 19:32:22 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <bf8e3b52-b275-1da7-0ab0-f6a9f544123c@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS
 related structures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh and all,
	I have already sent V3 for this set of patches. Do you have any other 
advice?


在 2021/3/12 18:51, Min Hu (Connor) 写道:
> 
> 
> 在 2021/3/12 18:02, Ferruh Yigit 写道:
>> On 3/12/2021 1:51 AM, Min Hu (Connor) wrote:
>>>
>>>
>>> 在 2021/3/12 2:25, Ferruh Yigit 写道:
>>>> On 3/10/2021 6:16 AM, Min Hu (Connor) wrote:
>>>>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>>>>
>>>>> Adjust the format of hns3 RAS related structures to resolve
>>>>> the static check warnings of reviewbot_c.This patch has no
>>>>> impact on function.
>>>>>
>>>>> The correspond warnings of reviewbot_c:
>>>>> When struct and union members are initialized, each member
>>>>> is initialized on a separate line.
>>>>>
>>>>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>>>
>>>> <...>
>>>>
>>>>>   static const struct hns3_hw_error ppu_mpf_abnormal_int_st1[] = {
>>>>> -    { .int_msk = 0xFFFFFFFF,
>>>>> -      .msg = "rpu_rx_pkt_ecc_mbit_err",
>>>>> -      .reset_level = HNS3_GLOBAL_RESET },
>>>>> -    { .int_msk = 0,
>>>>> -      .msg = NULL,
>>>>> -      .reset_level = HNS3_NONE_RESET}
>>>>> +    {
>>>>> +        .int_msk = 0xFFFFFFFF,
>>>>> +        .msg = "rpu_rx_pkt_ecc_mbit_err",
>>>>> +        .reset_level = HNS3_GLOBAL_RESET
>>>>> +    }, {
>>>>> +        .int_msk = 0,
>>>>> +        .msg = NULL,
>>>>> +        .reset_level = HNS3_NONE_RESET
>>>>> +    }
>>>>>   };
>>>>
>>>> Hi Connor,
>>>>
>>>> This looks like just a syntax change, I wonder what is mentioned
>>>> 'reviewbot_c' that generates a warning?
>>> Hi, Ferruh, the description of 'reviewbot_c' may be misleading,
>>> actually, it means "Huawei General Coding Specification". code from
>>> Our company should follow that, thanks
>>
>> Got it, you can remove the reference it if it is not publicly 
>> accessible, otherwise it doesn't add any values and it may be confusing.
> 
> OK , I will fix it in V3, thanks.
>> .
> .