From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07C36425D9; Mon, 18 Sep 2023 17:43:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EAAB4025D; Mon, 18 Sep 2023 17:43:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 471344025C for ; Mon, 18 Sep 2023 17:43:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695051790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=agEDWJV6ayhywQc3rKw11l8VQLX1o2StPLdWSF9PgXE=; b=FXdLdYrdIyyFVoyBVTDeRYfX6JgFHwhLN9sELwWQaAIKgV9+CJsTZ+5vP/PLr2CZaU0HoM q9Gf8U14ggo+RSRjqFqAYvHn9h2PYOo3J9dpaZxIZIR28nRSscPn2aSaPQVLjPsJTvSfPb vj33Hk88VDNhDBxLmLJ8NggeXwGe41U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-102-TH1WmgX3Nbmxzb5VlKEcGg-1; Mon, 18 Sep 2023 11:42:37 -0400 X-MC-Unique: TH1WmgX3Nbmxzb5VlKEcGg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 271B1945921; Mon, 18 Sep 2023 15:42:37 +0000 (UTC) Received: from [10.39.208.35] (unknown [10.39.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B3A984021A9; Mon, 18 Sep 2023 15:42:35 +0000 (UTC) Message-ID: <3bfdc20c-65d1-d2be-94d4-cfd1a7fefeca@redhat.com> Date: Mon, 18 Sep 2023 17:42:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/5] bbdev: add new capabilities for FFT processing From: Maxime Coquelin To: Nicolas Chautru , dev@dpdk.org Cc: trix@redhat.com, hemant.agrawal@nxp.com, david.marchand@redhat.com, hernan.vargas@intel.com References: <20230615164901.40845-1-nicolas.chautru@intel.com> <20230615164901.40845-3-nicolas.chautru@intel.com> <7d7e2a64-fc80-a549-5f00-0cd4d7b47ff6@redhat.com> In-Reply-To: <7d7e2a64-fc80-a549-5f00-0cd4d7b47ff6@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/18/23 17:08, Maxime Coquelin wrote: > > > On 6/15/23 18:48, Nicolas Chautru wrote: >> Extending existing FFT operation for new capabilities. >> Optional frequency domain dewindowing, frequency resampling, >> timing error correction and time offset per CS. >> >> Signed-off-by: Nicolas Chautru >> --- >>   doc/guides/prog_guide/bbdev.rst | 24 ++++++++++++++++++++++++ >>   lib/bbdev/rte_bbdev_op.h        | 23 ++++++++++++++++++++++- >>   2 files changed, 46 insertions(+), 1 deletion(-) >> >> diff --git a/doc/guides/prog_guide/bbdev.rst >> b/doc/guides/prog_guide/bbdev.rst >> index 8e384015ee..95b33562fe 100644 >> --- a/doc/guides/prog_guide/bbdev.rst >> +++ b/doc/guides/prog_guide/bbdev.rst >> @@ -1111,6 +1111,18 @@ with the operation flags forming a bitmask in >> the ``op_flags`` field. >>   |RTE_BBDEV_FFT_FP16_OUTPUT                                           | >>   | Set if the output data shall use FP16 format instead of INT16      | >>   +--------------------------------------------------------------------+ >> +|RTE_BBDEV_FFT_TIMING_OFFSET_PER_CS                                  | >> +| Set if device supports adjusting time offset per CS                | >> ++--------------------------------------------------------------------+ >> +|RTE_BBDEV_FFT_TIMING_ERROR                                          | >> +| Set if device supports correcting for timing error                 | >> ++--------------------------------------------------------------------+ >> +|RTE_BBDEV_FFT_DEWINDOWING                                           | >> +| Set if enabling the option FFT Dewindowing in Frequency domain     | >> ++--------------------------------------------------------------------+ >> +|RTE_BBDEV_FFT_FREQ_RESAMPLING                                       | >> +| Set if device supports the optional frequency resampling           | >> ++--------------------------------------------------------------------+ >>   The FFT parameters are set out in the table below. >> @@ -1121,6 +1133,8 @@ The FFT parameters are set out in the table below. >> >> +-------------------------+--------------------------------------------------------------+ >>   |base_output              |output >> data                                                   | >> >> +-------------------------+--------------------------------------------------------------+ >> +|dewindowing_input        |optional frequency domain dewindowing >> input data              | >> ++-------------------------+--------------------------------------------------------------+ >>   |power_meas_output        |optional output data with power >> measurement on DFT output     | >> >> +-------------------------+--------------------------------------------------------------+ >>   |op_flags                 |bitmask of all active operation >> capabilities                  | >> @@ -1155,6 +1169,16 @@ The FFT parameters are set out in the table below. >> >> +-------------------------+--------------------------------------------------------------+ >>   |fp16_exp_adjust          |value added to FP16 exponent at >> conversion from INT16         | >> >> +-------------------------+--------------------------------------------------------------+ >> +|freq_resample_mode       |frequency ressampling mode (0:transparent, >> 1-2: resample)     | >> ++-------------------------+--------------------------------------------------------------+ >> +| output_depadded_size    |output depadded size prior to frequency >> resampling            | >> ++-------------------------+--------------------------------------------------------------+ >> +|cs_theta_0               |timing error correction initial >> phase                         | >> ++-------------------------+--------------------------------------------------------------+ >> +|cs_theta_d               |timing error correction phase >> increment                       | >> ++-------------------------+--------------------------------------------------------------+ >> +|time_offset              |time offset per CS of time domain >> samples                     | >> ++-------------------------+--------------------------------------------------------------+ >>   The mbuf input ``base_input`` is mandatory for all bbdev PMDs and >>   is the incoming data for the processing. Its size may not fit into >> an actual mbuf, >> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h >> index 990d110fa7..682e265327 100644 >> --- a/lib/bbdev/rte_bbdev_op.h >> +++ b/lib/bbdev/rte_bbdev_op.h >> @@ -50,6 +50,7 @@ extern "C" { >>   #define RTE_BBDEV_LDPC_MAX_CODE_BLOCKS (256) >>   /* 12 CS maximum */ >>   #define RTE_BBDEV_MAX_CS_2 (6) >> +#define RTE_BBDEV_MAX_CS   (12) >>   /* MLD-TS up to 4 layers */ >>   #define RTE_BBDEV_MAX_MLD_LAYERS (4) >>   /* 12 SB per RB */ >> @@ -242,7 +243,15 @@ enum rte_bbdev_op_fft_flag_bitmasks { >>       /** Set if the input data used FP16 format. */ >>       RTE_BBDEV_FFT_FP16_INPUT = (1ULL << 6), >>       /** Set if the output data uses FP16 format. */ >> -    RTE_BBDEV_FFT_FP16_OUTPUT = (1ULL << 7) >> +    RTE_BBDEV_FFT_FP16_OUTPUT = (1ULL << 7), >> +    /** Flexible adjustment of Timing offset adjustment per CS. */ >> +    RTE_BBDEV_FFT_TIMING_OFFSET_PER_CS = (1ULL << 8), >> +    /** Flexible adjustment of Timing error correction per CS. */ >> +    RTE_BBDEV_FFT_TIMING_ERROR = (1ULL << 9), >> +    /** Set for optional frequency domain dewindowing. */ >> +    RTE_BBDEV_FFT_DEWINDOWING = (1ULL << 10), >> +    /** Flexible adjustment of frequency resampling mode. */ >> +    RTE_BBDEV_FFT_FREQ_RESAMPLING = (1ULL << 11) >>   }; >>   /** Flags for MLDTS operation and capability structure */ >> @@ -756,6 +765,8 @@ struct rte_bbdev_op_fft { >>       struct rte_bbdev_op_data base_input; >>       /** Output data starting from first antenna and first cyclic >> shift. */ >>       struct rte_bbdev_op_data base_output; >> +    /** Optional frequency window input data. */ >> +    struct rte_bbdev_op_data dewindowing_input; >>       /** Optional power measurement output data. */ >>       struct rte_bbdev_op_data power_meas_output; >>       /** Flags from rte_bbdev_op_fft_flag_bitmasks. */ >> @@ -790,6 +801,16 @@ struct rte_bbdev_op_fft { >>       uint16_t power_shift; >>       /** Adjust the FP6 exponent for INT<->FP16 conversion. */ >>       uint16_t fp16_exp_adjust; >> +    /** Frequency resampling : 0: Transparent Mode1: 4/3 Resample2: >> 2/3 Resample. */ >> +    int8_t freq_resample_mode; >> +    /** Output depadded size prior to frequency resampling. */ >> +    uint16_t output_depadded_size; >> +    /** Time error correction initial phase. */ >> +    uint16_t cs_theta_0[RTE_BBDEV_MAX_CS]; >> +    /** Time error correction phase increment. */ >> +    uint32_t cs_theta_d[RTE_BBDEV_MAX_CS]; >> +    /* Time offset per CS of time domain samples. */ >> +    int8_t time_offset[RTE_BBDEV_MAX_CS]; >>   }; >>   /* >8 End of structure rte_bbdev_op_fft. */ > > I think you need to document ABI change in: > doc/guides/rel_notes/release_23_11.rst Nevermind, I forgot the FFT API was still experimental. No need to submit a new revision, I will fix the typos in patch 5. Maxime > Once done, please add my: > Acked-by: Maxime Coquelin > > Maxime > >