From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 804E31B1A0 for ; Mon, 18 Sep 2017 16:56:28 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 18 Sep 2017 07:56:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="1173320968" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga001.jf.intel.com with ESMTP; 18 Sep 2017 07:56:25 -0700 To: Shreyansh Jain , dev@dpdk.org Cc: hemant.agrawal@nxp.com References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-29-shreyansh.jain@nxp.com> From: Ferruh Yigit Message-ID: <3c4802aa-e86b-9a16-0f94-707c3297f48e@intel.com> Date: Mon, 18 Sep 2017 15:56:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170909112132.13936-29-shreyansh.jain@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 28/41] net/dpaa: add support for link status update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 14:56:28 -0000 On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > +static int dpaa_eth_link_update(struct rte_eth_dev *dev, > + int wait_to_complete __rte_unused) > +{ > + struct dpaa_if *dpaa_intf = dev->data->dev_private; > + struct rte_eth_link *link = &dev->data->dev_link; > + > + PMD_INIT_FUNC_TRACE(); > + > + if (dpaa_intf->fif->mac_type == fman_mac_1g) > + link->link_speed = 1000; > + else if (dpaa_intf->fif->mac_type == fman_mac_10g) > + link->link_speed = 10000; > + else > + DPAA_PMD_ERR("invalid link_speed: %s, %d", > + dpaa_intf->name, dpaa_intf->fif->mac_type); > + > + link->link_status = dpaa_intf->valid; > + link->link_duplex = ETH_LINK_FULL_DUPLEX; > + link->link_autoneg = ETH_LINK_AUTONEG; Shouldn't this function go and get link information from hardware? > + return 0; > +} > + > static > int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, > uint16_t nb_desc __rte_unused, > @@ -216,6 +238,22 @@ static void dpaa_eth_tx_queue_release(void *txq __rte_unused) > PMD_INIT_FUNC_TRACE(); > } > > +static int dpaa_link_down(struct rte_eth_dev *dev) > +{ > + PMD_INIT_FUNC_TRACE(); > + > + dpaa_eth_dev_stop(dev); Drivers tend to do revers, make link down on device stop. Just to double check if stop() is intended for link down. > + return 0; > +} > + > +static int dpaa_link_up(struct rte_eth_dev *dev) > +{ > + PMD_INIT_FUNC_TRACE(); > + > + dpaa_eth_dev_start(dev); > + return 0; > +} <...>