From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ECF1A09FF; Wed, 6 Jan 2021 19:07:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4C15140E13; Wed, 6 Jan 2021 19:07:15 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4622640FA7; Wed, 6 Jan 2021 19:07:13 +0100 (CET) IronPort-SDR: yXhogt1hEizMdgUAhyeBG65Pe69MNbFZu0Fw/nEmHz5wLpKyJnMbE6Kip+JlnBSViajIRjLe+B sH8bzktHOSOQ== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="241392211" X-IronPort-AV: E=Sophos;i="5.79,327,1602572400"; d="scan'208";a="241392211" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 10:07:13 -0800 IronPort-SDR: z21iH4WPc20rYOkfdrCifa0P2oLz2+Jf/koI1WPLbILIMI93w0f3gqyBdJ2cBRiPIYWmC4BUco Swh3QJJJ2jgg== X-IronPort-AV: E=Sophos;i="5.79,327,1602572400"; d="scan'208";a="422252831" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.93.217]) ([10.251.93.217]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 10:07:11 -0800 To: Gregory Etelson , dev@dpdk.org Cc: matan@nvidia.com, rasland@nvidia.com, thomas@monjalon.net, ajit.khaparde@broadcom.com, stable@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger References: <20200811061443.8214-1-getelson@nvidia.com> <20201126164302.19120-1-getelson@nvidia.com> From: Ferruh Yigit Message-ID: <3c817e3d-7e71-38f4-319f-832f4dd387b6@intel.com> Date: Wed, 6 Jan 2021 18:07:09 +0000 MIME-Version: 1.0 In-Reply-To: <20201126164302.19120-1-getelson@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix testpmd flows left before port stop. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/26/2020 4:43 PM, Gregory Etelson wrote: > According to RTE flow user guide, PMD will not keep flow rules after > port stop. Application resources that refer to flow rules become > obsolete after port stop and must not be used. > Testpmd maintains linked list of active flows for each port. Entries in > that list are allocated dynamically and must be explicitly released to > prevent memory leak. > The patch releases testpmd port flow_list that holds remaining flows > before port is stopped. > > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson Carrying acks from previous version: Acked-by: Ajit Khaparde Acked-by: Ori Kam Applied to dpdk-next-net/main, thanks.