From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB77DA052A; Tue, 26 Jan 2021 16:28:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94A10140F8C; Tue, 26 Jan 2021 16:28:41 +0100 (CET) Received: from mail-109-mta106.mxroute.com (mail-109-mta106.mxroute.com [136.175.109.106]) by mails.dpdk.org (Postfix) with ESMTP id F032C140F88 for ; Tue, 26 Jan 2021 16:28:39 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta106.mxroute.com (ZoneMTA) with ESMTPSA id 1773f4f99c30009319.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 26 Jan 2021 15:28:37 +0000 X-Zone-Loop: ae6853e2fe9a4f2509a520475813531b0cbe2f8cca4a X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id C01103EA04; Tue, 26 Jan 2021 15:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xPstAOnxPyhL4IJOjHxx2XAYK83K8yh65GIl/2JcDQQ=; b=GuBtg7zXB6nQ5DediR45VOAVGU pgi55zU0O2yblw9ShS0+dh21zZt27p5ujUgVsyFDNPDS0+vRF1JVvSBB8a9r+SGeE9X9k9uUlMNS6 NS+jm3x6oFQQojlFbbfhDdos5nCUqFVg9ZPLygkBsxY//hUreFR6W+4SWNNAollUSo39QGCfpJMwk 5JhPt6nT9v3I/o5Bv+lknrHhlJJUFjwe+q2thFN+q0O670BNb9hnq6VoJfoiRuabQOtoORzXjyHo+ Rjvm3sE81/W47yxvOineDiJ2LHh4GWb22IkRGmCHi/UneePKrWM34UkjeX+6f8t9soH61+vJ/l4As X9shTcQw==; To: David Marchand Cc: Maxime Coquelin , dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata References: <20210126101639.250481-1-maxime.coquelin@redhat.com> <20210126101639.250481-3-maxime.coquelin@redhat.com> <39585a4d-e937-b186-c482-b0dc0a48f762@ashroe.eu> From: "Kinsella, Ray" Message-ID: <3c899794-61b8-1abe-6fb2-01ae781e18df@ashroe.eu> Date: Tue, 26 Jan 2021 15:28:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26/01/2021 14:40, David Marchand wrote: > On Tue, Jan 26, 2021 at 2:23 PM Kinsella, Ray wrote: >>>> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore >>>> index 1dc84fa74b..170304c876 100644 >>>> --- a/devtools/libabigail.abignore >>>> +++ b/devtools/libabigail.abignore >>>> @@ -11,6 +11,8 @@ >>>> ; Explicit ignore for driver-only ABI >>>> [suppress_type] >>>> name = eth_dev_ops >>>> +[suppress_function] >>>> + name_regexp = rte_vdev_(|un)register >>>> >>>> ; Ignore fields inserted in cacheline boundary of rte_cryptodev >>>> [suppress_type] >>> >>> Ray, >>> Are you okay with this exception? >> >> Ask a perhaps silly question, >> shouldn't rte_vdev_register & rte_vdev_unregister have been INTERNAL in any case? > > I discussed with Thomas earlier. > > The INTERNAL exception rule we have suppresses changes on symbols > already versioned INTERNAL. > If we mark these two symbols INTERNAL now, they are part of the stable > v21 ABI in any case. > libabigail will still complain about them disappearing. > > $ abidiff --suppr > /home/dmarchan/dpdk/devtools/../devtools/libabigail.abignore > --no-added-syms --headers-dir1 > /home/dmarchan/abi/v20.11/build-gcc-shared/usr/local/include > --headers-dir2 /home/dmarchan/builds/build-gcc-shared/install/usr/local/include > /home/dmarchan/abi/v20.11/build-gcc-shared/dump/librte_bus_vdev.dump > /home/dmarchan/builds/build-gcc-shared/install/dump/librte_bus_vdev.dump > Functions changes summary: 2 Removed, 0 Changed, 0 Added functions > Variables changes summary: 0 Removed, 0 Changed, 0 Added variable > > 2 Removed functions: > > [D] 'function void rte_vdev_register(rte_vdev_driver*)' > {rte_vdev_register@@DPDK_21} > [D] 'function void rte_vdev_unregister(rte_vdev_driver*)' > {rte_vdev_unregister@@DPDK_21} > > We will need an exception in any case for them. > Agreed, I didn't miss that are still going to need the exception. If we agree that everything that is in rte_vdev_bus should be internal. We can also fix that, while we are aware of it. The rule above gets my +1 and I will fix rte_vdev_bus.