From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3802DA053E; Wed, 5 Aug 2020 15:34:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9E262C23; Wed, 5 Aug 2020 15:34:09 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 911CB2B98 for ; Wed, 5 Aug 2020 15:34:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596634448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mWoAUJh9qRyZyMD60olpKc/kYmGvfMCNROz8yWjOJHk=; b=TT3UE5unha5YTBmjspVCSzMqDlAKtFRslS6Mxx80Q4QdniGtJvel5OsuEtCyH15jysWipR p9jS5bWAtE4VZh7TQzWhLNpBk3yGttqp0otlXxTv/DAPm6ItlEu6vgGnJI8yIROBtC9qBl zh2kcK8NiMyRnRi9bbi+2OLM8QX0YVE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-N5C9iIamOCuoScq0FCEntg-1; Wed, 05 Aug 2020 09:34:06 -0400 X-MC-Unique: N5C9iIamOCuoScq0FCEntg-1 Received: by mail-wm1-f71.google.com with SMTP id u14so1966504wml.0 for ; Wed, 05 Aug 2020 06:34:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=mWoAUJh9qRyZyMD60olpKc/kYmGvfMCNROz8yWjOJHk=; b=hEuRH1fDh610ODnKV0z3y6jzZwreqp6SdnntiG76mxVc2D+5oAp4O2W9IqBV5H9GWT wovGI60hZSDSMCQ6+iIM+/O27pGwfgnU3RGTDxM1X2HrWTiQAgCnh82Aow+pQZrRWWGL WET5tSKfeoLAMusPch0uIDFrbscdfE+GkpOBpjTVATBbDJrNRjRA+xP5rqgwjozYlRzJ d47txw8YbxpvTnmYgwLcQqSLBjLlcedSe/z4bRD6RuQ5TTlGb0zBawmIxU50pANRAXpZ JRR7St6FCE4WHz5oqvCCxTPC5NCthvaKw9Fas5Fnx6MydRmmHSRQpgaqtrxVka8Q09/e a6aQ== X-Gm-Message-State: AOAM5339cChLsLNNOSCmhb4ChIv+03JKdOV+OLXD1k7A3AVDGhuggAV3 wG3qedw2jIvrhDTW++309m3pmdvIdA4cAaiwF8Zfrfxzb6Z0f7zSwFqMaNM7bwCVhOZdit6szTo v6lQ= X-Received: by 2002:a1c:e0d7:: with SMTP id x206mr3643221wmg.91.1596634444046; Wed, 05 Aug 2020 06:34:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycZqfd55k5GVqBP9DwxKJrG0Gno8Zd/WLtVe1rn83/+E/S6dsq20Fmr0OmqQ3e/NBOzsKoEQ== X-Received: by 2002:a1c:e0d7:: with SMTP id x206mr3643206wmg.91.1596634443785; Wed, 05 Aug 2020 06:34:03 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([94.73.63.18]) by smtp.gmail.com with ESMTPSA id o125sm3141615wma.27.2020.08.05.06.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 06:34:03 -0700 (PDT) To: Thomas Monjalon Cc: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com References: <20200804073837.88189-1-amorenoz@redhat.com> <3247837.ecEkxrgKqk@thomas> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: <3cabbc35-c774-bfa1-1584-1a4d911c4090@redhat.com> Date: Wed, 5 Aug 2020 15:34:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3247837.ecEkxrgKqk@thomas> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 8/5/20 11:12 AM, Thomas Monjalon wrote: > 04/08/2020 09:38, Adrian Moreno: >> The PREFER_FALLTHROUGH check warns if a passthrough comment is found >> because, in the kernel, the special macro "fallthrough" is prefered. >> >> Since that keyword is not defined in DPDK, ignore the warning. > > We could ask why not defining a similar keyword? > Surely, we can also add the keyword. Given that unintended fallthrough is already protected by the "MISSING_BREAK" and that fallthrough comments are already used in DPDK, I thought it made sense to ignore the check. If you prefer to add the keyword, let me ask: - Where is the right place for it? Maybe rte_common.h? - Should all the comments be replaced with the pseudo-keyword? >> >> Ignoring this check does not affect the MISSING_BREAK check that will >> warn if a switch case/default is not preceded by break or a fallthrough >> comment. >> >> Signed-off-by: Adrian Moreno >> --- >> devtools/checkpatches.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh >> index acf921ae0..4283ca82b 100755 >> --- a/devtools/checkpatches.sh >> +++ b/devtools/checkpatches.sh >> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ >> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ >> SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ >> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ >> -NEW_TYPEDEFS,COMPARISON_TO_NULL" >> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH" > > I would add this option between PREFER_KERNEL_TYPES and BIT_MACRO > to maintain a bit of logic ordering. > OK. I'll reorder it if the final decision is to ignore the check. Thanks -- Adrián Moreno