From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7C630A04B1;
	Tue, 24 Nov 2020 07:42:09 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BD10DC92C;
	Tue, 24 Nov 2020 07:41:53 +0100 (CET)
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
 by dpdk.org (Postfix) with ESMTP id 4E5DDC910;
 Tue, 24 Nov 2020 07:41:50 +0100 (CET)
Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58])
 by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CgDv85Kr3zhf5v;
 Tue, 24 Nov 2020 14:41:24 +0800 (CST)
Received: from tester.localdomain (10.175.119.39) by
 DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id
 14.3.487.0; Tue, 24 Nov 2020 14:41:36 +0800
From: Guoyang Zhou <zhouguoyang@huawei.com>
To: <dev@dpdk.org>
CC: <ferruh.yigit@intel.com>, <bluca@debian.org>,
 <cloud.wangxiaoyun@huawei.com>, <luoxianjun@huawei.com>,
 <yin.yinshi@huawei.com>, <luojiachen@huawei.com>, <zhouguoyang@huawei.com>,
 <chenlizhong@huawei.com>, <zhaohui8@huawei.com>, <chenchanghu@huawei.com>,
 <stable@dpdk.org>
Date: Tue, 24 Nov 2020 14:45:33 +0800
Message-ID: <3cc7af99f75ecd714580835fb68c723cdb0696d3.1606199729.git.zhouguoyang@huawei.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <cover.1606199729.git.zhouguoyang@huawei.com>
References: <cover.1606199729.git.zhouguoyang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.175.119.39]
X-CFilter-Loop: Reflected
Subject: [dpdk-dev] [PATCH v2 1/2] net/hinic/base: remove the limitation for
	max queue num
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The maximum number of queues on the chip can be any value greater
than 0, it does not have to be the power of two, if it does not be
fixed, dpdk initialization may be failed with OVS mode firmware.

Fixes: 828d3e15a9dc ("net/hinic/base: support context and work queue")
Cc: stable@dpdk.org
Signed-off-by: Guoyang Zhou <zhouguoyang@huawei.com>
---
 drivers/net/hinic/base/hinic_pmd_nicio.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/hinic/base/hinic_pmd_nicio.c b/drivers/net/hinic/base/hinic_pmd_nicio.c
index 2736305..162308b 100644
--- a/drivers/net/hinic/base/hinic_pmd_nicio.c
+++ b/drivers/net/hinic/base/hinic_pmd_nicio.c
@@ -758,11 +758,6 @@ static int hinic_alloc_nicio(struct hinic_hwdev *hwdev)
 	int err;
 
 	max_qps = hinic_func_max_qnum(hwdev);
-	if ((max_qps & (max_qps - 1))) {
-		PMD_DRV_LOG(ERR, "Wrong number of max_qps: %d",
-			max_qps);
-		return -EINVAL;
-	}
 
 	nic_io->max_qps = max_qps;
 	nic_io->num_qps = max_qps;
-- 
1.8.3.1