From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BD187968 for ; Mon, 26 Jun 2017 15:51:43 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2017 06:51:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,395,1493708400"; d="scan'208";a="101579806" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 26 Jun 2017 06:51:41 -0700 To: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= Cc: Shachar Beiser , dev@dpdk.org, Adrien Mazarguil References: <4233196997a3d8aba05b16a130ccc87f27f076bf.1498046009.git.shacharbe@mellanox.com> <09f627ea8059ff7fd490ea1120e5c68137fa4944.1498376886.git.shacharbe@mellanox.com> <20170626122846.GB3093@autoinstall.dev.6wind.com> <7e3cc639-bcc5-b02b-0e89-8ddc98f82fcb@intel.com> <20170626134126.GF3093@autoinstall.dev.6wind.com> From: Ferruh Yigit Message-ID: <3cd87f2d-1426-2eca-0ea0-5b834ac16c66@intel.com> Date: Mon, 26 Jun 2017 14:51:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170626134126.GF3093@autoinstall.dev.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 13:51:44 -0000 On 6/26/2017 2:41 PM, Nélio Laranjeiro wrote: > On Mon, Jun 26, 2017 at 01:55:33PM +0100, Ferruh Yigit wrote: >> On 6/26/2017 1:28 PM, Nélio Laranjeiro wrote: >>> On Sun, Jun 25, 2017 at 07:55:01AM +0000, Shachar Beiser wrote: >>>> Missing room in flow allocation to store the drop specification. >>>> Changing flow without storing the change in rte_flow. >>>> Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier") >>>> >>>> Signed-off-by: Shachar Beiser >> >>> Acked-by: Nelio Laranjeiro >> >> Hi Nelio, Shachar, >> >> What do you think squashing this and [1] into 88c77dedfbb0? Both this >> and [1] looks like fixing same commit. >> >> [1] >> e0e37c1f80a0 ("net/mlx5: fix creation of drop flows") > > Hi Ferruh, > > No it is not the same issue, one this new patch is fixing some code for > the hardware drop flow support which will be available with next version > of MLNX_OFED. > > e0e37c1f80a0 ("net/mlx5: fix creation of drop flows") is fixing the > current version of the software drop queue which is possible with the > current MLNX_OFED GA. > > Please keep them separate. OK, thanks for clarification. > > Thanks, >