Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove dead code

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 7/22/2020 1:15 PM, wangyunjian wrote:
>> -----Original Message-----
>> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
>> Sent: Wednesday, July 22, 2020 3:45 PM
>> To: Rasesh Mody <rmody@marvell.com>
>> Cc: wangyunjian <wangyunjian@huawei.com>; dev@dpdk.org; Shahed Shaikh
>> <shshaikh@marvell.com>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke
>> <xudingke@huawei.com>; stable@dpdk.org
>> Subject: Re: [EXT] [dpdk-dev] [PATCH] net/qede: remove dead code
>>
>> On Wed, Jul 22, 2020 at 3:14 AM Rasesh Mody <rmody@marvell.com> wrote:
>>>
>>>> From: wangyunjian <wangyunjian@huawei.com>
>>>> Sent: Friday, July 17, 2020 4:16 AM
>>>>
>>>> From: Yunjian Wang <wangyunjian@huawei.com>
>>>>
>>>> This patch fixes (Logically dead code) coverity issue.
>>>>
>>>> Coverity issue: 261777, 261778
>>>> Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>>>> ---
>>>
>>> Acked-by: Rasesh Mody <rmody@marvell.com>
>>
>> There is build issue reported with this patch by CI for qede. Please check it is
>> valid or not http://mails.dpdk.org/archives/test-report/2020-July/145267.html
> 
> I've already checked. I don't know the reason why the codes on both sides are different.
> 
> The origin code:
> fprintf(stderr,"Can not write all of dump data bytes=%zd len=%zd\n",
> 
> The CI code:
> fprintf(stderr, "Can not write all of dump data bytes=%ld len=%ld\n",
> 

CI run is on top of the 'mrvl' tree (DPDK git baseline:
Repo:dpdk-next-net-mrvl), and above part may be fixed while pulling to the
'next-net'.

Anyway the latest code looks good (for above change), also the error is
unrelated to your patch. So a false positive for this patch.