From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7255A04B5; Fri, 6 Nov 2020 17:44:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 072AEDED; Fri, 6 Nov 2020 17:44:33 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 70D97160 for ; Fri, 6 Nov 2020 17:44:30 +0100 (CET) IronPort-SDR: fv0vF+uDRSU/jWI4KLxDg5nTmGLCi0gLm9hsQbX8DawvVlhEqYf2LFXc0d6nB8PXyhzisGI2TS YV+QNeN1R97g== X-IronPort-AV: E=McAfee;i="6000,8403,9797"; a="169678101" X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="169678101" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 08:44:28 -0800 IronPort-SDR: tCA1WK/5y0R0TqzAzsh62gafLaGwsell1T1ZL+Y9XiaH9uCsn4AHAKOApa15TBvM9RXqK6Qw5r +nbGFsNZLymw== X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="539904273" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.228.45]) ([10.213.228.45]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 08:44:27 -0800 To: Lijun Ou Cc: dev@dpdk.org, linuxarm@huawei.com References: <1604586194-29523-1-git-send-email-oulijun@huawei.com> <1604634716-43484-1-git-send-email-oulijun@huawei.com> <1604634716-43484-4-git-send-email-oulijun@huawei.com> From: Ferruh Yigit Message-ID: <3cdc7009-177b-0323-4577-37c7fb2aa04f@intel.com> Date: Fri, 6 Nov 2020 16:44:24 +0000 MIME-Version: 1.0 In-Reply-To: <1604634716-43484-4-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/hns3: adjust some code style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/6/2020 3:51 AM, Lijun Ou wrote: > From: Hongbo Zheng > > Here adjusts some code style for making the lines more > compact and removes some static check tool warnings. > > Signed-off-by: Hongbo Zheng > Signed-off-by: Lijun Ou > --- > V1->V2: > - fix checkpatch warning > --- > drivers/net/hns3/hns3_cmd.c | 1 - > drivers/net/hns3/hns3_ethdev.c | 6 +- > drivers/net/hns3/hns3_ethdev.h | 1 - > drivers/net/hns3/hns3_flow.c | 37 +- > drivers/net/hns3/hns3_intr.c | 873 +++++++++++++++++++++++++++-------------- > drivers/net/hns3/hns3_rxtx.c | 1 - > drivers/net/hns3/hns3_stats.c | 1 - > 7 files changed, 597 insertions(+), 323 deletions(-) This is a big(ish) patch with just whitespace changes, looks like related to the personal preferences. This will create noise in the git history, and unnecessary conflict in backporting patches. I know it is tempting to fix here or there :), but lets fix those when updating those lines for a functional change, and drop this patch.