From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86A04A0524; Fri, 8 Jan 2021 09:25:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 541B2140E55; Fri, 8 Jan 2021 09:25:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 766A3140E4E for ; Fri, 8 Jan 2021 09:25:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610094333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fHihywBMQqThv1r1ykvAnPPR+FJBZ036m81o9tofGkg=; b=FnY9P0nvCRhshyEs/CzFrTvFjJWwId0ttAaJdP+oPcdWmFJ5Jmi0QdhQpccJkZdnUj7M1O rkxrnqLZh4sFtzmQEcC1TZkjZMwiM1dj6YhyISuNYjYOKkREuAtwCVt2zrKkD39gNwnypE p5Zj/MukUy6b3O2iWloe1zlFeMphhNo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-qw-5BxbYMwCYa2lPAGSW3A-1; Fri, 08 Jan 2021 03:25:29 -0500 X-MC-Unique: qw-5BxbYMwCYa2lPAGSW3A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 144CE809DDD; Fri, 8 Jan 2021 08:25:28 +0000 (UTC) Received: from [10.36.110.9] (unknown [10.36.110.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BEFC709A4; Fri, 8 Jan 2021 08:25:22 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "amorenoz@redhat.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" References: <20201221161456.31696-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <3cecca64-f2cc-5b3b-aa7f-8a02fb951622@redhat.com> Date: Fri, 8 Jan 2021 09:25:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chenbo, On 1/8/21 3:50 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Tuesday, December 22, 2020 12:15 AM >> To: dev@dpdk.org; Xia, Chenbo ; amorenoz@redhat.com; >> david.marchand@redhat.com; olivier.matz@6wind.com >> Cc: Maxime Coquelin >> Subject: [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly >> >> This series optimizes the cache usage of virtqueue struct, >> by make a "fake" mbuf being dynamically allocated in Rx >> virtnet struct, by removing a useless virtuque pointer >> into the virtnet structs and by moving a few fields >> to pack holes. >> >> With these 3 patches, the virtqueue struct size goes from >> 576 bytes (9 cachelines) to 248 bytes (4 cachelines). >> >> Maxime Coquelin (3): >> net/virtio: remove reference to virtqueue in vrings >> net/virtio: allocate fake mbuf in Rx queue >> net/virtio: pack virtuqueue struct >> >> drivers/net/virtio/virtio_ethdev.c | 46 +++++++++++-------- >> drivers/net/virtio/virtio_rxtx.c | 36 +++++++-------- >> drivers/net/virtio/virtio_rxtx.h | 5 +- >> drivers/net/virtio/virtio_rxtx_packed_avx.c | 14 +++--- >> drivers/net/virtio/virtio_rxtx_simple.h | 2 +- >> .../net/virtio/virtio_rxtx_simple_altivec.c | 2 +- >> drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 +- >> drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 +- >> .../net/virtio/virtio_user/virtio_user_dev.c | 4 +- >> drivers/net/virtio/virtio_user_ethdev.c | 2 +- >> drivers/net/virtio/virtqueue.h | 24 ++++++---- >> 11 files changed, 72 insertions(+), 67 deletions(-) >> >> -- >> 2.29.2 > > Does this patchset have a apply issue? Locally I can't apply the patches and > Patchwork also shows apply issues. For got to mention, but the series applied on top of the big rework as it conflict with it, and the rework is more important. Cheers, Maxime > Thanks, > Chenbo >