From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CB2481B0F7; Mon, 18 Feb 2019 16:58:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 07:58:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,385,1544515200"; d="scan'208,217";a="115865215" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.132]) ([10.237.221.132]) by orsmga007.jf.intel.com with ESMTP; 18 Feb 2019 07:58:16 -0800 To: Hari Kumar Vemula , dev@dpdk.org Cc: "Pattan, Reshma" , JananeeX M , Declan , jananeex.m.parthasarathy@intel.com, stable@dpdk.org References: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> From: Radu Nicolau Message-ID: <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> Date: Mon, 18 Feb 2019 15:58:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix reset active slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2019 15:58:21 -0000 On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: > test_alb_reply_from_client test fails due to incorrect active slave > array's index. This was due to invalid active slave count. > > Count of internals->active_slave is not updated even when active slave > is deactivated. > Hence active slave count always keeps incrementing beyond the actual > active slaves. > > Fix is to set the internals->active_slave to starting index 0 whenever > it exceeds the number of slaves in active slave list and also update > the active slave count during slave de-activation. > > Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness") > Cc: stable@dpdk.org > > Signed-off-by: Hari Kumar Vemula > --- > Acked-by: Radu Nicolau >