From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 88C6F1CE94 for ; Sun, 13 May 2018 07:25:40 +0200 (CEST) To: Shahaf Shuler , "dev@dpdk.org" Cc: Yongseok Koh , Adrien Mazarguil , =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= References: <152600339444.53624.14086407337377549776.stgit@localhost.localdomain> <152600348751.53624.931406344332729888.stgit@localhost.localdomain> From: Andy Green Message-ID: <3d1b90be-dd25-4f4f-74b2-3337a51277b9@warmcat.com> Date: Sun, 13 May 2018 13:25:12 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 05:25:40 -0000 On 05/13/2018 12:45 PM, Shahaf Shuler wrote: > Hi Andy > > The patch logic is OK but: > 1. since it is a fix patch the title should start with "fix ..." > 2. add Fixes tag of the relevant commit and Cc stable if needed > 3. add signed-of-by tag > 4. explicitly include the PMD maintainers (Cc'ed now). For a patch adding 4 characters, from a drive-by, it's a lot of overhead. There's already a V2 of this sent yesterday with the signed-off-by (OK, that is not really any overhead) and most of the rest of your stuff donated by Pablo. -Andy > Friday, May 11, 2018 4:51 AM, Andy Green >> Subject: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used >> uninitialized >> >> >> --- >> drivers/net/mlx5/mlx5.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index >> 8f983061a..4d379fb13 100644 >> --- a/drivers/net/mlx5/mlx5.c >> +++ b/drivers/net/mlx5/mlx5.c >> @@ -624,7 +624,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv >> __rte_unused, >> int err = 0; >> struct ibv_context *attr_ctx = NULL; >> struct ibv_device_attr_ex device_attr; >> - unsigned int vf; >> + unsigned int vf = 0; >> unsigned int mps; >> unsigned int cqe_comp; >> unsigned int tunnel_en = 0; >