* [dpdk-dev] [PATCH] net/hns3: fix MAC enable failed rollback
@ 2021-04-29 9:03 Min Hu (Connor)
2021-05-04 14:12 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Min Hu (Connor) @ 2021-04-29 9:03 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
From: Huisong Li <lihuisong@huawei.com>
If driver fails to enable MAC, it does not need to rollback the MAC
configuration. This patch fixes it.
Fixes: bdaf190f8235 ("net/hns3: support link speed autoneg for PF")
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/hns3/hns3_ethdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index a6f4c92..d0f23e8 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -5611,12 +5611,14 @@ hns3_do_start(struct hns3_adapter *hns, bool reset_queue)
ret = hns3_apply_link_speed(hw);
if (ret)
- goto err_config_mac_mode;
+ goto err_set_link_speed;
return 0;
-err_config_mac_mode:
+err_set_link_speed:
(void)hns3_cfg_mac_mode(hw, false);
+
+err_config_mac_mode:
hns3_dev_release_mbufs(hns);
/*
* Here is exception handling, hns3_reset_all_tqps will have the
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/hns3: fix MAC enable failed rollback
2021-04-29 9:03 [dpdk-dev] [PATCH] net/hns3: fix MAC enable failed rollback Min Hu (Connor)
@ 2021-05-04 14:12 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2021-05-04 14:12 UTC (permalink / raw)
To: Min Hu (Connor), dev
On 4/29/2021 10:03 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> If driver fails to enable MAC, it does not need to rollback the MAC
> configuration. This patch fixes it.
>
> Fixes: bdaf190f8235 ("net/hns3: support link speed autoneg for PF")
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-04 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 9:03 [dpdk-dev] [PATCH] net/hns3: fix MAC enable failed rollback Min Hu (Connor)
2021-05-04 14:12 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).