From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0079.outbound.protection.outlook.com [104.47.33.79]) by dpdk.org (Postfix) with ESMTP id 7A05FFAF8 for ; Tue, 20 Dec 2016 07:49:53 +0100 (CET) Received: from CY1PR03CA0011.namprd03.prod.outlook.com (10.174.128.21) by BY2PR0301MB0741.namprd03.prod.outlook.com (10.160.63.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Tue, 20 Dec 2016 06:49:50 +0000 Received: from BY2FFO11FD031.protection.gbl (2a01:111:f400:7c0c::137) by CY1PR03CA0011.outlook.office365.com (2603:10b6:600::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Tue, 20 Dec 2016 06:49:50 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD031.mail.protection.outlook.com (10.1.14.196) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Tue, 20 Dec 2016 06:49:48 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBK6njqD029948; Mon, 19 Dec 2016 23:49:46 -0700 To: Stephen Hemminger References: <20161219215944.17226-1-sthemmin@microsoft.com> <20161219215944.17226-2-sthemmin@microsoft.com> CC: , Stephen Hemminger From: Shreyansh Jain Message-ID: <3d2af45f-8a74-499b-06f2-450e02b8f1c0@nxp.com> Date: Tue, 20 Dec 2016 12:23:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161219215944.17226-2-sthemmin@microsoft.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131266901899375055; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39840400002)(39450400003)(39410400002)(39400400002)(39380400002)(39850400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(24454002)(199003)(377454003)(189002)(31686004)(230700001)(81166006)(229853002)(81156014)(8936002)(8676002)(69596002)(105606002)(64126003)(106466001)(54356999)(23746002)(50986999)(97736004)(68736007)(76176999)(4326007)(4001350100001)(65826007)(189998001)(86362001)(2906002)(47776003)(104016004)(6666003)(6916009)(36756003)(2950100002)(92566002)(110136003)(31696002)(33646002)(85426001)(65806001)(8666005)(305945005)(356003)(38730400001)(50466002)(83506001)(77096006)(5660300001)(65956001)(626004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0741; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD031; 1:NlPl8YYQEHdkzzlei57DbLCOJxjxPoYeEyz29BIYHDB9x8F8irFnOI2aRKtNICmS+86RkqSoLsmmKtruvIgzLgUXBjBSVgh1azwNZXOLKeNdXbS2xdMjaa6h0Pn/txekPxcLU0z7GvTCFm88n1vC0KgKUdQPnnj7LYC5+TaQb2u/1zB8f+JwGIRGMmhvhGoVYekSdufR9DUaI9qJNC4tU2x0gUIrwK4dm/Jg5ZYGFEo5VOGdyN+EyW/OGvYLOP9vIxAaylCLad4xKDYqTwU4tQgYgBpw5IGEHCdP6nNAE71u5WD/rcuAnRQ02ovkJVy2u7djoxdGIoiCOE4sfpycSlMO/GwZZ/oyjO0p+srNmjoPWLA6NI2Za3tcEdoCiQ98fUC7UCSSL4Z4UCvvdBFIomvdASEYHh47BVzLn8DeHZAhblV1q1STWPpwBD7XVdBKpDakN++pwtUtDwdsLx8q00IjC7W4oA8eRqCB8GZGDJE9Q/CeWYvtQpl5P/HFVK3fiCLaAxvM5JLMbWbugV20Zn5oDtIHGo3WyEfgM0XlB6IH/ziGv63UY+xFhdcEa3Fk+BHZAHPm5SzzBZYx3t7gYfCJGRTAHlbMX6qawwJuF5k= X-MS-Office365-Filtering-Correlation-Id: 8e80246f-b364-4813-106e-08d428a464ef X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR0301MB0741; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 3:JSKC7pRhaMQtH4XjArQ1qvN74xFtq5mXcg8AF9eSm0hgopHoUmGRJse8uW7P162VEkdOZ/Eq8Qzb5WwVkDO2SzMWtbQ9+yRMzwMI3qXkYQHUCQaCxweBQzFVAt/HS+vkakiiW4WlVrbYwh8jL4WUez6wg+BHyvjZqS43j+GGA9qi9A5GKPzLTzlM4vid0c5wSs7rk0GuMrYboEY+QNn7cFiyKXc0sJvKy4wtPp2FAFM53UfYVY1DydEw3KPqX5mcM6O9HGiEo6IwnpoH5CsRzKkv5HOTfwIqjAkvYZ0oGdzmi3IWmJGIwFp6LuKKkHQRXrwKfu85+Bt6vep5OLii+I4YnBUmQRWob5+cPBZeNsA= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 25:BPRjA9xaDs2CDIKPiYFfeTLsiMBPbQ+5nV3vsiSw88eCVyx0TWR8FuvZPg39BTEhvBi1FRF1IG86wtSyuO+cImXidfuEMOkr/9NlKiIs575YY1D/0FIa6QnNr3TuxVdESgv+dIkxCY3Jq6b8fpygOkIPGw/Wb82YzPxynWr/PkqEiIkZaFuot0hulzCaD1Z/yo7vXVQEUmMll2Y/Vr6SaKoBj1lIDQqCttU1pD0hQUpKKR50US/qp0XCj0wE/8Geh5hBcw0eHr5aKxJlppy1lCSQpz9MDyRA2PBJu3DzYchvFgRCE9U+Zlpmv90TVcOOKvZqsSJm7cy4VqTNiSPolNduNMrbCvPyn8uBc0MGdLlnlR1qPaMHWEwDW1mqONZYSfRto2GZOkIDakr4dWeVs88MUTWEQxWqMobGbpPb71PfwnLcERVEcYypU+0qBTR2WxPAnjOJ8t9R2JqPtirfgshh/fiXXcWs3qNx8xejpPyPpzXYJnqmYdmAL5vc/Fv+izFrxTvMdfylwzSFStTYdp5EO86wtGd+NTbJC1ynZAUsr3dnzg/i9UQLtXSFma1Z6z2uD4stlymwfj2RYMFcgKb0cDiBecpQJMm5RShrjBEjoCy0/O08OHEoBxlFo7+I6HMQ8elGzOVDdYgrLaBdsCR7jXzqO9IHDJLxKWtKMRNDRK2hA0ZzedUIOlrUUT23yr7J3efNaLOMDChcOnmOS+Dougrbe67syFXtgb00cpC1eaf7HvTTPwFzise17IPLxKZjwV93wEsJMVbyDwNgxhmO4vUy4BLYZ/kT3ZNZgKw= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 31:npChGMsW8eoqndA78Lpfle4NoNQItjFonA1SswMI//Hw7r/hOAVczWh/9xZANLFKsGgfV+a+oW34ploktKdDGtf3LsugrdEp8Jp2ivhojPJwQkFGEd6VEgf0tnaWP33LR6lmMqQ1Vs9/iVT/TFJ1py8S64liAAoJi4dTS1ggG6fcRcWbExsTs731KjGHlYzMEmDN8WnV6pGgxY71a6+9XYiROH2tKSs6BhCS0VNqFGrRmRtCCjCJKlpDe3JgE8pBYEYw5rS9ZCIrIEE5pqIkiQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13018025)(13015025)(13024025)(13023025)(13017025)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6096035)(20161123565025)(20161123556025)(20161123563025)(20161123559025)(20161123561025); SRVR:BY2PR0301MB0741; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0741; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 4:vl5IXyFbI432a/piBYqszL3oKNhZltHO1vZFgMKbiAhPiK/dkDH7PfUKqlOTdzP/+o7CtSxTewkMccdgRHgf59T2RAj6oJ8BwrYf9ZSLuddFL9O38+ppdl+MYUSjoYVF2LjSOpmrXoZTXQlOZDkAz7VDpWJ9Yhzk20XI1KDv/Na9qNgVntqgUvHyjKn45zrJT9D64bAgSi3OKf9hhPQ97bOZagFcqnwLAAMoSjnQGWMqZqCyfjVbfjwmkKOsFH16NAU2S6oiTIuEW83z8LlMksL7v3C0iro4GDCq9cZ/f4wyfxSrxVdMDL1iyGpgabLrPyua5BRKicnoac2sbHu4AVNRVfpfplIzuUwyjUM+pzBQPWT/xPLhZUcYCR+gV7Z8n0J7ypwBu+I6IS88ps96hqqUcPpmO8MD68f83gvuiCXtNxWdtJi4Uy8oVGlSih9s+1V+ZKJnuV78oqBO0spyPkIfR3TJiW31vCa/LK0Q0RutkkvIioraovLMZl+vdCuGiFDK5sE/qXI5s3IVJdrJuaalzrDZqm2FUHMZl1zXdZA5RVyjeroZ+38wghpihBIAXuWypBAxnd997lI1fFXG8SoH5Rkj+P7GK6zEGHfd+Y1yV3cmQL8UGNTnUOdLfT/3cTdnT9/q9jEP67yPWtKiSZIzJgi29OMC7mZr6XAhO9bFQ0czF7fhL1oTuDCw+AV7S++6U1JpZTjgXF6lHuBfPg== X-Forefront-PRVS: 0162ACCC24 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0301MB0741; 23:ce2XSIgqmg0rd7uLGi9d2+s5Db9S70PrTXJ?= =?Windows-1252?Q?92i4buMS473oyPJDLsdHL0LuyfZF7V56D6sGICz60UsAxdMRIdDH4bOb?= =?Windows-1252?Q?nuOPRSzkWdAGhIXDgtFcDkuzY3uqM3MToXISeVeyxupuc+VeUwiYac3P?= =?Windows-1252?Q?WnduUE+OV0Odfw6KDI/ri3xrzDftxTPT7KtAUT1z78eP5ehlthJ+R2SP?= =?Windows-1252?Q?aEVh6gsT1l6GIqSmMLqiNXAuJvY6REJu5aWOPNxeasvH/x3RFWEpLjzX?= =?Windows-1252?Q?IsSn5ki5ex/9wAsXhnc7gm7+JE4RyYjmQjdnktWf5f9h0Z+c5nGC7lCK?= =?Windows-1252?Q?nUPIuNPZx/1dqDBPUWoAJrC7vOlnKODg540ow1LhTlUz/vHJ+DodO8uJ?= =?Windows-1252?Q?nwGCpZITBSqEaX1WtLPwH8XOf2ZgQfHfmi7y0BusmPQF5roBTsvQsxnE?= =?Windows-1252?Q?A+TiSfkba23xQwvomQHeAQANmhdX888btrnv19rAM5SAcDLor2No9EUF?= =?Windows-1252?Q?6CdkAMbQTzxD6BvtMM2AHG6soyXnFZOnE82CdBqTt0CtZHNQPqjc9z9b?= =?Windows-1252?Q?Kts697GmD6HSlT4htsLNAVGsS9fx17aGxqjLN05qoAUoV8xSzDcIgFaD?= =?Windows-1252?Q?4CaLG+Fy5t6DDAL9kEx3S9+pQuYdboImtTXurpMj3mQE/7cGDte6uQCK?= =?Windows-1252?Q?EuZIIPxrNYGEr8WNda49r5ZC2RHlrDrE56rmb+3NvKV6Doek6x6PjOPt?= =?Windows-1252?Q?bjwTmdNWWtUojEdsNdFtnm6vHQI2RUsJLQBdkzyw63cdwFzo90kzkHQQ?= =?Windows-1252?Q?0x9Uun+7XXiNd6S7ZfG8mg1S4C9I5o0PtHiE0K8oDSk9/LuHZnpU3jHk?= =?Windows-1252?Q?wg9ZOqJZVlFEnwbcZiznw2LEIuIbWNvSDPyqmtKvcwuEDBqe7SJ8qJsQ?= =?Windows-1252?Q?jkPLO9Wq46bpKcybu+KRRLAGxFlQLTdlBCn6+J5yhVVjoxShebVoQdLQ?= =?Windows-1252?Q?Vd3S3hKTIuRwPMrMcK74KuAAQ5uogaZzPlyimrN9PkPXBR4NKHGv9lH8?= =?Windows-1252?Q?bzpfpbt382yP8oNKDXX5m20IVtAkX1qZpFhgeQNOo6fEjnmkiyHXzzPh?= =?Windows-1252?Q?BhKEa8v/oXtXzePru1VF3fTJFNaZpqNJg0B/Rzyui5pyYSJFgf7HCfjB?= =?Windows-1252?Q?f+CWC3YdBgTny0j/n6ZBOEgROtOH4MuVJcGQ2wRtIcxBAoruokjeLudM?= =?Windows-1252?Q?IMs/VTTj58ZhOCJmeCmnIVhMJ0BZQYoLo/he/1qar0GhFwFG+yNGdlEj?= =?Windows-1252?Q?kVqlugZnG2HOpGUcL1N+jUzkrVYMLjxSMl/BT6xwuJ9nBwQY2XAIR4Ap?= =?Windows-1252?Q?n1DzfgvhRkCCPLvoyI6Qn/C4kbdEZK2RmjTsEYZzwM4/PV6UA63IZgQB?= =?Windows-1252?Q?QfODFHV7s8tyBMljbJ+GgS9IiR40xlJ+nwC9mtXyiwPKvP483Bb3XQrz?= =?Windows-1252?Q?8V23OAcIv5bRoAwkYp9xsxA8/TsWyY7gaZNlKKS4uWkwt5nNAqM+YYJL?= =?Windows-1252?Q?L4yIb4nn3cLKzj2wHudQdF8u++PJnZKEUVXBuMkhHO50FCpTzkEzuTgo?= =?Windows-1252?Q?bhDE8yU10Wmm605Pymqkcex4=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 6:b1qI9pkLXwDfhadbbI+4u980Ky1ZW8wABYl3qTrCHnK3C74i0wJMm3fJ3bBgZuav/vNwoc2dlsqRFks9n4TOZWoufSaK55CHpdQad8VvDovla7yrF+b4KGQwRlrFOJ5+6ZgiXkbSevIzMGoNJ9/Hs7d/JyajxLbEm8J7O3gL9CBenIH4cUKgO4oYOjqjz7R4yHa/zzS6d5PIrzipWO0GBjHT6Tq175iKjn7jPbrk+L4gR7lzEnswh1h/Sd3a9Oz0TZ+YmxIPu2xZjQAAQjyLTvAp0UYMcryFgQektL2PLmgG1EcUQBUTw892CxyTEQ3n5fv+EuWqm7jEHMKPVQGbiCKd1U4/ZxIZEbcFD6CjvEOwnniciczz0mhzLpYJeeER0x+4ckpkdI5BhUrzvF1q7bz/awHmoS5pkiGUXWLZACkeknHsoOW+QUFU1KK+DmOt; 5:neQlKBpVuoJh2imy+YwwrAyHI55DKVByuDjjfQ28IEsZNC4tSWQlw1u1K6YIwPtRYHqmkFTkWtcD5mdMs5bJ0cx2wdCcFara0jO0GXaUEEcTU0QBHpAu2tMcAYliHMdEAz9amgYawEh7cI3eUYEZsUSU1HMgvECvO9m7r10GKUbiqtUffmMbL/1TiA+npy0+; 24:7rFkrdOz6xw48+W3uS9ldfbKi/QdLzYzxc7Whxh/6jOOcEc56nED+78qAv/zHTJvD9AvMfqh/LnLeHGbaeX2s8Jfd7vGLzM9kDp8AwYGLaA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 7:oqnBIae4oMiHn36G3U77m1hPkznlSKx8UR3FBlNFNGgvuI/11O2wbV5nBJzB8lB5TL7HfBDi0Cg36wATO+k35LIBfnfsGb2NlDex7ptJ1IKG2SolZRYUTjwcDsgP1FkHG9KYfZpAM2vNa4WGJBg03R52/HHJtz9Ky3mFOtPL3zx8ddv/nnnLEleWHPo+mUCZ8j7M8NhNbiXKo6EF2SezwGrtCrYEg3SII+DwpBYP/5m+NSqTdnqgHj9P+54MGZx32BcDlTJoGpYDmg1nYsNxPNZPhJ1h/36PREXv4bXiQUWEHHEb/cmAN7RWZ3f28YDtxuVpvD+ExJkVX3baCDPUsJHRYb5zzQwEHCyJUrPvRP2yCm2+nrwfXjRqJ4yU4JAUQBxKYJn4tyD4L1x99TghUSJbXLOHpNuhs0D2VuijtpzOZT7UsIYYqYOYd7sjleYj7fwWWtM+NSC+clQxpHvVag== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 06:49:48.7830 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0741 Subject: Re: [dpdk-dev] [PATCH 01/13] ethdev: increase length ethernet device internal name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 06:49:54 -0000 On Tuesday 20 December 2016 03:29 AM, Stephen Hemminger wrote: > Allow sufficicent space for UUID in string form (36+1). > Needed to use UUID with Hyper-V > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > lib/librte_ether/rte_ethdev.h | 6 +++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 2d17bc6e..b83f23a1 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -58,6 +58,9 @@ Deprecation Notices > ``port`` field, may be moved or removed as part of this mbuf work. A > ``timestamp`` will also be added. > > +* ethdev: for 17.02 the size of internal device name will be increased > + to 40 characters to allow for storing UUID. > + > * The mbuf flags PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated and > are respectively replaced by PKT_RX_VLAN_STRIPPED and > PKT_RX_QINQ_STRIPPED, that are better described. The old flags and > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 96781792..3c85e331 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1652,7 +1652,11 @@ struct rte_eth_dev_sriov { > }; > #define RTE_ETH_DEV_SRIOV(dev) ((dev)->data->sriov) > > -#define RTE_ETH_NAME_MAX_LEN (32) > +/* > + * Internal identifier length > + * Sufficiently large to allow for UUID or PCI address > + */ > +#define RTE_ETH_NAME_MAX_LEN 40 Just to clarify my doubt: UUID is 36 byte long. So, 4 extra bytes are to keep the name length 4 byte aligned (along with one byte of \0)? Or, PCI based addressing can stretch 40 bytes? > > /** > * @internal >