From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BA46447CD; Fri, 1 Jun 2018 16:58:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2018 07:58:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,467,1520924400"; d="scan'208";a="60457733" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2018 07:58:06 -0700 To: Dariusz Stojaczyk , dev@dpdk.org Cc: stable@dpdk.org References: <1527859375-160704-1-git-send-email-dariuszx.stojaczyk@intel.com> <1527860679-110206-1-git-send-email-dariuszx.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <3d4f9187-7342-46bc-d598-99c7fe35d725@intel.com> Date: Fri, 1 Jun 2018 15:58:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1527860679-110206-1-git-send-email-dariuszx.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] memory: fix segfault on rte_mem_virt2memseg() call with invalid addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 14:58:12 -0000 On 01-Jun-18 2:44 PM, Dariusz Stojaczyk wrote: > When trying to use it with an address that's not > managed by DPDK it would segfault due to a missing > check. The doc says this function returns either > a pointer or NULL, so let it do so. > > Changes from v1: > * removed gerrit change id > * added "git fixline" tags > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > --- Please include Acks (Reviews, Tests...) in the commit message if they were given for the previous version of the patchset. Also do not list changes you've made in the commit message; instead, list changes in the patch notes, after the first "---", like so: area: fix blah This patch fixes this and that. Fixes: 123456 ("area: a buggy commit") Cc: bug.author@example.com Signed-off-by: Fix Author Acked-by: fix.reviewer@example.com --- v2: - Fixed this - Fixed that -- Thanks, Anatoly